Skip to content

Multipart sets file name as the field/part name #7

@vincentjames501

Description

@vincentjames501

It looks like file name is conflated a bit in ->multipart-body. The file-name is optional yet it's always set to name. The field name and filename should be treated as separate entities. Does something like this seem reasonable?

(doseq [{:keys [name content part-name mime-type file-name]} parts]
      (.addFormDataPart builder (or part-name name) file-name (->request-body mime-type content)))

This allows us to set the name to something like "image" and file-name to something like "my-image.jpg" a bit more easily or simply omit the filename if we don't have one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions