protoid now contains validateprototypeattribute features

Author: KayzelW

Content.Client/Backmen/Blob/BlobChemSwapMenu.xaml.cs

@@ -46,8 +46,7 @@ protected override void ExitedTree()
         ClearGrid();
     }
 
-    [ValidatePrototypeId<EntityPrototype>]
-    private const string NormalBlobTile = "NormalBlobTile";
+    private readonly EntProtoId NormalBlobTile = "NormalBlobTile";
 
     private void UpdateGrid()
     {

Content.Client/Backmen/Blob/BlobCoreActionSystem.cs

@@ -17,8 +17,7 @@ public override void Initialize()
         SubscribeNetworkEvent<BlobAttackEvent>(OnBlobAttack);
     }
 
-    [ValidatePrototypeId<EntityPrototype>]
-    private const string Animation = "WeaponArcPunch";
+    private readonly EntProtoId Animation = "WeaponArcPunch";
 
     private void OnBlobAttack(BlobAttackEvent ev)
     {

Content.Client/Backmen/Blob/BlobObserverSystem.cs

@@ -32,8 +32,7 @@ public override void Initialize()
         SubscribeNetworkEvent<RoundRestartCleanupEvent>(RoundRestartCleanup);
     }
 
-    [ValidatePrototypeId<FactionIconPrototype>]
-    private const string BlobFaction = "BlobFaction";
+    private readonly ProtoId<FactionIconPrototype>  BlobFaction = "BlobFaction";
 
     private void OnShowBlobIcon<T>(Entity<T> ent, ref GetStatusIconsEvent args) where T : Component
     {

Content.Client/Backmen/Flesh/FleshCultist.cs

@@ -18,8 +18,7 @@ public override void Initialize()
         SubscribeLocalEvent<FleshCultistComponent, GetStatusIconsEvent>(OnShowCultIcon);
     }
 
-    [ValidatePrototypeId<FactionIconPrototype>]
-    private const string FleshcultistFaction = "FleshcultistFaction";
+    private readonly ProtoId<FactionIconPrototype> FleshcultistFaction = "FleshcultistFaction";
 
     private void OnShowCultIcon(Entity<FleshCultistComponent> ent, ref GetStatusIconsEvent args)
     {

Content.Client/Backmen/GhostTheme/GhostThemeSystem.cs

@@ -28,8 +28,7 @@ private void OnInit(EntityUid uid, GhostThemeComponent component, ref AfterAutoH
         Apply(uid, ghostThemePrototype);
     }
 
-    [ValidatePrototypeId<EntityPrototype>]
-    private const string MobObserver = "MobObserver";
+    private readonly EntProtoId MobObserver = "MobObserver";
 
     public void Apply(EntityUid uid, GhostThemePrototype ghostThemePrototype)
     {

Content.Client/Backmen/Overlays/Shaders/EtherealOverlay.cs

@@ -15,7 +15,7 @@ public sealed class EtherealOverlay : Overlay
     public override OverlaySpace Space => OverlaySpace.WorldSpaceBelowFOV;
     private readonly ShaderInstance _shader;
 
-    [ValidatePrototypeId<ShaderPrototype>] private const string Ethereal = "Ethereal";
+    private readonly ProtoId<ShaderPrototype> Ethereal = "Ethereal";
 
     public EtherealOverlay()
     {

Content.Client/Backmen/Overlays/Systems/NearsightedSystem.cs

@@ -3,6 +3,7 @@
 using Robust.Shared.Network;
 using Content.Shared.Tag;
 using Content.Shared.Backmen.Traits;
+using Robust.Shared.Prototypes;
 
 namespace Content.Client.Backmen.Overlays;
 public sealed class NearsightedSystem : EntitySystem
@@ -19,8 +20,7 @@ public override void Initialize()
         _overlay = new Overlays.NearsightedOverlay();
     }
 
-    [ValidatePrototypeId<TagPrototype>]
-    private const string TagName = "GlassesNearsight";
+    private readonly ProtoId<TagPrototype> TagName = "GlassesNearsight";
 
     public override void Update(float frameTime)
     {

Content.Client/Backmen/SponsorManager/UI/SponsorWindow.cs

@@ -36,8 +36,7 @@ public SponsorWindow()
 
     private List<GhostThemePrototype>? _ghostThemePrototypes;
 
-    [ValidatePrototypeId<EntityPrototype>]
-    private const string ObserverPrototypeName = "MobObserver";
+    private readonly EntProtoId ObserverPrototypeName = "MobObserver";
 
     protected override void Opened()
     {

Content.Client/Backmen/StationAI/AiEnemySystem.cs

@@ -22,8 +22,7 @@ public override void Initialize()
         _ghostQuery = GetEntityQuery<GhostComponent>();
     }
 
-    [ValidatePrototypeId<SecurityIconPrototype>]
-    private const string AiEnemyStatus = "AiIconEnemyTarget";
+    private readonly ProtoId<SecurityIconPrototype> AiEnemyStatus = "AiIconEnemyTarget";
     private void GetIcon(Entity<AIEnemyNTComponent> target, ref GetStatusIconsEvent args)
     {
         var ent = _player.LocalSession?.AttachedEntity ?? EntityUid.Invalid;

Content.Client/Backmen/Teams/TdmTeamSystem.cs

@@ -22,12 +22,9 @@ protected override void SetTeam(Entity<TdmMemberComponent?> target, StationTeamM
         // do nothing on client
     }
 
-    [ValidatePrototypeId<FactionIconPrototype>]
-    private const string TeamA = "TeamAFaction";
-    [ValidatePrototypeId<FactionIconPrototype>]
-    private const string TeamB = "TeamBFaction";
-    [ValidatePrototypeId<FactionIconPrototype>]
-    private const string TeamNoTeam = "Team0Faction";
+    private readonly ProtoId<FactionIconPrototype> TeamA = "TeamAFaction";
+    private readonly ProtoId<FactionIconPrototype> TeamB = "TeamBFaction";
+    private readonly ProtoId<FactionIconPrototype> TeamNoTeam = "Team0Faction";
 
     private void OnGetTeamIcon(Entity<TdmMemberComponent> ent, ref GetStatusIconsEvent args)
     {