Generation of sitemap happens after public folder is copied

[nader-eloshaiker]

When running the plugin to generate the sitemap.xml file. it generates the file after the contents of the public folder is copied into the dist folder.
This is because the plugin runs on the closeBundle hook.
If the buildStart hook is used, then the file will be included in the dist folder.
I have verified this solution.

[Ryanjso]

Nice find :) Do you mind opening a PR with the change? I will accept

[nader-eloshaiker]

Sure will make some time today or tomorrow

[nader-eloshaiker]

PR for your review #6

[Ryanjso]

Hey @nader-eloshaiker - I did a bit more research and I'm not sure this change is correct. buildStart isn't mean't for long processes as it runs on dev server start. It also won't necessarily have all the info available to gen the sitemap since it won't know which routes are being included. Vite recommends writeBundle or closeBundle for something like this.

I checked with a somewhat more popular package and they also use closeBundle

The sitemap should be included in your output 🤔

[royz]

Hey @Ryanjso, I have opened a PR #7 which should solve the issue. After this change, the sitemap.xml is written directly to the outDir instead of public folder. It also considers custom outDir specified in vite config.