Skip to content
This repository was archived by the owner on Sep 12, 2025. It is now read-only.
This repository was archived by the owner on Sep 12, 2025. It is now read-only.

UI5 Migrate should return != 0, if files have been modified  #209

@bkrrrr

Description

@bkrrrr

This tool would be great to check UI5 apps in Github actions for none recommended code pattern.
The only thing missing, is a return code that lets a ci fail e.g. -1.

image

Workaround:

name: 'migration'
description: 'see https://www.npmjs.com/package/@ui5/migration'
runs:
  using: "composite"
  steps:
      - name: Install
        run: npm install --global @ui5/migration
        shell: bash
      # see https://github.com/SAP/ui5-migration/issues/209
      - name: run-migration 
        run: | 
          ui5-migration migrate
          echo 'delta<<EOF' >> $GITHUB_ENV
          git diff --color webapp/  >> $GITHUB_ENV
          echo 'EOF' >> $GITHUB_ENV
        shell: bash
      - name: check
        run: echo "${{ env.delta }}"  && exit ${{ env.delta && 1 || 0 }}
        shell: bash

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions