fix(core): fix for variable declaration because of more strict mode (#1802)

Author: hgw77

plugins/identity/app/javascript/plugin/project_members.js

@@ -62,7 +62,7 @@ const multiselect = (elementsSelector) =>
         label.textContent = value
         newLabels.push(label.outerHTML)
       }
-      for (value of Array.from(valuesToRemove)) {
+      for (var value of Array.from(valuesToRemove)) {
         const label = document.createElement("s")
         label.textContent = value
         newLabels.push(label.outerHTML)

plugins/kubernetes/app/javascript/widgets/app/components/clusters/advancedoptions.jsx

@@ -137,7 +137,7 @@ let AdvancedOptions = function ({
                             (() => {
                               const result = []
                               for (
-                                i = 0;
+                                let i = 0;
                                 i < metaData.securityGroups.length;
                                 i++
                               ) {
@@ -189,7 +189,7 @@ let AdvancedOptions = function ({
                           },
                           (() => {
                             const result1 = []
-                            for (i = 0; i < metaData.routers.length; i++) {
+                            for (let i = 0; i < metaData.routers.length; i++) {
                               var router = metaData.routers[i]
                               result1.push(
                                 <option value={router.id} key={i}>
@@ -244,7 +244,7 @@ let AdvancedOptions = function ({
                             (() => {
                               const result2 = []
                               for (
-                                i = 0;
+                                let i = 0;
                                 i < selectedRouter.networks.length;
                                 i++
                               ) {
@@ -303,7 +303,7 @@ let AdvancedOptions = function ({
                             (() => {
                               const result3 = []
                               for (
-                                i = 0;
+                                let i = 0;
                                 i < selectedNetwork.subnets.length;
                                 i++
                               ) {

plugins/kubernetes/app/javascript/widgets/app/components/clusters/edit.jsx

@@ -125,7 +125,7 @@ class EditCluster extends React.Component {
                         <option value="">None</option>
                         {(() => {
                           const result = []
-                          for (keyPair of Array.from(metaData.keyPairs)) {
+                          for (let keyPair of Array.from(metaData.keyPairs)) {
                             result.push(
                               <option
                                 value={keyPair.publicKey}

plugins/kubernetes/app/javascript/widgets/app/init.jsx

@@ -9,8 +9,8 @@ import App from "./components/app"
 import { setAjaxHelper, setBackendAjaxClient } from "./actions/ajax_helper"
 import { createWidget } from "lib/widget"
 
-composeEnhancers = window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || compose
-store = createStore(AppReducers, composeEnhancers(applyMiddleware(ReduxThunk)))
+const composeEnhancers = window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || compose
+const store = createStore(AppReducers, composeEnhancers(applyMiddleware(ReduxThunk)))
 
 const AppProvider = ({ permissions, authToken, kubernikusBaseUrl }) => {
   setAjaxHelper(new ReactAjaxHelper(kubernikusBaseUrl, { authToken }))

plugins/kubernetes/app/javascript/widgets/app/lib/helpers.js

@@ -16,10 +16,10 @@ ReactHelpers.mergeObjects = function (obj1, obj2, obj3) {
   for (var key in obj1) {
     result[key] = obj1[key]
   }
-  for (key in obj2) {
+  for (var key in obj2) {
     result[key] = obj2[key]
   }
-  for (key in obj3) {
+  for (var key in obj3) {
     result[key] = obj3[key]
   }
   return result

plugins/kubernetes/app/javascript/widgets/app/lib/modal.jsx

@@ -83,7 +83,7 @@ ReactModal.Wrapper = (title, WrappedComponent, options = {}) =>
 ReactModal.Reducer = (state = [], action) => {
   switch (action.type) {
     case ReactModal.SHOW_MODAL: {
-      for (m of state) {
+      for (const m of state) {
         if (m.modalType === action.modalType) {
           return state
         }
@@ -99,7 +99,7 @@ ReactModal.Reducer = (state = [], action) => {
     }
     case ReactModal.HIDE_MODAL: {
       let newState = state.slice()
-      for (i in state) {
+      for (const i in state) {
         const m = state[i]
         if (m.modalType === action.modalType) newState.splice(i, 1)
       }