chore(core): remove unused code/comments

Author: andypf

plugins/networking/app/javascript/widgets/ports/components/ports/show.tsx

@@ -1,7 +1,6 @@
 import React, { useState, useEffect } from "react"
 // @ts-expect-error – missing types for react-bootstrap
-import { Modal, Button, Tabs, Tab } from "react-bootstrap"
-import { Link } from "react-router-dom"
+import { Modal, Button} from "react-bootstrap"
 
 interface RowProps {
   label: string

plugins/shared_filesystem_storage/app/javascript/widgets/app/components/error_messages/list.tsx

@@ -0,0 +1,98 @@
+import React, { useState, useEffect } from "react"
+// @ts-expect-error - no types available
+import { DefeatableLink } from "lib/components/defeatable_link"
+// @ts-expect-error - no types available
+import { policy } from "lib/policy"
+import { Modal, Button } from "react-bootstrap"
+import ErrorMessageItem from "./item"
+
+interface ErrorMessage {
+  id: string
+  message: string
+  level: string
+  created_at: string
+  [key: string]: unknown
+}
+
+interface ErrorMessagesState {
+  items: ErrorMessage[]
+  isFetching: boolean
+}
+
+interface ErrorMessageListProps {
+  errorMessages?: ErrorMessagesState
+  loadErrorMessagesOnce: () => void
+  match?: {
+    params: {
+      type?: string
+    }
+  }
+  history: {
+    replace: (path: string) => void
+  }
+}
+
+const ErrorMessageList: React.FC<ErrorMessageListProps> = ({
+  errorMessages,
+  loadErrorMessagesOnce,
+  match,
+  history,
+}) => {
+  const [show, setShow] = useState(true)
+
+  // Load dependencies on mount and when they change
+  useEffect(() => {
+    loadErrorMessagesOnce()
+  }, [loadErrorMessagesOnce])
+
+  const restoreUrl = () => {
+    const type = match && match.params.type
+    if (!show) history.replace(type || "shares")
+  }
+
+  const hide = (e?: React.MouseEvent) => {
+    if (e) e.stopPropagation()
+    setShow(false)
+  }
+
+  return (
+    <Modal show={show} onExited={restoreUrl} onHide={hide} size="lg" aria-labelledby="contained-modal-title-lg">
+      <Modal.Header closeButton>
+        <Modal.Title id="contained-modal-title-lg">Error Log</Modal.Title>
+      </Modal.Header>
+      <Modal.Body>
+        {!errorMessages || errorMessages.isFetching ? (
+          <div>
+            <span className="spinner" />
+            Loading...
+          </div>
+        ) : (
+          <table className="table error-messages">
+            <thead>
+              <tr>
+                <th>Level</th>
+                <th>Error</th>
+                <th>Created</th>
+              </tr>
+            </thead>
+            <tbody>
+              {errorMessages.items.length === 0 && (
+                <tr>
+                  <td colSpan={3}>No errors found.</td>
+                </tr>
+              )}
+              {errorMessages.items.map((errorMessage, index) => (
+                <ErrorMessageItem key={errorMessage.id} errorMessage={errorMessage} />
+              ))}
+            </tbody>
+          </table>
+        )}
+      </Modal.Body>
+      <Modal.Footer>
+        <Button onClick={hide}>Close</Button>
+      </Modal.Footer>
+    </Modal>
+  )
+}
+
+export default ErrorMessageList

plugins/shared_filesystem_storage/app/javascript/widgets/app/components/security_services/item.tsx

@@ -0,0 +1,72 @@
+import React from "react"
+import { Link } from "react-router-dom"
+// @ts-expect-error - lib/policy has no TypeScript definitions
+import { policy } from "lib/policy"
+
+interface SecurityService {
+  id: string
+  name?: string
+  type: string
+  isDeleting?: boolean
+}
+
+interface ItemProps {
+  securityService: SecurityService
+  handleDelete: (id: string) => void
+}
+
+const Item: React.FC<ItemProps> = ({ securityService, handleDelete }) => (
+  <tr className={securityService.isDeleting ? "updating" : ""}>
+    <td>
+      <Link to={`/security-services/${securityService.id}/show`}>{securityService.name || securityService.id}</Link>
+      {securityService.name && (
+        <>
+          <br />
+          <span className="info-text">{securityService.id}</span>
+        </>
+      )}
+    </td>
+    <td>{securityService.type}</td>
+    <td className="snug">
+      {(policy.isAllowed("shared_filesystem_storage:security_service_delete") ||
+        policy.isAllowed("shared_filesystem_storage:security_service_update")) && (
+        <div className="btn-group">
+          <button
+            className="btn btn-default btn-sm dropdown-toggle"
+            type="button"
+            data-toggle="dropdown"
+            aria-expanded={true}
+          >
+            <span className="fa fa-cog"></span>
+          </button>
+
+          <ul className="dropdown-menu dropdown-menu-right" role="menu">
+            {policy.isAllowed("shared_filesystem_storage:security_service_delete") && (
+              <li>
+                <a
+                  href="#"
+                  onClick={(e) => {
+                    e.preventDefault()
+                    handleDelete(securityService.id)
+                  }}
+                >
+                  Delete
+                </a>
+              </li>
+            )}
+            {policy.isAllowed("shared_filesystem_storage:security_service_update") && (
+              <li>
+                <Link to={`/security-services/${securityService.id}/edit`}>Edit</Link>
+              </li>
+            )}
+            <li>
+              <Link to={`/security-services/${securityService.id}/error-log`}>Error Log</Link>
+            </li>
+          </ul>
+        </div>
+      )}
+    </td>
+  </tr>
+)
+
+export default Item

plugins/shared_filesystem_storage/app/javascript/widgets/app/components/security_services/list.tsx

@@ -0,0 +1,106 @@
+/* eslint-disable react/no-unescaped-entities */
+import React, { useEffect } from "react"
+import SecurityServiceItem from "./item"
+// @ts-expect-error - lib/policy has no TypeScript definitions
+import { policy } from "lib/policy"
+// @ts-expect-error - lib/components/defeatable_link has no TypeScript definitions
+import { DefeatableLink } from "lib/components/defeatable_link"
+// @ts-expect-error - lib/components/Overlay has no TypeScript definitions
+import { Popover } from "lib/components/Overlay"
+
+interface SecurityService {
+  id: string
+  name?: string
+  type: string
+  isDeleting?: boolean
+}
+
+interface SecurityServiceListProps {
+  active: boolean
+  isFetching: boolean
+  securityServices: SecurityService[]
+  loadSecurityServicesOnce: () => void
+  handleDelete: (id: string) => void
+}
+
+const CreateNewButton: React.FC = () => {
+  if (!policy.isAllowed("shared_filesystem_storage:share_network_create")) {
+    return (
+      <Popover
+        title="Missing Create Permission"
+        content="You don't have permission to create a security service. Please check if
+        you have the role sharedfilesystem_admin."
+        placement="top"
+      >
+        <button className="btn btn-primary disabled">
+          <i className="fa fa-fw fa-exclamation-triangle fa-2"></i> Create New
+        </button>
+      </Popover>
+    )
+  }
+
+  return (
+    <DefeatableLink to="/security-services/new" className="btn btn-primary">
+      Create New
+    </DefeatableLink>
+  )
+}
+
+const SecurityServiceList: React.FC<SecurityServiceListProps> = ({
+  active,
+  isFetching,
+  securityServices,
+  loadSecurityServicesOnce,
+  handleDelete,
+}) => {
+  useEffect(() => {
+    if (active) {
+      loadSecurityServicesOnce()
+    }
+  }, [active, loadSecurityServicesOnce])
+
+  return (
+    <>
+      <div className="toolbar">
+        <div className="main-buttons">
+          <CreateNewButton />
+        </div>
+      </div>
+
+      {isFetching ? (
+        <div className="loadig">
+          <span className="spinner" />
+          {"Loading..."}
+        </div>
+      ) : (
+        <table className="table security-services">
+          <thead>
+            <tr>
+              <th>Name</th>
+              <th>Type</th>
+              <th></th>
+            </tr>
+          </thead>
+
+          <tbody>
+            {securityServices.length === 0 ? (
+              <tr>
+                <td colSpan={3}>No Security Service found.</td>
+              </tr>
+            ) : (
+              securityServices.map((securityService) => (
+                <SecurityServiceItem
+                  key={securityService.id}
+                  securityService={securityService}
+                  handleDelete={handleDelete}
+                />
+              ))
+            )}
+          </tbody>
+        </table>
+      )}
+    </>
+  )
+}
+
+export default SecurityServiceList

plugins/shared_filesystem_storage/app/javascript/widgets/app/components/share_networks/edit.tsx

@@ -0,0 +1,68 @@
+import React, { useState, useEffect } from "react"
+import { Modal, Button } from "react-bootstrap"
+// @ts-expect-error - lib/elektra-form has no TypeScript definitions
+import { Form } from "lib/elektra-form"
+
+interface ShareNetwork {
+  id: string
+  name?: string
+  description?: string
+}
+
+interface EditShareNetworkFormProps {
+  shareNetwork: ShareNetwork | null
+  history: {
+    replace: (path: string) => void
+  }
+  handleSubmit: (values: ShareNetwork) => Promise<void>
+}
+
+const EditShareNetworkForm: React.FC<EditShareNetworkFormProps> = ({ shareNetwork, history, handleSubmit }) => {
+  const [show, setShow] = useState(shareNetwork !== null)
+
+  useEffect(() => {
+    setShow(shareNetwork !== null)
+  }, [shareNetwork])
+
+  const validate = (values: ShareNetwork): boolean => {
+    return Boolean(values.name)
+  }
+
+  const close = (e?: React.MouseEvent) => {
+    if (e) e.stopPropagation()
+    setShow(false)
+    setTimeout(() => history.replace("/share-networks"), 300)
+  }
+
+  const onSubmit = (values: ShareNetwork) => {
+    return handleSubmit(values).then(() => close())
+  }
+
+  return (
+    <Modal show={show} onHide={close} size="lg" aria-labelledby="contained-modal-title-lg">
+      <Modal.Header closeButton>
+        <Modal.Title id="contained-modal-title-lg">Edit Share Network</Modal.Title>
+      </Modal.Header>
+
+      <Form validate={validate} initialValues={shareNetwork} className="form form-horizontal" onSubmit={onSubmit}>
+        <Modal.Body>
+          <Form.Errors />
+
+          <Form.ElementHorizontal label="Name" name="name">
+            <Form.Input elementType="input" type="text" name="name" />
+          </Form.ElementHorizontal>
+
+          <Form.ElementHorizontal label="Description" name="description">
+            <Form.Input elementType="textarea" className="text optional form-control" name="description" />
+          </Form.ElementHorizontal>
+        </Modal.Body>
+        <Modal.Footer>
+          <Button onClick={close}>Cancel</Button>
+          <Form.SubmitButton label="Save" />
+        </Modal.Footer>
+      </Form>
+    </Modal>
+  )
+}
+
+export default EditShareNetworkForm