fix(networking): handle errors when fetching PTR records in floating_ips (#1888)

Author: andypf

plugins/networking/app/controllers/networking/floating_ips_controller.rb

@@ -12,7 +12,13 @@ class FloatingIpsController < DashboardController
     def index
       per_page = params[:per_page] || 20
       @fip_ptr_records = []
-      @fip_ptr_records = services.dns_service.list_floating_ips_ptr_records
+      @fip_ptr_records = begin 
+        services.dns_service.list_floating_ips_ptr_records 
+      rescue StandardError => e
+        logger.error("Error fetching floating IP PTR records: #{e.message}")
+        []
+      end
+      
       @floating_ips =
         paginatable(per_page: per_page) do |pagination_options|
           services.networking.project_floating_ips(

plugins/networking/app/views/networking/floating_ips/_item.html.haml

@@ -8,13 +8,14 @@
       = floating_ip.floating_ip_address
       - if floating_ip.subnet_object
         %span.info-text= " / #{floating_ip.subnet_object.name}"
-        %br
-        %small.info-text
-          - if defined?(fip_ptr_record) && fip_ptr_record&.ptrdname.present?
-            = fip_ptr_record.ptrdname
-          - else
-            - if floating_ip.dns_domain
-              = "#{floating_ip.dns_name}.#{floating_ip.dns_domain}"
+
+        - if defined?(fip_ptr_record) && fip_ptr_record&.ptrdname.present?
+          %br
+          %small.info-text= fip_ptr_record.ptrdname
+        - elsif floating_ip.dns_domain.present? && floating_ip.dns_name.present?
+          %br
+          %small.info-text= "#{floating_ip.dns_name}.#{floating_ip.dns_domain}"
+            
   %td
     - if floating_ip.fixed_ip_address.present?
       = link_to plugin('networking').floating_ip_path(floating_ip.id), data: {modal: true} do