refactor(cli): complete remaining audit items — validate status, extract helpers, add 8 test cases

- Fix #28: Validate ResponsePayload status is string before cast in handleMessage()
- Fix #43: Extract settleHandler() private method to reduce duplication
- Fix #41: Normalize createMockWS → createMockWs for consistency
- Fix #39: Extract captureStream() parameterized helper to replace captureStdout/captureStderr
- Fix #47: Filter empty arrays in displayGenericPayload to avoid spurious output
- Test #21-#22: Add ConnectionError edge cases (empty cause, non-Error cause)
- Test #23: Add ServerFailureError without hashIdsFailed
- Test #24: Add post-connect onerror rejection test
- Test #25: Add displayGenericPayload failure path test
- Test #26: Add NaN and Infinity timeout validation tests

All tests pass, zero lint warnings.

Author: jerome-benoit

ui/cli/src/output/table.ts

@@ -42,8 +42,11 @@ export const outputTable = (payload: ResponsePayload): void => {
 
 const displayGenericPayload = (payload: ResponsePayload): void => {
   const { status, ...rest } = payload
-  if (Object.keys(rest).length > 0) {
-    process.stdout.write(JSON.stringify(rest, null, 2) + '\n')
+  const meaningful = Object.fromEntries(
+    Object.entries(rest).filter(([, v]) => v != null && !(Array.isArray(v) && v.length === 0))
+  )
+  if (Object.keys(meaningful).length > 0) {
+    process.stdout.write(JSON.stringify(meaningful, null, 2) + '\n')
   } else if (status === ResponseStatus.SUCCESS) {
     process.stdout.write(chalk.green('✓ Success\n'))
   } else {

ui/cli/tests/lifecycle.test.ts

@@ -20,6 +20,17 @@ await describe('lifecycle', async () => {
     assert.strictEqual(err.cause, cause)
   })
 
+  await it('should create ConnectionError without cause suffix when cause message is empty', () => {
+    const err = new ConnectionError('ws://localhost:8080', new Error(''))
+    assert.strictEqual(err.message, 'Failed to connect to ws://localhost:8080')
+  })
+
+  await it('should create ConnectionError without cause suffix when cause is not an Error', () => {
+    const err = new ConnectionError('ws://localhost:8080', 'string cause')
+    assert.strictEqual(err.message, 'Failed to connect to ws://localhost:8080')
+    assert.strictEqual(err.cause, 'string cause')
+  })
+
   await it('should export executeCommand function', () => {
     assert.strictEqual(typeof executeCommand, 'function')
   })

ui/cli/tests/output.test.ts

@@ -9,32 +9,18 @@ import { printError } from '../src/output/human.js'
 import { outputJson, outputJsonError } from '../src/output/json.js'
 import { outputTable } from '../src/output/table.js'
 
-const captureStdout = (fn: () => void): string => {
+const captureStream = (stream: 'stderr' | 'stdout', fn: () => void): string => {
+  const target = stream === 'stdout' ? process.stdout : process.stderr
   const chunks: string[] = []
-  const original = process.stdout.write.bind(process.stdout)
-  process.stdout.write = ((chunk: string): boolean => {
+  const original = target.write.bind(target)
+  target.write = ((chunk: string): boolean => {
     chunks.push(chunk)
     return true
-  }) as typeof process.stdout.write
+  }) as typeof target.write
   try {
     fn()
   } finally {
-    process.stdout.write = original
-  }
-  return chunks.join('')
-}
-
-const captureStderr = (fn: () => void): string => {
-  const chunks: string[] = []
-  const original = process.stderr.write.bind(process.stderr)
-  process.stderr.write = ((chunk: string): boolean => {
-    chunks.push(chunk)
-    return true
-  }) as typeof process.stderr.write
-  try {
-    fn()
-  } finally {
-    process.stderr.write = original
+    target.write = original
   }
   return chunks.join('')
 }
@@ -57,7 +43,7 @@ await describe('output formatters', async () => {
       hashIdsSucceeded: ['cs-001', 'cs-002'],
       status: ResponseStatus.SUCCESS,
     }
-    const output = captureStdout(() => {
+    const output = captureStream('stdout', () => {
       outputJson(payload)
     })
     const parsed = JSON.parse(output) as typeof payload
@@ -67,15 +53,15 @@ await describe('output formatters', async () => {
 
   await it('should write valid JSON to stdout for failure payload', () => {
     const payload = { status: ResponseStatus.FAILURE }
-    const output = captureStdout(() => {
+    const output = captureStream('stdout', () => {
       outputJson(payload)
     })
     const parsed = JSON.parse(output) as typeof payload
     assert.strictEqual(parsed.status, ResponseStatus.FAILURE)
   })
 
   await it('should write error JSON to stdout', () => {
-    const output = captureStdout(() => {
+    const output = captureStream('stdout', () => {
       outputJsonError(new Error('test error'))
     })
     const parsed = JSON.parse(output) as { error: boolean; message: string; status: string }
@@ -85,7 +71,7 @@ await describe('output formatters', async () => {
   })
 
   await it('should handle non-Error objects in JSON error output', () => {
-    const output = captureStdout(() => {
+    const output = captureStream('stdout', () => {
       outputJsonError('string error')
     })
     const parsed = JSON.parse(output) as { message: string }
@@ -97,30 +83,30 @@ await describe('output formatters', async () => {
       hashIdsSucceeded: ['cs-001'],
       status: ResponseStatus.SUCCESS,
     }
-    const output = captureStdout(() => {
+    const output = captureStream('stdout', () => {
       outputTable(payload)
     })
     assert.ok(output.includes('cs-001'))
   })
 
   await it('should display generic payload when no hash IDs present', () => {
     const payload = { state: { version: '1.0' }, status: ResponseStatus.SUCCESS }
-    const output = captureStdout(() => {
+    const output = captureStream('stdout', () => {
       outputTable(payload)
     })
     assert.ok(output.includes('version'))
   })
 
   await it('should write generic success when no hash IDs in table mode', () => {
     const payload = { status: ResponseStatus.SUCCESS }
-    const output = captureStdout(() => {
+    const output = captureStream('stdout', () => {
       outputTable(payload)
     })
     assert.ok(output.includes('Success'))
   })
 
   await it('should write error message via printError', () => {
-    const output = captureStderr(() => {
+    const output = captureStream('stderr', () => {
       printError('oops')
     })
     assert.ok(output.includes('oops'))
@@ -132,7 +118,7 @@ await describe('output formatters', async () => {
       hashIdsSucceeded: ['cs-100'],
       status: ResponseStatus.SUCCESS,
     }
-    const output = captureStdout(() => {
+    const output = captureStream('stdout', () => {
       formatter.output(payload)
     })
     const parsed = JSON.parse(output) as typeof payload
@@ -145,15 +131,15 @@ await describe('output formatters', async () => {
       hashIdsSucceeded: ['cs-200'],
       status: ResponseStatus.SUCCESS,
     }
-    const output = captureStdout(() => {
+    const output = captureStream('stdout', () => {
       formatter.output(payload)
     })
     assert.ok(output.includes('cs-200'))
   })
 
   await it('should handle error with JSON formatter', () => {
     const formatter = createFormatter(true)
-    const output = captureStdout(() => {
+    const output = captureStream('stdout', () => {
       formatter.error(new Error('json err'))
     })
     const parsed = JSON.parse(output) as { message: string }
@@ -162,7 +148,7 @@ await describe('output formatters', async () => {
 
   await it('should handle error with table formatter', () => {
     const formatter = createFormatter(false)
-    const output = captureStderr(() => {
+    const output = captureStream('stderr', () => {
       formatter.error(new Error('table err'))
     })
     assert.ok(output.includes('table err'))
@@ -181,7 +167,7 @@ await describe('output formatters', async () => {
       ],
       status: ResponseStatus.FAILURE,
     }
-    const output = captureStderr(() => {
+    const output = captureStream('stderr', () => {
       outputTable(payload)
     })
     assert.ok(output.includes('Station not found'))
@@ -201,7 +187,7 @@ await describe('output formatters', async () => {
       ],
       status: ResponseStatus.FAILURE,
     }
-    const output = captureStderr(() => {
+    const output = captureStream('stderr', () => {
       outputTable(payload)
     })
     assert.ok(output.includes('Unknown error'))
@@ -221,7 +207,7 @@ await describe('output formatters', async () => {
       ],
       status: ResponseStatus.FAILURE,
     }
-    const output = captureStderr(() => {
+    const output = captureStream('stderr', () => {
       outputTable(payload)
     })
     assert.ok(output.includes('(unknown)'))
@@ -233,10 +219,17 @@ await describe('output formatters', async () => {
       hashIdsFailed: ['cs-001'],
       status: ResponseStatus.FAILURE,
     }
-    const output = captureStderr(() => {
+    const output = captureStream('stderr', () => {
       outputTable(payload)
     })
     assert.ok(output.includes('cs-001'))
     assert.ok(!output.includes('Error'))
   })
+
+  await it('should display generic failure status on stderr', () => {
+    const output = captureStream('stderr', () => {
+      outputTable({ status: ResponseStatus.FAILURE })
+    })
+    assert.ok(output.includes('failure'))
+  })
 })

ui/common/src/client/WebSocketClient.ts

@@ -170,20 +170,24 @@ export class WebSocketClient {
     if (
       responsePayload == null ||
       typeof responsePayload !== 'object' ||
-      !('status' in responsePayload)
+      !('status' in responsePayload) ||
+      typeof (responsePayload as { status: unknown }).status !== 'string'
     ) {
-      clearTimeout(handler.timeoutId)
-      this.responseHandlers.delete(uuid)
+      this.settleHandler(uuid, handler)
       handler.reject(new Error('Server sent malformed response payload'))
       return
     }
-    clearTimeout(handler.timeoutId)
-    this.responseHandlers.delete(uuid)
+    this.settleHandler(uuid, handler)
     const payload = responsePayload as ResponsePayload
     if (payload.status === ResponseStatus.SUCCESS) {
       handler.resolve(payload)
     } else {
       handler.reject(new ServerFailureError(payload))
     }
   }
+
+  private settleHandler (uuid: UUIDv4, handler: ResponseHandler): void {
+    clearTimeout(handler.timeoutId)
+    this.responseHandlers.delete(uuid)
+  }
 }