Skip to content

Commit de7bc61

Browse files
tal-misagishm
authored andcommitted
#00000 - Platform alignments + mapped field.
1 parent e077647 commit de7bc61

File tree

7 files changed

+31
-55
lines changed

7 files changed

+31
-55
lines changed

CHANGELOG.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,10 @@ Inital release.
1010
Example & documentation.
1111

1212
* Example application updates.
13-
* Documentation updates.
13+
* Documentation updates.
14+
15+
# 0.0.3
16+
Platform alignments
17+
18+
* Fixed Android error not mapped correctly.
19+
* Added dynamic "mapped" field to base GigyaResponse.

android/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ dependencies {
4444
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
4545

4646
// Gigya SDK core implementation.
47-
//api 'com.github.SAP.gigya-android-sdk::core-v5.0.0'
4847
api 'com.github.SAP.gigya-android-sdk:gigya-android-sdk-core:core-v5.0.1'
4948
api 'com.google.code.gson:gson:2.8.6'
5049
}

android/src/main/kotlin/com/sap/gigya_flutter_plugin/GigyaSDKWrapper.kt

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class GigyaSDKWrapper<T : GigyaAccount>(application: Application, accountObj: Cl
6666

6767
override fun onError(p0: GigyaError?) {
6868
p0?.let {
69-
channelResult.error(p0.errorCode.toString(), p0.localizedMessage, p0.data)
69+
channelResult.error(p0.errorCode.toString(), p0.localizedMessage, mapJson(p0.data))
7070
} ?: channelResult.notImplemented()
7171
}
7272

@@ -103,7 +103,7 @@ class GigyaSDKWrapper<T : GigyaAccount>(application: Application, accountObj: Cl
103103

104104
override fun onError(p0: GigyaError?) {
105105
p0?.let {
106-
currentResult!!.error(p0.errorCode.toString(), p0.localizedMessage, p0.data)
106+
currentResult!!.error(p0.errorCode.toString(), p0.localizedMessage, mapJson(p0.data))
107107
} ?: currentResult!!.notImplemented()
108108
}
109109

@@ -150,7 +150,7 @@ class GigyaSDKWrapper<T : GigyaAccount>(application: Application, accountObj: Cl
150150

151151
override fun onError(p0: GigyaError?) {
152152
p0?.let {
153-
currentResult!!.error(p0.errorCode.toString(), p0.localizedMessage, p0.data)
153+
currentResult!!.error(p0.errorCode.toString(), p0.localizedMessage, mapJson(p0.data))
154154
} ?: currentResult!!.notImplemented()
155155
}
156156

@@ -193,7 +193,7 @@ class GigyaSDKWrapper<T : GigyaAccount>(application: Application, accountObj: Cl
193193

194194
override fun onError(p0: GigyaError?) {
195195
p0?.let {
196-
channelResult.error(p0.errorCode.toString(), p0.localizedMessage, p0.data)
196+
channelResult.error(p0.errorCode.toString(), p0.localizedMessage, mapJson(p0.data))
197197
} ?: channelResult.notImplemented()
198198
}
199199

@@ -217,7 +217,7 @@ class GigyaSDKWrapper<T : GigyaAccount>(application: Application, accountObj: Cl
217217

218218
override fun onError(p0: GigyaError?) {
219219
p0?.let {
220-
channelResult.error(p0.errorCode.toString(), p0.localizedMessage, p0.data)
220+
channelResult.error(p0.errorCode.toString(), p0.localizedMessage, mapJson(p0.data))
221221
} ?: channelResult.notImplemented()
222222
}
223223

@@ -235,7 +235,7 @@ class GigyaSDKWrapper<T : GigyaAccount>(application: Application, accountObj: Cl
235235

236236
override fun onError(p0: GigyaError?) {
237237
p0?.let {
238-
channelResult.error(p0.errorCode.toString(), p0.localizedMessage, p0.data)
238+
channelResult.error(p0.errorCode.toString(), p0.localizedMessage, mapJson(p0.data))
239239
} ?: channelResult.notImplemented()
240240
}
241241

@@ -263,7 +263,7 @@ class GigyaSDKWrapper<T : GigyaAccount>(application: Application, accountObj: Cl
263263

264264
override fun onError(p0: GigyaError?) {
265265
p0?.let {
266-
currentResult!!.error(p0.errorCode.toString(), p0.localizedMessage, p0.data)
266+
currentResult!!.error(p0.errorCode.toString(), p0.localizedMessage, mapJson(p0.data))
267267
} ?: currentResult!!.notImplemented()
268268
}
269269

@@ -306,7 +306,7 @@ class GigyaSDKWrapper<T : GigyaAccount>(application: Application, accountObj: Cl
306306

307307
override fun onError(p0: GigyaError?) {
308308
p0?.let {
309-
channelResult.error(p0.errorCode.toString(), p0.localizedMessage, p0.data)
309+
channelResult.error(p0.errorCode.toString(), p0.localizedMessage, mapJson(p0.data))
310310
} ?: channelResult.notImplemented()
311311
}
312312

@@ -336,7 +336,7 @@ class GigyaSDKWrapper<T : GigyaAccount>(application: Application, accountObj: Cl
336336

337337
override fun onError(p0: GigyaError?) {
338338
p0?.let {
339-
channelResult.error(p0.errorCode.toString(), p0.localizedMessage, p0.data)
339+
channelResult.error(p0.errorCode.toString(), p0.localizedMessage, mapJson(p0.data))
340340
} ?: channelResult.notImplemented()
341341
}
342342

@@ -520,6 +520,15 @@ class GigyaSDKWrapper<T : GigyaAccount>(application: Application, accountObj: Cl
520520
return gson.fromJson(jsonString, object : TypeToken<Map<String, Any>>() {}.type)
521521
}
522522

523+
/**
524+
* Map a JSON string to a Map<String, Any> object in order to pass on to
525+
* the method channel response.
526+
*/
527+
private fun mapJson(jsonString: String): Map<String, Any> {
528+
return gson.fromJson(jsonString, object : TypeToken<Map<String, Any>>() {}.type)
529+
530+
}
531+
523532
companion object {
524533

525534
const val GENERAL_ERROR = "700"

example/pubspec.lock

Lines changed: 1 addition & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -74,46 +74,13 @@ packages:
7474
description: flutter
7575
source: sdk
7676
version: "0.0.0"
77-
flutter_web_plugins:
78-
dependency: transitive
79-
description: flutter
80-
source: sdk
81-
version: "0.0.0"
8277
gigya_flutter_plugin:
8378
dependency: "direct main"
8479
description:
8580
path: ".."
8681
relative: true
8782
source: path
88-
version: "0.0.2"
89-
google_sign_in:
90-
dependency: "direct main"
91-
description:
92-
name: google_sign_in
93-
url: "https://pub.dartlang.org"
94-
source: hosted
95-
version: "4.5.6"
96-
google_sign_in_platform_interface:
97-
dependency: transitive
98-
description:
99-
name: google_sign_in_platform_interface
100-
url: "https://pub.dartlang.org"
101-
source: hosted
102-
version: "1.1.2"
103-
google_sign_in_web:
104-
dependency: transitive
105-
description:
106-
name: google_sign_in_web
107-
url: "https://pub.dartlang.org"
108-
source: hosted
109-
version: "0.9.2"
110-
js:
111-
dependency: transitive
112-
description:
113-
name: js
114-
url: "https://pub.dartlang.org"
115-
source: hosted
116-
version: "0.6.2"
83+
version: "0.0.3"
11784
matcher:
11885
dependency: transitive
11986
description:
@@ -135,13 +102,6 @@ packages:
135102
url: "https://pub.dartlang.org"
136103
source: hosted
137104
version: "1.8.0-nullsafety.1"
138-
quiver:
139-
dependency: transitive
140-
description:
141-
name: quiver
142-
url: "https://pub.dartlang.org"
143-
source: hosted
144-
version: "2.1.5"
145105
sky_engine:
146106
dependency: transitive
147107
description: flutter

example/pubspec.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ dependencies:
2323
# the parent directory to use the current plugin's version.
2424
path: ../
2525

26-
google_sign_in: ^4.5.6
2726
flutter_facebook_login: ^3.0.0
2827

2928
# The following adds the Cupertino Icons font to your application.

lib/models/gigya_models.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ class GigyaResponse {
1616
String statusReason;
1717
int apiVersion;
1818
String regToken;
19+
dynamic mapped;
1920

2021
Interruption getInterruption() {
2122
switch (errorCode) {
@@ -37,7 +38,8 @@ class GigyaResponse {
3738
errorDetails = json['errorDetails'],
3839
statusReason = json['statusReason'],
3940
apiVersion = json['apiVersion'],
40-
regToken = json['regToken'];
41+
regToken = json['regToken'],
42+
mapped = json;
4143

4244
Map<String, dynamic> toJson() {
4345
final Map<String, dynamic> data = {};
@@ -48,6 +50,7 @@ class GigyaResponse {
4850
data['statusReason'] = statusReason;
4951
data['apiVersion'] = apiVersion;
5052
data['regToken'] = regToken;
53+
data['mapped'] = mapped;
5154
return data;
5255
}
5356
}

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: gigya_flutter_plugin
22
description: SAP Gigya Flutter plugin
3-
version: 0.0.2
3+
version: 0.0.3
44
homepage: https://github.com/SAP/gigya-flutter-plugin
55

66
environment:

0 commit comments

Comments
 (0)