BUG FIX - controller crash when parametersFrom contains invalid data (#510)

---------

Co-authored-by: I501080 <[email protected]>

Author: I065450

api/v1/types.go

@@ -4,8 +4,7 @@ package v1
 type ParametersFromSource struct {
 	// The Secret key to select from.
 	// The value must be a JSON object.
-	// +optional
-	SecretKeyRef *SecretKeyReference `json:"secretKeyRef,omitempty"`
+	SecretKeyRef *SecretKeyReference `json:"secretKeyRef,required"`
 }
 
 // SecretKeyReference references a key of a Secret.

config/crd/bases/services.cloud.sap.com_servicebindings.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.16.1
+    controller-gen.kubebuilder.io/version: v0.17.2
   name: servicebindings.services.cloud.sap.com
 spec:
   group: services.cloud.sap.com
@@ -115,6 +115,8 @@ spec:
                       - key
                       - name
                       type: object
+                  required:
+                  - secretKeyRef
                   type: object
                 type: array
               secretKey:

config/crd/bases/services.cloud.sap.com_serviceinstances.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.16.1
+    controller-gen.kubebuilder.io/version: v0.17.2
   name: serviceinstances.services.cloud.sap.com
 spec:
   group: services.cloud.sap.com
@@ -122,6 +122,8 @@ spec:
                       - key
                       - name
                       type: object
+                  required:
+                  - secretKeyRef
                   type: object
                 type: array
               serviceOfferingName:

internal/utils/parameters.go

@@ -28,17 +28,19 @@ func BuildSMRequestParameters(namespace string, parameters *runtime.RawExtension
 			if err != nil {
 				return nil, nil, err
 			}
-			secretsSet[string(secret.UID)] = secret
-			for k, v := range fps {
-				// we don't want to add shared param because sm api does not support updating
-				// shared param with other params, for sharing we have different function.
-				if k == "shared" {
-					continue
+			if secret != nil {
+				secretsSet[string(secret.UID)] = secret
+				for k, v := range fps {
+					// we don't want to add shared param because sm api does not support updating
+					// shared param with other params, for sharing we have different function.
+					if k == "shared" {
+						continue
+					}
+					if _, ok := params[k]; ok {
+						return nil, nil, fmt.Errorf("conflict: duplicate entry for parameter %q", k)
+					}
+					params[k] = v
 				}
-				if _, ok := params[k]; ok {
-					return nil, nil, fmt.Errorf("conflict: duplicate entry for parameter %q", k)
-				}
-				params[k] = v
 			}
 		}
 	}