Dear maintainers of btp-service-operator.
That change above is IMHO wrong, and potentially dangerous.
Whoever reads the secret will now interpret booleans as string "true" resp "false".
That could lead to "false" being evaluated as boolean true, depending on the language used.
The previous implementation was correct. The SAP binding metadata spec knows only TEXT (= JSON string) and JSON (any other JSON type, such as object, array, bool, numeric, even null). Said differently: boolean values are valid JSON values, and should be flagged like this in the metadata.
Dear maintainers of btp-service-operator.
That change above is IMHO wrong, and potentially dangerous.
Whoever reads the secret will now interpret booleans as string
"true"resp"false".That could lead to
"false"being evaluated as booleantrue, depending on the language used.The previous implementation was correct. The SAP binding metadata spec knows only TEXT (= JSON string) and JSON (any other JSON type, such as object, array, bool, numeric, even null). Said differently: boolean values are valid JSON values, and should be flagged like this in the metadata.