Skip to content

Commit d43b17e

Browse files
mkemetermkemeter
committed
Fixing typo
1 parent 8b13445 commit d43b17e

8 files changed

Lines changed: 25 additions & 24 deletions

File tree

‎.gitignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,4 @@ src/main/resources/testcredentials.properties
1515
local/
1616
src/test/resources/testcredentials.properties
1717
/.vscode
18+
CLAUDE.md

‎src/main/java/org/sap/cytoscape/internal/exceptions/GraphInconsistencyException.java‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
package org.sap.cytoscape.internal.exceptions;
2+
3+
public class GraphInconsistencyException extends Exception{
4+
public GraphInconsistencyException(String message){
5+
super(message);
6+
}
7+
}

‎src/main/java/org/sap/cytoscape/internal/exceptions/GraphIncosistencyException.java‎

Lines changed: 0 additions & 7 deletions
This file was deleted.

‎src/main/java/org/sap/cytoscape/internal/hdb/HanaConnectionManager.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.sap.cytoscape.internal.hdb;
22

3-
import org.sap.cytoscape.internal.exceptions.GraphIncosistencyException;
3+
import org.sap.cytoscape.internal.exceptions.GraphInconsistencyException;
44
import org.sap.cytoscape.internal.exceptions.HanaConnectionManagerException;
55
import org.sap.cytoscape.internal.utils.IOUtils;
66

@@ -467,7 +467,7 @@ private void loadNetworkEdges(HanaGraphWorkspace graphWorkspace) throws SQLExcep
467467
* @param graphWorkspaceName Name of the workspace to be loaded
468468
* @return HanaGraphWorkspace Object
469469
*/
470-
public HanaGraphWorkspace loadGraphWorkspace(String schema, String graphWorkspaceName) throws SQLException, HanaConnectionManagerException, GraphIncosistencyException {
470+
public HanaGraphWorkspace loadGraphWorkspace(String schema, String graphWorkspaceName) throws SQLException, HanaConnectionManagerException, GraphInconsistencyException {
471471

472472
HanaGraphWorkspace graphWorkspace =
473473
new HanaGraphWorkspace(new HanaDbObject(schema, graphWorkspaceName));
@@ -490,7 +490,7 @@ public HanaGraphWorkspace loadGraphWorkspace(String schema, String graphWorkspac
490490
* @param graphWorkspace Schema and Name of the workspace to be loaded
491491
* @return HanaGraphWorkspace Object
492492
*/
493-
public HanaGraphWorkspace loadGraphWorkspace(HanaDbObject graphWorkspace) throws SQLException, HanaConnectionManagerException, GraphIncosistencyException {
493+
public HanaGraphWorkspace loadGraphWorkspace(HanaDbObject graphWorkspace) throws SQLException, HanaConnectionManagerException, GraphInconsistencyException {
494494
return loadGraphWorkspace(graphWorkspace.schema, graphWorkspace.name);
495495
}
496496

‎src/main/java/org/sap/cytoscape/internal/hdb/HanaGraphWorkspace.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package org.sap.cytoscape.internal.hdb;
22

33
import org.cytoscape.model.*;
4-
import org.sap.cytoscape.internal.exceptions.GraphIncosistencyException;
4+
import org.sap.cytoscape.internal.exceptions.GraphInconsistencyException;
55

66
import java.sql.Types;
77
import java.util.*;
@@ -163,10 +163,10 @@ public HanaGraphWorkspace(String schema, String workspaceName, String nodeTableN
163163
}
164164
}
165165

166-
public void inferNodesFromEdges() throws GraphIncosistencyException {
166+
public void inferNodesFromEdges() throws GraphInconsistencyException {
167167

168168
if(!this.isEdgeOnlyGraph) {
169-
throw new GraphIncosistencyException("Cannot infer nodes from edges for non edge-only graphs");
169+
throw new GraphInconsistencyException("Cannot infer nodes from edges for non edge-only graphs");
170170
}
171171

172172
this.nodeKeyColName = "NodeID";

‎src/main/java/org/sap/cytoscape/internal/tasks/CyLoadTask.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import org.cytoscape.model.*;
44
import org.cytoscape.work.*;
5-
import org.sap.cytoscape.internal.exceptions.GraphIncosistencyException;
5+
import org.sap.cytoscape.internal.exceptions.GraphInconsistencyException;
66
import org.sap.cytoscape.internal.hdb.*;
77
import org.sap.cytoscape.internal.utils.CyUtils;
88
import static org.sap.cytoscape.internal.utils.CyLogging.*;
@@ -119,7 +119,7 @@ public void run(TaskMonitor taskMonitor) throws Exception {
119119
for(HanaEdgeTableRow row: graphWorkspace.getEdgeTable()){
120120
try{
121121
CyUtils.addNewEdgeToNetwork(newNetwork, graphWorkspace, row, nodesByHanaKey);
122-
} catch (GraphIncosistencyException e) {
122+
} catch (GraphInconsistencyException e) {
123123
// ignore this edge
124124
taskMonitor.showMessage(TaskMonitor.Level.ERROR, e.toString());
125125
taskMonitor.showMessage(TaskMonitor.Level.ERROR,"Edge " + row.getKeyValue(String.class) + " will be omitted");

‎src/main/java/org/sap/cytoscape/internal/utils/CyUtils.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package org.sap.cytoscape.internal.utils;
22

33
import org.cytoscape.model.*;
4-
import org.sap.cytoscape.internal.exceptions.GraphIncosistencyException;
4+
import org.sap.cytoscape.internal.exceptions.GraphInconsistencyException;
55
import org.sap.cytoscape.internal.hdb.*;
66

77
import java.util.HashMap;
@@ -111,15 +111,15 @@ public static CyNode addNewNodeToNetwork(CyNetwork network, HanaGraphWorkspace g
111111
* @param nodesByHanaKey
112112
* @return
113113
*/
114-
public static CyEdge addNewEdgeToNetwork(CyNetwork network, HanaGraphWorkspace graphWorkspace, HanaEdgeTableRow row, HashMap<String, CyNode> nodesByHanaKey) throws GraphIncosistencyException {
114+
public static CyEdge addNewEdgeToNetwork(CyNetwork network, HanaGraphWorkspace graphWorkspace, HanaEdgeTableRow row, HashMap<String, CyNode> nodesByHanaKey) throws GraphInconsistencyException {
115115
CyNode sourceNode = nodesByHanaKey.get(row.getSourceValue(String.class));
116116
if (sourceNode == null) {
117117
err("Source node with id " + row.getSourceValue(String.class) + " is not existing.");
118-
throw new GraphIncosistencyException("Source node with id " + row.getSourceValue(String.class) + " is not existing.");
118+
throw new GraphInconsistencyException("Source node with id " + row.getSourceValue(String.class) + " is not existing.");
119119
}
120120
CyNode targetNode = nodesByHanaKey.get(row.getTargetValue(String.class));
121121
if (targetNode == null) {
122-
throw new GraphIncosistencyException("Target node with id " + row.getTargetValue(String.class) + " is not existing.");
122+
throw new GraphInconsistencyException("Target node with id " + row.getTargetValue(String.class) + " is not existing.");
123123
}
124124

125125
CyEdge newEdge = network.addEdge(sourceNode, targetNode, true);

‎src/test/java/HanaGraphWorkspaceTest.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import org.junit.Assert;
22
import org.junit.Test;
3-
import org.sap.cytoscape.internal.exceptions.GraphIncosistencyException;
3+
import org.sap.cytoscape.internal.exceptions.GraphInconsistencyException;
44
import org.sap.cytoscape.internal.hdb.*;
55

66
import java.sql.Types;
@@ -64,16 +64,16 @@ public void testIsMetadataComplete_complete() {
6464
// inferNodesFromEdges
6565
// -------------------------------------------------------------------------
6666

67-
@Test(expected = GraphIncosistencyException.class)
68-
public void testInferNodesFromEdges_throwsForNonEdgeOnlyGraph() throws GraphIncosistencyException {
67+
@Test(expected = GraphInconsistencyException.class)
68+
public void testInferNodesFromEdges_throwsForNonEdgeOnlyGraph() throws GraphInconsistencyException {
6969
HanaGraphWorkspace ws = new HanaGraphWorkspace(new HanaDbObject("SCHEMA", "WS"));
7070
// addNodeKeyCol sets isEdgeOnlyGraph = false
7171
ws.addNodeKeyCol(new HanaColumnInfo("SCHEMA", "NODE_T", "NODE_ID", Types.INTEGER, true));
7272
ws.inferNodesFromEdges();
7373
}
7474

7575
@Test
76-
public void testInferNodesFromEdges_deduplicates() throws GraphIncosistencyException {
76+
public void testInferNodesFromEdges_deduplicates() throws GraphInconsistencyException {
7777
HanaGraphWorkspace ws = new HanaGraphWorkspace(new HanaDbObject("SCHEMA", "WS"));
7878
ws.addEdgeKeyCol(new HanaColumnInfo("SCHEMA", "EDGE_T", "EDGE_ID", Types.INTEGER, true));
7979
ws.addEdgeSourceCol(new HanaColumnInfo("SCHEMA", "EDGE_T", "SRC", Types.NVARCHAR, false));
@@ -92,7 +92,7 @@ public void testInferNodesFromEdges_deduplicates() throws GraphIncosistencyExcep
9292
}
9393

9494
@Test
95-
public void testInferNodesFromEdges_singleEdge() throws GraphIncosistencyException {
95+
public void testInferNodesFromEdges_singleEdge() throws GraphInconsistencyException {
9696
HanaGraphWorkspace ws = new HanaGraphWorkspace(new HanaDbObject("SCHEMA", "WS"));
9797
ws.addEdgeKeyCol(new HanaColumnInfo("SCHEMA", "EDGE_T", "EDGE_ID", Types.INTEGER, true));
9898
ws.addEdgeSourceCol(new HanaColumnInfo("SCHEMA", "EDGE_T", "SRC", Types.NVARCHAR, false));

0 commit comments

Comments
 (0)