refactor: remove one feature flag and change default for another (#20010)

Removed feature flag: storeFrontLibCardParagraphTruncated
Feature flag with default 'true' : productConfiguratorDeltaRendering

Author: ChristophHi

Diff for: projects/core/src/features-config/feature-toggles/config/feature-toggles.ts

@@ -77,12 +77,6 @@ export interface FeatureTogglesInterface {
    */
   pdfInvoicesSortByInvoiceDate?: boolean;
 
-  /**
-   * In `CardComponent` it truncates the paragraph text
-   * (analogically to the existing truncating of the label).
-   */
-  storeFrontLibCardParagraphTruncated?: boolean;
-
   /**
    * When enabled, the batch API is used `ProductCarouselComponent` to load products. It increases the component's performance.
    *
@@ -997,12 +991,11 @@ export const defaultFeatureToggles: Required<FeatureTogglesInterface> = {
   searchBoxV2: false,
   trendingSearches: false,
   pdfInvoicesSortByInvoiceDate: true,
-  storeFrontLibCardParagraphTruncated: true,
   useProductCarouselBatchApi: false,
   productConfiguratorAttributeTypesV2: true,
   propagateErrorsToServer: false,
   ssrStrictErrorHandlingForHttpAndNgrx: false,
-  productConfiguratorDeltaRendering: false,
+  productConfiguratorDeltaRendering: true,
   a11yRequiredAsterisks: true,
   a11yQuantityOrderTabbing: true,
   a11yNavigationUiKeyboardControls: true,

Diff for: projects/storefrontapp/src/app/spartacus/spartacus-features.module.ts

@@ -299,7 +299,6 @@ if (environment.cpq) {
         searchBoxV2: false,
         trendingSearches: false,
         pdfInvoicesSortByInvoiceDate: true,
-        storeFrontLibCardParagraphTruncated: true,
         useProductCarouselBatchApi: true,
         productConfiguratorAttributeTypesV2: true,
         propagateErrorsToServer: true,

Diff for: projects/storefrontlib/shared/components/card/card.component.html

@@ -58,27 +58,19 @@
         >
           <div class="cx-card-paragraph-title">{{ item.title }}</div>
           <div *ngFor="let text of item.text">
-            <ng-container *cxFeature="'storeFrontLibCardParagraphTruncated'">
-              <ng-container
-                *ngTemplateOutlet="
-                  showText;
-                  context: {
-                    content: content,
-                    truncateText: truncateParagraphText,
-                    charactersLimit: charactersLimit,
-                    class: 'cx-card-paragraph-text',
-                    text: text,
-                  }
-                "
-              >
-              </ng-container
-            ></ng-container>
-            <div
-              *cxFeature="'!storeFrontLibCardParagraphTruncated'"
-              class="cx-card-paragraph-text"
+            <ng-container
+              *ngTemplateOutlet="
+                showText;
+                context: {
+                  content: content,
+                  truncateText: truncateParagraphText,
+                  charactersLimit: charactersLimit,
+                  class: 'cx-card-paragraph-text',
+                  text: text,
+                }
+              "
             >
-              {{ text }}
-            </div>
+            </ng-container>
           </div>
         </div>
         <ng-content select="[label_container_bottom]"></ng-content>

Diff for: projects/storefrontlib/shared/components/card/card.component.spec.ts

@@ -44,7 +44,7 @@ class MockCxTruncateTextPopoverComponent {
 function getTruncatedPopover(elem: DebugElement) {
   return elem.queryAll(By.css('cx-truncate-text-popover'));
 }
-let isActiveStoreFrontLibCardParagraphTruncated: boolean;
+
 @Directive({
   selector: '[cxFeature]',
   standalone: false,
@@ -56,10 +56,8 @@ class MockFeatureDirective {
   ) {}
 
   @Input() set cxFeature(feature: string) {
-    const featureDesiredAndPresent =
-      isActiveStoreFrontLibCardParagraphTruncated && !feature.startsWith('!');
-    const featureNotDesiredAndNotPresent =
-      !isActiveStoreFrontLibCardParagraphTruncated && feature.startsWith('!');
+    const featureDesiredAndPresent = !feature.startsWith('!');
+    const featureNotDesiredAndNotPresent = feature.startsWith('!');
     if (featureDesiredAndPresent || featureNotDesiredAndNotPresent) {
       this.viewContainer.createEmbeddedView(this.templateRef);
     } else {
@@ -98,7 +96,6 @@ describe('CardComponent', () => {
     spyOn(component.setDefaultCard, 'emit').and.callThrough();
     spyOn(component.sendCard, 'emit').and.callThrough();
     spyOn(component.editCard, 'emit').and.callThrough();
-    isActiveStoreFrontLibCardParagraphTruncated = false;
   });
 
   it('should create', () => {
@@ -225,13 +222,7 @@ describe('CardComponent', () => {
     checkParagraph(component, fixture, el);
   });
 
-  it('should render passed paragraph in case isActiveStoreFrontLibCardParagraphTruncated is active', () => {
-    isActiveStoreFrontLibCardParagraphTruncated = true;
-    checkParagraph(component, fixture, el);
-  });
-
   it('should render passed paragraph with text for truncated text popover for a long text', () => {
-    isActiveStoreFrontLibCardParagraphTruncated = true;
     const mockCard: Card = {
       paragraphs: [
         { title: 'paragraph1', text: ['text1'] },