Skip to content

Commit b441290

Browse files
chore: enable feature toggles for 2504 (CXSPA-9683) (#20099)
Co-authored-by: Pawel Fras <[email protected]>
1 parent da53a24 commit b441290

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

Diff for: core-libs/setup/ssr/optimized-engine/optimized-ssr-engine.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ describe('OptimizedSsrEngine', () => {
203203
renderKeyResolver: 'function getRequestUrl(req) {\\n' +
204204
' return (0, express_request_origin_1.getRequestOrigin)(req) + req.originalUrl;\\n' +
205205
'}',
206-
ssrFeatureToggles: { avoidCachingErrors: false }
206+
ssrFeatureToggles: { avoidCachingErrors: true }
207207
}
208208
}
209209
}",
@@ -1491,7 +1491,7 @@ describe('OptimizedSsrEngine', () => {
14911491
"shouldCacheRenderingResult": "({ options, entry }) => !(options.ssrFeatureToggles?.avoidCachingErrors === true &&
14921492
Boolean(entry.err))",
14931493
"ssrFeatureToggles": {
1494-
"avoidCachingErrors": false,
1494+
"avoidCachingErrors": true,
14951495
},
14961496
"timeout": 3000,
14971497
"ttl": undefined,

Diff for: core-libs/setup/ssr/optimized-engine/ssr-optimization-options.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,6 @@ export const defaultSsrOptimizationOptions: DefaultSsrOptimizationOptions = {
233233
),
234234
renderKeyResolver: getDefaultRenderKey,
235235
ssrFeatureToggles: {
236-
avoidCachingErrors: false,
236+
avoidCachingErrors: true,
237237
},
238238
};

Diff for: projects/core/src/features-config/feature-toggles/config/feature-toggles.ts

+17-17
Original file line numberDiff line numberDiff line change
@@ -1014,8 +1014,8 @@ export const defaultFeatureToggles: Required<FeatureTogglesInterface> = {
10141014
trendingSearches: false,
10151015
pdfInvoicesSortByInvoiceDate: true,
10161016
useProductCarouselBatchApi: true,
1017-
propagateErrorsToServer: false,
1018-
ssrStrictErrorHandlingForHttpAndNgrx: false,
1017+
propagateErrorsToServer: true,
1018+
ssrStrictErrorHandlingForHttpAndNgrx: true,
10191019
productConfiguratorDeltaRendering: true,
10201020
a11yRequiredAsterisks: true,
10211021
a11yQuantityOrderTabbing: true,
@@ -1025,7 +1025,7 @@ export const defaultFeatureToggles: Required<FeatureTogglesInterface> = {
10251025
a11yOrderConfirmationHeadingOrder: true,
10261026
a11yStarRating: true,
10271027
a11yViewChangeAssistiveMessage: true,
1028-
a11yPreventHorizontalScroll: false,
1028+
a11yPreventHorizontalScroll: true,
10291029
a11yReorderDialog: true,
10301030
a11yPopoverFocus: true,
10311031
a11yPopoverHighContrast: false,
@@ -1039,12 +1039,12 @@ export const defaultFeatureToggles: Required<FeatureTogglesInterface> = {
10391039
a11yMobileVisibleFocus: true,
10401040
a11yOrganizationsBanner: true,
10411041
a11yOrganizationListHeadingOrder: true,
1042-
a11yCartImportConfirmationMessage: false,
1042+
a11yCartImportConfirmationMessage: true,
10431043
a11yAnonymousConsentMessageInDialog: false,
10441044
a11yReplenishmentOrderFieldset: true,
10451045
a11yListOversizedFocus: true,
10461046
a11yStoreFinderOverflow: true,
1047-
a11yMobileFocusOnFirstNavigationItem: false,
1047+
a11yMobileFocusOnFirstNavigationItem: true,
10481048
a11yQuickOrderSearchListKeyboardNavigation: false,
10491049
a11yCartSummaryHeadingOrder: true,
10501050
a11ySearchBoxMobileFocus: true,
@@ -1056,7 +1056,7 @@ export const defaultFeatureToggles: Required<FeatureTogglesInterface> = {
10561056
a11yHideSelectBtnForSelectedAddrOrPayment: true,
10571057
a11ySelectLabelWithContextForSelectedAddrOrPayment: false,
10581058
a11yFocusableCarouselControls: true,
1059-
a11yUseTrapTabInsteadOfTrapInDialogs: false,
1059+
a11yUseTrapTabInsteadOfTrapInDialogs: true,
10601060
cmsGuardsServiceUseGuardsComposer: true,
10611061
cartQuickOrderRemoveListeningToFailEvent: true,
10621062
a11yKeyboardAccessibleZoom: false,
@@ -1075,8 +1075,8 @@ export const defaultFeatureToggles: Required<FeatureTogglesInterface> = {
10751075
a11yEmptyWishlistHeading: true,
10761076
a11yScreenReaderBloatFix: true,
10771077
a11yUseButtonsForBtnLinks: true,
1078-
a11yTabComponent: false,
1079-
a11yCarouselArrowKeysNavigation: false,
1078+
a11yTabComponent: true,
1079+
a11yCarouselArrowKeysNavigation: true,
10801080
a11yPickupOptionsTabs: false,
10811081
a11yNotificationsOnConsentChange: true,
10821082
a11yDisabledCouponAndQuickOrderActionButtonsInsteadOfRequiredFields: true,
@@ -1097,14 +1097,14 @@ export const defaultFeatureToggles: Required<FeatureTogglesInterface> = {
10971097
a11yRepeatedCancelOrderError: true,
10981098
a11yAddedToCartActiveDialog: true,
10991099
a11yNgSelectMobileReadout: true,
1100-
a11yDeliveryMethodFieldset: false,
1101-
a11yShowMoreReviewsBtnFocus: false,
1100+
a11yDeliveryMethodFieldset: true,
1101+
a11yShowMoreReviewsBtnFocus: true,
11021102
a11yQuickOrderAriaControls: true,
11031103
a11yRemoveStatusLoadedRole: true,
11041104
a11yDialogsHeading: true,
1105-
a11yDialogTriggerRefocus: false,
1106-
a11yAddToWishlistFocus: false,
1107-
a11ySearchBoxFocusOnEscape: false,
1105+
a11yDialogTriggerRefocus: true,
1106+
a11yAddToWishlistFocus: true,
1107+
a11ySearchBoxFocusOnEscape: true,
11081108
a11yUpdatingCartNoNarration: false,
11091109
a11yPasswordVisibliltyBtnValueOverflow: false,
11101110
a11yItemCounterFocus: false,
@@ -1139,10 +1139,10 @@ export const defaultFeatureToggles: Required<FeatureTogglesInterface> = {
11391139
a11yRegionAssociatedHeaders: false,
11401140
occCartNameAndDescriptionInHttpRequestBody: true,
11411141
cmsBottomHeaderSlotUsingFlexStyles: true,
1142-
useSiteThemeService: false,
1143-
enableConsecutiveCharactersPasswordRequirement: false,
1144-
enablePasswordsCannotMatchInPasswordUpdateForm: false,
1145-
allPageMetaResolversEnabledInCsr: false,
1142+
useSiteThemeService: true,
1143+
enableConsecutiveCharactersPasswordRequirement: true,
1144+
enablePasswordsCannotMatchInPasswordUpdateForm: true,
1145+
allPageMetaResolversEnabledInCsr: true,
11461146
a11yPdpGridArrangement: false,
11471147
a11yHamburgerMenuTrapFocus: false,
11481148
useExtendedMediaComponentConfiguration: false,

0 commit comments

Comments
 (0)