Skip to content

Centralize definitions of NaN and -5 #24

@cjbacchus

Description

@cjbacchus

It was mentioned in a couple of reviews that we should have some standard place where we defined the magic constants -5 and numeric_limits<float>::signaling_NaN().

We may also need to review the use of these values. The original intention in NOvA, which I think is not documented anywhere in SBN, is that a NaN value surviving to the final CAF indicates a bug in CAFMaker, where it has failed to initialize a field. Whereas a field that is somehow unfillable gets -5. Of course that magic number doesn't work for all variables, and we have some -999s etc as well.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions