Skip to content

Commit 9960dd5

Browse files
committed
Feedback after meeting
1 parent 7cea7f7 commit 9960dd5

File tree

1 file changed

+4
-49
lines changed

1 file changed

+4
-49
lines changed

Diff for: .github/workflows/phase_1_python.yml

+4-49
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ jobs:
147147
--author "$SBOM_AUTHOR" \
148148
--supplier "$SBOM_SUPPLIER" \
149149
--repository 'https://github.com/CISA-SBOM-Community/SBOM-Generation' \
150-
--lifecycle source \
150+
--lifecycle pre-build \
151151
--license 'Apache-2.0' \
152152
application-sbom-cyclonedx/application-sbom.cdx.json > /tmp/augmented_application-sbom.cdx.tmp
153153
@@ -170,7 +170,7 @@ jobs:
170170
--author "$SBOM_AUTHOR" \
171171
--supplier "$SBOM_SUPPLIER" \
172172
--repository 'https://github.com/CISA-SBOM-Community/SBOM-Generation' \
173-
--lifecycle source \
173+
--lifecycle pre-build \
174174
--license 'Apache-2.0' \
175175
container-sbom-spdx/container-sbom.spdx.json > /tmp/augmented_container-sbom.spdx.tmp
176176
@@ -193,7 +193,7 @@ jobs:
193193
--author "$SBOM_AUTHOR" \
194194
--supplier "$SBOM_SUPPLIER" \
195195
--repository 'https://github.com/CISA-SBOM-Community/SBOM-Generation' \
196-
--lifecycle source \
196+
--lifecycle pre-build \
197197
--license 'Apache-2.0' \
198198
application-sbom-spdx/application-sbom.spdx.json > /tmp/augmented_application-sbom.spdx.tmp
199199
@@ -250,53 +250,8 @@ jobs:
250250
name: enriched-sboms
251251
path: "/tmp/enriched_*.json"
252252

253-
254-
Consolidate:
255-
runs-on: ubuntu-latest
256-
needs: [Enrich]
257-
steps:
258-
- uses: actions/checkout@v4
259-
260-
- name: Download all workflow run artifacts
261-
uses: actions/download-artifact@v4
262-
263-
# TODO: Add SPDX
264-
265-
- name: Build top-level CDX SBOM
266-
run: |
267-
# Create destination folder
268-
#mkdir /tmp/output
269-
270-
# Define metadata for parent template
271-
#export TOP_LEVEL_UUID=$(uuidgen)
272-
#export APPLICATION_SBOM_SHA256=$(sha256sum enriched-sboms/enriched_application-sbom.cdx.json | awk {'print $1'})
273-
#export CONTAINER_SBOM_SHA256=$(sha256sum enriched-sboms/enriched_container-sbom.cdx.json | awk {'print $1'})
274-
#export CREATION_TIMESTAMP=$(date -u +"%Y-%m-%dT%H:%M:%S%z")
275-
#export CONTAINER_BOM_REF=$(jq -r '.metadata.component["bom-ref"]' enriched-sboms/enriched_container-sbom.cdx.json)
276-
#export APPLICATION_BOM_REF=$(jq -r '.metadata.component["bom-ref"]' enriched-sboms/enriched_application-sbom.cdx.json)
277-
278-
# We're using `envsubst` here to populate the metadata
279-
# template from environment variables
280-
#cat "phase_1/Python/sbom/top-level.cdx.json.tmpl" | jq | \
281-
# envsubst > top-level-sbom.cdx.json.tmp
282-
283-
# Set GITHUB_RUN_NUMBER as the version of the SBOM
284-
#jq '.version = (env.GITHUB_RUN_NUMBER | tonumber)' \
285-
# top-level-sbom.cdx.json.tmp \
286-
# > /tmp/output/top-level-sbom.cdx.json
287-
288-
# Copy in enriched SBOMs
289-
#cp enriched-sboms/enriched_*-sbom.cdx.json /tmp/output/
290-
291-
- name: Upload Top Level SBOMs
292-
uses: actions/upload-artifact@v4
293-
with:
294-
name: top-level-sboms
295-
path: /tmp/output/
296-
297-
298253
Validate:
299-
needs: Consolidate
254+
needs: Augment
300255
runs-on: ubuntu-latest
301256
steps:
302257
- uses: actions/checkout@v4

0 commit comments

Comments
 (0)