Slight code cleanup, visual adjustments

Author: SChakravorti21

app/src/main/AndroidManifest.xml

@@ -12,7 +12,7 @@
         android:icon="@mipmap/ic_launcher"
         android:roundIcon="@mipmap/ic_launcher_round"
         android:label="@string/app_name"
-        android:supportsRtl="false"
+        android:supportsRtl="true"
         android:theme="@style/AppTheme">
         <activity
             android:name=".ui.activities.LoginActivity"

app/src/main/java/com/sakaimobile/development/sakaiclient20/ui/activities/CreditsActivity.java

@@ -16,7 +16,6 @@ public class CreditsActivity extends AppCompatActivity {
     private static final String[] creditsList = {
             "Rutgers Sakai",
             "Icons8",
-            "Logomakr",
             "RxAndroid",
             "AndroidTreeView",
             "Retrofit",
@@ -26,14 +25,12 @@ public class CreditsActivity extends AppCompatActivity {
     private static final String[] creditsURLs = {
             "https://sakai.rutgers.edu/direct/describe",
             "https://icons8.com/",
-            "https://logomakr.com/",
             "https://github.com/ReactiveX/RxAndroid",
             "https://github.com/bmelnychuk/AndroidTreeView",
             "https://github.com/square/retrofit",
             "https://github.com/square/okhttp"
     };
 
-
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
@@ -44,21 +41,17 @@ protected void onCreate(Bundle savedInstanceState) {
         toolbar.setNavigationOnClickListener((v) -> onBackPressed());
 
         ListView creditsListView = findViewById(R.id.credits_list_view);
-        creditsListView.setOnItemClickListener(
-                ((parent, view, position, id) -> {
-                    String url = creditsURLs[position];
-                    openURL(url);
-                })
-        );
+        creditsListView.setOnItemClickListener((parent, view, position, id) -> {
+            String url = creditsURLs[position];
+            openURL(url);
+        });
 
         ArrayAdapter<String> adapter = new ArrayAdapter<>(this, R.layout.credits_item, R.id.creditNameTxt, creditsList);
         creditsListView.setAdapter(adapter);
-
     }
 
 
     private void openURL(String url) {
-
         Intent viewIntent = new Intent(Intent.ACTION_VIEW, Uri.parse(url));
         viewIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
         viewIntent.setPackage("com.android.chrome");

app/src/main/java/com/sakaimobile/development/sakaiclient20/ui/activities/LoadingActivity.kt

@@ -16,9 +16,6 @@ import kotlinx.android.synthetic.main.activity_loading.*
 import javax.inject.Inject
 import android.view.animation.DecelerateInterpolator
 import android.animation.ObjectAnimator
-import android.graphics.BitmapFactory
-import android.support.v4.graphics.drawable.RoundedBitmapDrawable
-import android.support.v4.graphics.drawable.RoundedBitmapDrawableFactory
 import android.widget.Toast
 
 
@@ -47,7 +44,7 @@ class LoadingActivity : AppCompatActivity() {
         // Just in case network connectivity changes as refresh is occurring,
         // make sure the user is notified of this.
         loadingPageViewModel.errorState.observe(this, Observer {
-            Toast.makeText(this, "We had trouble reaching Sakai!", Toast.LENGTH_SHORT).show()
+            Toast.makeText(this, "We had trouble reaching Sakai, please restart this application", Toast.LENGTH_LONG).show()
         })
 
         loadingPageViewModel.getRefreshProgress(true).observe(this, Observer { progress ->

app/src/main/res/drawable/rounded_progress_bar.xml

@@ -10,7 +10,8 @@
         <scale android:scaleWidth="100%">
             <shape>
                 <corners android:radius="4dp"/>
-                <solid android:color="@color/sakaiTint"/>
+                <!--This is a non-standard color to match the red in the app icon-->
+                <solid android:color="#c62828"/>
             </shape>
         </scale>
     </item>

app/src/main/res/values/colors.xml

@@ -1,8 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
-    <color name="colorPrimary">#d34646</color>
-    <color name="colorPrimaryDark">#8F1717</color>
-    <color name="colorAccent">#8F1717</color>
+    <!--<color name="colorPrimary">#d34646</color>-->
+    <!--<color name="colorPrimaryDark">#8F1717</color>-->
+    <color name="colorPrimary">#333333</color>
+    <color name="colorPrimaryDark">@color/sakaiTint</color>
+    <color name="colorAccent">@color/sakaiTint</color>
     <color name="white">#FFFFFF</color>
 
     <!-- Course Header colors -->

app/src/main/res/values/styles.xml

@@ -65,12 +65,10 @@
 
     <style name="PreferencesTheme" parent="@style/PreferenceThemeOverlay">
         <item name="android:textColor">@color/secondaryTextColor</item>
+        <!-- Color for summaries (eg. version text) -->
         <item name="android:textColorSecondary">@color/secondaryTextColor</item>
         <!-- White color for category headings -->
         <item name="colorAccent">@color/primaryTextColor</item>
-        <item name="colorPrimary">@color/primaryTextColor</item>
-        <item name="colorPrimaryDark">@color/primaryTextColor</item>
-        <item name="colorSecondary">@color/primaryTextColor</item>
     </style>
 
 </resources>

app/src/main/res/xml/preferences.xml

@@ -7,14 +7,12 @@
             android:key="version"
             android:title="About">
             <intent android:action="android.intent.action.VIEW"
-                android:targetPackage="com.android.chrome"
                 android:data="https://rutgerssakai.github.io/SakaiMobile/"/>
         </Preference>
         <Preference
             android:icon="@drawable/ic_security"
             android:title="Privacy Policy">
             <intent android:action="android.intent.action.VIEW"
-                android:targetPackage="com.android.chrome"
                 android:data="https://rutgerssakai.github.io/SakaiMobile/privacy.html"/>
         </Preference>
         <Preference
@@ -39,7 +37,6 @@
             android:icon="@drawable/ic_star"
             android:title="Rate Rutgers Sakai Mobile">
             <intent android:action="android.intent.action.VIEW"
-                android:targetPackage="com.android.chrome"
                 android:data="https://play.google.com/store/apps/details?id=com.sakaimobile.development.sakaiclient20"/>
         </Preference>
     </PreferenceCategory>
@@ -48,19 +45,16 @@
         <Preference
             android:title="How does Sakai Mobile keep me logged in?">
             <intent android:action="android.intent.action.VIEW"
-                android:targetPackage="com.android.chrome"
                 android:data="https://rutgerssakai.github.io/SakaiMobile/faq.html#android-how-does-smart-lock-work"/>
         </Preference>
         <Preference
             android:title="I previously disabled auto-login and want to re-enable it">
             <intent android:action="android.intent.action.VIEW"
-                android:targetPackage="com.android.chrome"
                 android:data="https://rutgerssakai.github.io/SakaiMobile/faq.html#android-how-enable-smart-lock"/>
         </Preference>
         <Preference
             android:title="I want Sakai Mobile to forget my credentials">
             <intent android:action="android.intent.action.VIEW"
-                android:targetPackage="com.android.chrome"
                 android:data="https://rutgerssakai.github.io/SakaiMobile/faq.html#android-how-to-delete-credentials"/>
         </Preference>
     </PreferenceCategory>