Skip to content

Mingw uses wrong RC scanner for RES builder #2921

Open
@bdbaddog

Description

@bdbaddog

This issue was originally created at: 2013-10-24 08:52:14.
This issue was reported by: bmearns.
bmearns said at 2013-10-24 08:52:14

The RES builder that gets populated by the 'mingw' tool uses SourceFileScanner to scan for dependencies, but it should use SCons.Scanner.RC.RCScan for the scanner, like the builder populated by the 'msvc' tool does. By using the wrong scanner, it fails to capture dependencies for things like ICON and BITMAP external resource, which the RCScan does.

The fix should be very simple: on line 125 of Tools/minw.py, simply change "SCons.Tool.SourceFileScanner" to "SCons.Scanner.RC.RCScan()". I've tested that it works at least, but I'm not sure if there are other side effects that need to be tested.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions