fix: 코스 좋아요 토글 응답 단순화

Author: pooreumjung

src/main/java/com/semosan/api/domain/mountain/dto/response/CourseLikeToggleResponse.java

@@ -1,7 +1,6 @@
 package com.semosan.api.domain.mountain.dto.response;
 
 public record CourseLikeToggleResponse(
-        boolean liked,
-        long count
+        boolean liked
 ) {
 }

src/main/java/com/semosan/api/domain/mountain/repository/CourseLikeRepository.java

@@ -14,8 +14,6 @@ public interface CourseLikeRepository extends JpaRepository<CourseLike, Long> {
 
     Optional<CourseLike> findByUser_IdAndCourse_Id(Long userId, Long courseId);
 
-    long countByCourse_Id(Long courseId);
-
     @Modifying(clearAutomatically = true)
     @Query("DELETE FROM CourseLike cl WHERE cl.user.id = :userId")
     void deleteByUser_Id(@Param("userId") Long userId);

src/main/java/com/semosan/api/domain/mountain/service/CourseLikeService.java

@@ -27,8 +27,7 @@ public class CourseLikeService {
     @Transactional(noRollbackFor = DataIntegrityViolationException.class)
     public CourseLikeToggleResponse toggleCourseLike(Long userId, Long courseId) {
         boolean liked = toggle(userId, courseId);
-        long count = courseLikeRepository.countByCourse_Id(courseId);
-        return new CourseLikeToggleResponse(liked, count);
+        return new CourseLikeToggleResponse(liked);
     }
 
     private boolean toggle(Long userId, Long courseId) {

src/main/java/com/semosan/api/domain/mountain/service/CourseService.java

@@ -6,7 +6,6 @@
 import com.semosan.api.domain.mountain.repository.CourseLikeRepository;
 import com.semosan.api.domain.mountain.repository.CourseRepository;
 import com.semosan.api.domain.mountain.repository.projection.CourseDetailProjection;
-import com.semosan.api.domain.user.service.UserReader;
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
@@ -18,13 +17,11 @@ public class CourseService {
 
     private final CourseRepository courseRepository;
     private final CourseLikeRepository courseLikeRepository;
-    private final UserReader userReader;
 
     public CourseDetailResponse getCourseDetail(Long userId, Long courseId) {
-        userReader.findCompletedOnboardingUserById(userId);
         CourseDetailProjection course = courseRepository.findCourseDetailById(courseId)
                 .orElseThrow(() -> new GeneralException(ErrorStatus.COURSE_NOT_FOUND));
-        boolean likedByMe = courseLikeRepository.existsByUser_IdAndCourse_Id(userId, courseId);
+        boolean likedByMe = userId != null && courseLikeRepository.existsByUser_IdAndCourse_Id(userId, courseId);
         return CourseDetailResponse.from(course, likedByMe);
     }
 }

src/test/java/com/semosan/api/domain/mountain/service/CourseLikeServiceTest.java

@@ -47,12 +47,10 @@ void toggleCourseLikeCreatesLikeWhenNotLiked() throws Exception {
         when(userReader.findCompletedOnboardingUserById(1L)).thenReturn(user);
         when(courseRepository.findById(10L)).thenReturn(Optional.of(course));
         when(courseLikeRepository.findByUser_IdAndCourse_Id(1L, 10L)).thenReturn(Optional.empty());
-        when(courseLikeRepository.countByCourse_Id(10L)).thenReturn(1L);
 
         CourseLikeToggleResponse response = courseLikeService.toggleCourseLike(1L, 10L);
 
         assertThat(response.liked()).isTrue();
-        assertThat(response.count()).isEqualTo(1L);
         verify(courseLikeRepository).save(any(CourseLike.class));
     }
 
@@ -65,12 +63,10 @@ void toggleCourseLikeDeletesLikeWhenAlreadyLiked() throws Exception {
         when(userReader.findCompletedOnboardingUserById(1L)).thenReturn(user);
         when(courseRepository.findById(10L)).thenReturn(Optional.of(course));
         when(courseLikeRepository.findByUser_IdAndCourse_Id(1L, 10L)).thenReturn(Optional.of(courseLike));
-        when(courseLikeRepository.countByCourse_Id(10L)).thenReturn(0L);
 
         CourseLikeToggleResponse response = courseLikeService.toggleCourseLike(1L, 10L);
 
         assertThat(response.liked()).isFalse();
-        assertThat(response.count()).isZero();
         verify(courseLikeRepository).delete(courseLike);
     }
 
@@ -83,12 +79,10 @@ void toggleCourseLikeReturnsLikedWhenConcurrentDuplicateDetected() throws Except
         when(courseRepository.findById(10L)).thenReturn(Optional.of(course));
         when(courseLikeRepository.findByUser_IdAndCourse_Id(1L, 10L)).thenReturn(Optional.empty());
         when(courseLikeRepository.save(any(CourseLike.class))).thenThrow(new DataIntegrityViolationException("duplicate"));
-        when(courseLikeRepository.countByCourse_Id(10L)).thenReturn(1L);
 
         CourseLikeToggleResponse response = courseLikeService.toggleCourseLike(1L, 10L);
 
         assertThat(response.liked()).isTrue();
-        assertThat(response.count()).isEqualTo(1L);
     }
 
     private User user(Long id) {

src/test/java/com/semosan/api/domain/mountain/service/CourseServiceTest.java

@@ -6,15 +6,11 @@
 import com.semosan.api.domain.mountain.repository.CourseLikeRepository;
 import com.semosan.api.domain.mountain.repository.CourseRepository;
 import com.semosan.api.domain.mountain.repository.projection.CourseDetailProjection;
-import com.semosan.api.domain.user.entity.User;
-import com.semosan.api.domain.user.enums.user.DeviceType;
-import com.semosan.api.domain.user.service.UserReader;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
-import org.springframework.test.util.ReflectionTestUtils;
 
 import java.util.Optional;
 
@@ -31,9 +27,6 @@ class CourseServiceTest {
     @Mock
     private CourseLikeRepository courseLikeRepository;
 
-    @Mock
-    private UserReader userReader;
-
     @Mock
     private CourseDetailProjection projection;
 
@@ -42,7 +35,6 @@ class CourseServiceTest {
 
     @Test
     void getCourseDetailIncludesLikedByMe() {
-        when(userReader.findCompletedOnboardingUserById(1L)).thenReturn(user(1L));
         when(courseRepository.findCourseDetailById(10L)).thenReturn(Optional.of(projection));
         when(courseLikeRepository.existsByUser_IdAndCourse_Id(1L, 10L)).thenReturn(true);
         stubProjection();
@@ -56,7 +48,6 @@ void getCourseDetailIncludesLikedByMe() {
 
     @Test
     void getCourseDetailThrowsWhenCourseNotFound() {
-        when(userReader.findCompletedOnboardingUserById(1L)).thenReturn(user(1L));
         when(courseRepository.findCourseDetailById(10L)).thenReturn(Optional.empty());
 
         assertThatThrownBy(() -> courseService.getCourseDetail(1L, 10L))
@@ -80,9 +71,4 @@ private void stubProjection() {
         when(projection.getAltitudes()).thenReturn(null);
     }
 
-    private User user(Long id) {
-        User user = User.createTestUser("user-" + id, DeviceType.IOS);
-        ReflectionTestUtils.setField(user, "id", id);
-        return user;
-    }
 }