Skip to content

Commit 98ead33

Browse files
committed
fix: 난이도 피드백 코스 필수 예외 통일
1 parent ac62631 commit 98ead33

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

src/main/java/com/semosan/api/domain/hiking/entity/CourseDifficultyFeedback.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package com.semosan.api.domain.hiking.entity;
22

33
import com.semosan.api.common.base.BaseEntity;
4+
import com.semosan.api.common.exception.GeneralException;
5+
import com.semosan.api.common.status.ErrorStatus;
46
import com.semosan.api.domain.hiking.enums.DifficultyFeedbackType;
57
import com.semosan.api.domain.mountain.entity.Course;
68
import com.semosan.api.domain.mountain.enums.Difficulty;
@@ -59,7 +61,7 @@ public static CourseDifficultyFeedback create(
5961
) {
6062
Course course = hikingRecord.getCourse();
6163
if (course == null) {
62-
throw new IllegalArgumentException("course is required");
64+
throw new GeneralException(ErrorStatus.HIKING_RECORD_COURSE_REQUIRED);
6365
}
6466
return CourseDifficultyFeedback.builder()
6567
.hikingRecord(hikingRecord)

src/test/java/com/semosan/api/domain/hiking/service/HikingRecordServiceTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,9 @@ void courseDifficultyFeedbackCreateThrowsWhenRecordHasNoCourse() throws Exceptio
202202
user(1L),
203203
DifficultyFeedbackType.SIMILAR
204204
))
205-
.isInstanceOf(IllegalArgumentException.class)
206-
.hasMessage("course is required");
205+
.isInstanceOf(GeneralException.class)
206+
.extracting("errorStatus")
207+
.isEqualTo(ErrorStatus.HIKING_RECORD_COURSE_REQUIRED);
207208
}
208209

209210
private DataIntegrityViolationException duplicateFeedbackDataIntegrityViolation() {

0 commit comments

Comments
 (0)