refactor: 탈퇴 피드백 삭제를 벌크 쿼리로 변경

Author: pooreumjung

src/main/java/com/semosan/api/domain/hiking/repository/CourseDifficultyFeedbackRepository.java

@@ -2,14 +2,21 @@
 
 import com.semosan.api.domain.hiking.entity.CourseDifficultyFeedback;
 import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.data.jpa.repository.Modifying;
+import org.springframework.data.jpa.repository.Query;
+import org.springframework.data.repository.query.Param;
 
 import java.util.List;
 
 public interface CourseDifficultyFeedbackRepository extends JpaRepository<CourseDifficultyFeedback, Long> {
 
     boolean existsByHikingRecord_Id(Long hikingRecordId);
 
-    void deleteByUser_Id(Long userId);
+    @Modifying(clearAutomatically = true)
+    @Query("DELETE FROM CourseDifficultyFeedback cdf WHERE cdf.user.id = :userId")
+    void deleteByUserId(@Param("userId") Long userId);
 
-    void deleteByHikingRecord_IdIn(List<Long> hikingRecordIds);
+    @Modifying(clearAutomatically = true)
+    @Query("DELETE FROM CourseDifficultyFeedback cdf WHERE cdf.hikingRecord.id IN :hikingRecordIds")
+    void deleteByHikingRecordIdIn(@Param("hikingRecordIds") List<Long> hikingRecordIds);
 }

src/main/java/com/semosan/api/domain/user/service/UserService.java

@@ -149,11 +149,11 @@ private void deleteUserChildRecords(Long userId) {
         mountainLikeRepository.deleteByUser_Id(userId);
         courseLikeRepository.deleteByUser_Id(userId);
         reviewRepository.deleteByUser_Id(userId);
-        courseDifficultyFeedbackRepository.deleteByUser_Id(userId);
+        courseDifficultyFeedbackRepository.deleteByUserId(userId);
         List<Long> recordIdsToDelete = hikingRecordRepository.findRecordIdsOnlyParticipatedByUser(userId);
         hikingMemberRepository.deleteByUser_Id(userId);
         if (!recordIdsToDelete.isEmpty()) {
-            courseDifficultyFeedbackRepository.deleteByHikingRecord_IdIn(recordIdsToDelete);
+            courseDifficultyFeedbackRepository.deleteByHikingRecordIdIn(recordIdsToDelete);
             hikingRecordRepository.deleteAllByIdInBatch(recordIdsToDelete);
         }
         notificationRepository.deleteAllByUserId(userId);

src/test/java/com/semosan/api/domain/user/service/UserServiceTest.java

@@ -179,10 +179,10 @@ void withdrawUserDeletesUserChildRecordsAndSoftDeletesUser() {
 
         verify(mountainLikeRepository).deleteByUser_Id(1L);
         verify(reviewRepository).deleteByUser_Id(1L);
-        verify(courseDifficultyFeedbackRepository).deleteByUser_Id(1L);
+        verify(courseDifficultyFeedbackRepository).deleteByUserId(1L);
         verify(hikingRecordRepository).findRecordIdsOnlyParticipatedByUser(1L);
         verify(hikingMemberRepository).deleteByUser_Id(1L);
-        verify(courseDifficultyFeedbackRepository).deleteByHikingRecord_IdIn(List.of(10L, 11L));
+        verify(courseDifficultyFeedbackRepository).deleteByHikingRecordIdIn(List.of(10L, 11L));
         verify(hikingRecordRepository).deleteAllByIdInBatch(List.of(10L, 11L));
         verify(notificationRepository).deleteAllByUserId(1L);
         verify(userOnboardingRepository).deleteByUser_Id(1L);
@@ -197,9 +197,9 @@ void withdrawUserDeletesUserChildRecordsAndSoftDeletesUser() {
         assertThat(user.getOnboardingStatus()).isEqualTo(OnboardingStatus.INCOMPLETE);
 
         InOrder deleteOrder = inOrder(courseDifficultyFeedbackRepository, hikingRecordRepository);
-        deleteOrder.verify(courseDifficultyFeedbackRepository).deleteByUser_Id(1L);
+        deleteOrder.verify(courseDifficultyFeedbackRepository).deleteByUserId(1L);
         deleteOrder.verify(hikingRecordRepository).findRecordIdsOnlyParticipatedByUser(1L);
-        deleteOrder.verify(courseDifficultyFeedbackRepository).deleteByHikingRecord_IdIn(List.of(10L, 11L));
+        deleteOrder.verify(courseDifficultyFeedbackRepository).deleteByHikingRecordIdIn(List.of(10L, 11L));
         deleteOrder.verify(hikingRecordRepository).deleteAllByIdInBatch(List.of(10L, 11L));
     }
 }