Skip to content

Handle invalid assets gracefully #974

Open
@zuntrax

Description

@zuntrax

As shown in #972, openage crashes when it encounters invalid sound files. In this case, a field in the header struct had the wrong size, but i can imagine a bunch of other fails like corrupted bistreams or broken graphics taking down the engine. We should be robust against all the nastyness that might be hidden inside the assets. Crashing during a game would be inacceptable, playing silence or rendering a red X would be nice. We should also have proper logging and a way to nicely test asset packs for broken files. Last but not least, we should fuzz our current implementation and have integration tests with corrupt assets in kevin.
Ideas, anybody?

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: assetsInvolved with assets (images, sounds, ...)bugBehaving differently as it should behaveciRelated to our continuous integration systems (kevin, github-actions, ...)improvementEnhancement of an existing component

    Type

    Projects

    Status

    📋 Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions