Skip to content

Out-of-range settings of angle_start and angle_end should result in WARN message #58

@chriseichmann

Description

@chriseichmann

For start_angle and end_angle, the documentation states

Start angle of scan in radians, if both start and end angle are equal, all angels are regarded. 0° is at the front of the scanner.

End angle of scan in radians, if both start and end angle are equal, all angels are regarded. 0° is at the front of the scanner.

For both angles set equal, the node behaves as documented. A hint towards the expected range of values should be added to the documentation. 0° is pointed to the front, which differs from the 0° printed on the nanoscan3. 225° is equal to 2,35619 rad.

If one value is out of range for the scanner, e.g. >2.4 for end_angle, the node stops publishing. This should result in a WARN message for the node.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions