FareClassEnumeration in principle is defined twice. Should be harmonised (and there is a typo in "secondClass "

[ue71603]

Summary of search parameters:

	Searching for the string: "secondClass", case sensitive
	Files: "C:\Users\ue71603\MG_Daten\github\OJP4", including subfolders
C:\Users\ue71603\MG_Daten\github\OJP4\examples\functions\trip\TR_05_response_with_occupation.xml
	(Ln 90, Char 27)                     <siri:FareClass>secondClass </siri:FareClass>
C:\Users\ue71603\MG_Daten\github\OJP4\siri\xsd\siri_model\siri_facilities.xsd
	(Ln 227, Char 28)       <xsd:enumeration value="secondClass"/>
C:\Users\ue71603\MG_Daten\github\OJP4\siri\xsd\siri_model\siri_journey_support.xsd
	(Ln 957, Char 28)       <xsd:enumeration value="secondClass ">

siri_facilities

	<xsd:simpleType name="FareClassFacilityEnumeration">
		<xsd:annotation>
			<xsd:documentation>Values for FareClass Facility: TPEG pti_table 23.</xsd:documentation>
		</xsd:annotation>
		<xsd:restriction base="xsd:NMTOKEN">
			<xsd:enumeration value="unknown"/>
			<xsd:enumeration value="pti23_0"/>
			<xsd:enumeration value="unknown"/>
			<xsd:enumeration value="pti23_6"/>
			<xsd:enumeration value="firstClass"/>
			<xsd:enumeration value="pti23_7"/>
			<xsd:enumeration value="secondClass"/>
			<xsd:enumeration value="pti23_8"/>
			<xsd:enumeration value="thirdClass"/>
			<xsd:enumeration value="pti23_9"/>
			<xsd:enumeration value="economyClass"/>
			<xsd:enumeration value="pti23_10"/>
			<xsd:enumeration value="businessClass"/>
		</xsd:restriction>
	</xsd:simpleType>

journey_support:

<xsd:simpleType name="FareClassEnumeration">
		<xsd:annotation>
			<xsd:documentation>Values for Fare Class Facility. (since SIRI 2.1)</xsd:documentation>
		</xsd:annotation>
		<xsd:restriction base="xsd:NMTOKEN">
			<xsd:enumeration value="unknown">
				<xsd:annotation>
					<xsd:documentation>pti23_0</xsd:documentation>
				</xsd:annotation>
			</xsd:enumeration>
			<xsd:enumeration value="firstClass">
				<xsd:annotation>
					<xsd:documentation>pti23_6</xsd:documentation>
				</xsd:annotation>
			</xsd:enumeration>
			<xsd:enumeration value="secondClass ">
				<xsd:annotation>
					<xsd:documentation>pti23_7</xsd:documentation>
				</xsd:annotation>
			</xsd:enumeration>
			<xsd:enumeration value="thirdClass">
				<xsd:annotation>
					<xsd:documentation>pti23_8</xsd:documentation>
				</xsd:annotation>
			</xsd:enumeration>
			<xsd:enumeration value="preferente"/>
			<xsd:enumeration value="premiumClass">
				<xsd:annotation>
					<xsd:documentation>pti23_6_1</xsd:documentation>
				</xsd:annotation>
			</xsd:enumeration>
			<xsd:enumeration value="businessClass">
				<xsd:annotation>
					<xsd:documentation>Business Class - pti23_10</xsd:documentation>
				</xsd:annotation>
			</xsd:enumeration>
			<xsd:enumeration value="standardClass">
				<xsd:annotation>
					<xsd:documentation>Standard class Add pti23_7</xsd:documentation>
				</xsd:annotation>
			</xsd:enumeration>
			<xsd:enumeration value="turista"/>
			<xsd:enumeration value="economyClass">
				<xsd:annotation>
					<xsd:documentation>pti23_9</xsd:documentation>
				</xsd:annotation>
			</xsd:enumeration>
			<xsd:enumeration value="any"/>
		</xsd:restriction>
	</xsd:simpleType>

And the typo (additional blank):

- 
- C:\Users\ue71603\MG_Daten\github\OJP4\siri\xsd\siri_model\siri_journey_support.xsd
- 	(Ln 957, Char 28)       <xsd:enumeration value="secondClass ">  <-- blank

[skinkie]

Vote up.

[haeckerbaer]

@ue71603 Can you confirm that the typo in 'secondClass' was corrected (from v2.2 onwards a corrected value is provided)?

Other than that I see the following differences:

• the journey_support definition is missing the pti values but lists them in the annotations.
• the facilities definition is missing the values 'preferente', 'premiumClass', 'standardClass', 'turista' and 'any'.

I would reference the journey_support definition in facilities and add the pti values to it (for backward compatibility). Is that what you had in mind? And also, is this change relevant for v2.3?

[ue71603]

• typo: I think it is corrected.
• pti values: We believe that we should get rid of those. having two values meaning the same thing is a very bad idea for enums. I certainly don't want to see them other places.
• Then I prefer to change the thing in 3.0 and then either use the pti only or the values
  So don't do anything for 2.3 would be my prefered solution.

[TuThoThai]

Agree with you @ue71603 on removing the pti values in enum for v3.0.