Skip to content

Commit a2d162b

Browse files
newt239claude
andcommitted
fix: PR #259 レビュー指摘事項を修正
- SQLでuser_profiles.student_numberをusers.student_numberに修正し不要なJOINを削除 - UserIdsのvalidateタグからuuidを削除(openapi_types.UUIDに適用不可のため) - sendToAdminのdefault: falseをスキーマに復活 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 7a4cdcf commit a2d162b

File tree

5 files changed

+102
-100
lines changed

5 files changed

+102
-100
lines changed

document/bundle.gen.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3228,7 +3228,7 @@ components:
32283228
type: string
32293229
format: uuid
32303230
x-oapi-codegen-extra-tags:
3231-
validate: 'omitempty,dive,uuid'
3231+
validate: 'omitempty,dive'
32323232
ja: 送信先ユーザーID
32333233
subject:
32343234
type: string
@@ -3242,6 +3242,7 @@ components:
32423242
ja: 本文
32433243
sendToAdmin:
32443244
type: boolean
3245+
default: false
32453246
x-oapi-codegen-extra-tags:
32463247
ja: 管理者用アドレスにも送信
32473248
ResPostMail:

document/schemas/req_post_mail.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ properties:
1616
type: string
1717
format: uuid
1818
x-oapi-codegen-extra-tags:
19-
validate: omitempty,dive,uuid
19+
validate: omitempty,dive
2020
ja: 送信先ユーザーID
2121
subject:
2222
type: string
@@ -30,5 +30,6 @@ properties:
3030
ja: 本文
3131
sendToAdmin:
3232
type: boolean
33+
default: false
3334
x-oapi-codegen-extra-tags:
3435
ja: 管理者用アドレスにも送信

pkg/api/models.gen.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/api/spec.gen.go

Lines changed: 96 additions & 96 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
SELECT BIN_TO_UUID(users.id) AS user_id, user_profiles.student_number FROM users LEFT JOIN user_profiles ON users.id = user_profiles.user_id WHERE BIN_TO_UUID(users.id) IN /*userIds*/('00000000-0000-0000-0000-000000000000');
1+
SELECT BIN_TO_UUID(users.id) AS user_id, users.student_number FROM users WHERE BIN_TO_UUID(users.id) IN /*userIds*/('00000000-0000-0000-0000-000000000000');

0 commit comments

Comments
 (0)