Fix registry layer redering when others layers changes in the render widget

Author: XavierCLL

core/registry.py

@@ -185,25 +185,12 @@ def setup_renderer(self, color=None):
         })
         self.renderer = QgsSingleSymbolRenderer(border_symbol)
 
-    def add_registry_layer_to_canvases(self):
-        """Add memory layer to all active view widget canvases."""
+    def update_registry_layer_in_canvases(self):
+        """Refresh render layers in all active canvases to update registry layer visibility."""
         from ThRasE.gui.main_dialog import ThRasEDialog
         for view_widget in ThRasEDialog.view_widgets:
             if view_widget.is_active:
-                layers = view_widget.render_widget.canvas.layers()
-                if self.memory_layer not in layers:
-                    # add as top layer
-                    view_widget.render_widget.canvas.setLayers([self.memory_layer] + layers)
-    
-    def remove_registry_layer_from_canvases(self):
-        """Remove memory layer from all view widget canvases."""
-        from ThRasE.gui.main_dialog import ThRasEDialog
-        for view_widget in ThRasEDialog.view_widgets:
-            if view_widget.is_active:
-                layers = view_widget.render_widget.canvas.layers()
-                if self.memory_layer in layers:
-                    layers.remove(self.memory_layer)
-                    view_widget.render_widget.canvas.setLayers(layers)
+                view_widget.render_widget.update_render_layers()
 
     def delete(self):
         self.clear()
@@ -213,7 +200,7 @@ def delete(self):
         # clear memory layer
         if self.memory_layer:
             self.memory_layer.dataProvider().truncate()
-            self.remove_registry_layer_from_canvases()
+            self.update_registry_layer_in_canvases()
 
     def clear(self):
         # hide all features by setting a filter that matches nothing
@@ -234,7 +221,7 @@ def show_all(self):
             return
 
         # ensure layer is in canvases
-        self.add_registry_layer_to_canvases()
+        self.update_registry_layer_in_canvases()
 
         # apply renderer
         self.memory_layer.setRenderer(self.renderer.clone())
@@ -345,7 +332,7 @@ def set_current_group(self, idx_group):
             return
 
         # ensure layer is in canvases
-        self.add_registry_layer_to_canvases()
+        self.update_registry_layer_in_canvases()
 
         # apply renderer for current group
         if self.memory_layer:

gui/render_widget.py

@@ -62,6 +62,7 @@ def set_crs(self, crs):
 
     def update_render_layers(self):
         with block_signals_to(self):
+            from ThRasE.core.editing import LayerToEdit
             # set the CRS of the canvas view
             if self.crs:
                 # use the crs of thematic layer to edit
@@ -77,8 +78,14 @@ def update_render_layers(self):
                 self.canvas.setLayers([])
                 self.refresh()
                 return
-            # set to canvas
-            self.canvas.setLayers(valid_layers)
+            # include registry memory layer if active
+            if LayerToEdit.current and LayerToEdit.current.registry.memory_layer:
+                memory_layer = LayerToEdit.current.registry.memory_layer
+                # add registry layer on top of other layers
+                self.canvas.setLayers([memory_layer] + valid_layers)
+            else:
+                # set to canvas without registry layer
+                self.canvas.setLayers(valid_layers)
             # set init extent from other view if any is activated else set layer extent
             from ThRasE.gui.main_dialog import ThRasEDialog
             others_extents = [view_widget.render_widget.canvas.extent() for view_widget in ThRasEDialog.view_widgets