Skipping pubNumber validation for OM_PUBTYPE (#326)

fschleich · web-flow · commit 8ef92b6f8479 · 2025-03-28T08:11:44.000-07:00
* skipping pubNumber validation for OM_PUBTYPE
* pubNumber validation tests
* Removed pubNumber for valid OM example
diff --git a/js/common.mjs b/js/common.mjs
@@ -184,8 +184,10 @@ export function validateHead(head, logger) {
     if(metadata.pubDateTime === null)
       fatal(logger, "pubDateTime must be present if the document is in pub state.");
 
-    if (metadata.pubNumber === null)
-      logger.error("pubNumber must be specified if the document is in pub state.");
+    if (metadata.pubNumber === null) {
+      if (metadata.pubType !== OM_PUBTYPE)
+        logger.error("pubNumber must be specified if the document is in pub state.");
+    }
   }
 
   /* specific to OM */
diff --git a/test/resources/html/validation/om-valid.html b/test/resources/html/validation/om-valid.html
@@ -7,7 +7,6 @@
     <script src="../../../../smpte.js"></script>
     <meta itemprop="test" content="valid" />
     <meta itemprop="pubType" content="OM" />
-    <meta itemprop="pubNumber" content="5" />
     <meta itemprop="pubState" content="draft" />
     <meta itemprop="effectiveDateTime" content="2015-04-04" />
     <title>OM</title>
diff --git a/test/resources/html/validation/pub-number-invalid.html b/test/resources/html/validation/pub-number-invalid.html
@@ -0,0 +1,23 @@
+<!doctype html>
+<html>
+  <head itemscope="itemscope" itemtype="http://smpte.org/standards/documents">
+    <meta charset="utf-8" />
+    <meta http-equiv="x-ua-compatible" content="ie=edge" />
+    <meta name="viewport" content="width=device-width, initial-scale=1" />
+    <script type="module" src="../../../../smpte.js"></script>
+    <meta itemprop="test" content="invalid" />
+    <meta itemprop="pubType" content="ST" />
+    <meta itemprop="pubStage" content="PUB" />
+    <meta itemprop="pubDateTime" content="2010-09-04" />
+    <meta itemprop="effectiveDateTime" content="2010-09-04" />
+    <meta itemprop="pubState" content="pub" />
+    <meta itemprop="pubTC" content="35PM" />
+
+    <title>Title of the document</title>
+  </head>
+  <body>
+    <section id="sec-scope">
+      <p>This is the scope of the document.</p>
+    </section>
+  </body>
+</html>
diff --git a/test/resources/html/validation/pub-number-valid.html b/test/resources/html/validation/pub-number-valid.html
@@ -0,0 +1,23 @@
+<!doctype html>
+<html>
+  <head itemscope="itemscope" itemtype="http://smpte.org/standards/documents">
+    <meta charset="utf-8" />
+    <meta http-equiv="x-ua-compatible" content="ie=edge" />
+    <meta name="viewport" content="width=device-width, initial-scale=1" />
+    <script type="module" src="../../../../smpte.js"></script>
+    <meta itemprop="test" content="valid" />
+    <meta itemprop="pubType" content="OM" />
+    <meta itemprop="pubStage" content="PUB" />
+    <meta itemprop="pubDateTime" content="2010-09-04" />
+    <meta itemprop="effectiveDateTime" content="2010-09-04" />
+    <meta itemprop="pubState" content="pub" />
+    <meta itemprop="pubTC" content="ST" />
+
+    <title>Title of the document</title>
+  </head>
+  <body>
+    <section id="sec-scope">
+      <p>This is the scope of the document.</p>
+    </section>
+  </body>
+</html>
