-
Notifications
You must be signed in to change notification settings - Fork 1
Description
I'm assuming that on mac os users have write permission on /usr/local/bin. On linux this is not the case, so in order to install yq, you must run install-tooling.sh as root. However, then nvm is only installed for root, so I ended up having to run it twice while testing. Once with sudo for installing yq, and once without for nvm to go into the correct home dir.
Could put sudo on the line that writes to /usr/local/bin, but that would require the user can sudo. There's also some convention with a ~/.local/bin or just ~/bin but that would also involve updating the user's $PATH to make sure that dir is in there, which can also be a little inconsistent.
There's also a bit of an issue where the nvm installation happens regardless of if the user already had node installed some other way. If they've already got node installed through something like apt, yum or apk, it might be nice to skip over the whole nvm/node step and not mess with their existing node installation.