Fix many clang-tidy, clazy and cppcheck hints and warnings.

Signed-off-by: Volker Christian <me@vchrist.at>

Author: VolkerChristian

src/apps/express_compat_server.cpp

@@ -63,7 +63,7 @@ static void tracePush(const std::shared_ptr<express::Request>& req, const std::s
 static json traceGet(const std::shared_ptr<express::Request>& req) {
     json arr = json::array();
     req->getAttribute<Trace>(
-        [&](Trace& t) {
+        [&](const Trace& t) {
             for (auto const& e : t) {
                 arr.push_back(e);
             }

src/apps/jsonclient.cpp

@@ -68,7 +68,7 @@ int main(int argc, char* argv[]) {
             req->type("application/json");
             req->set("Connection", "close");
             req->send(
-                "{\"userId\":1,\"schnitzel\":\"good\",\"hungry\":false}",
+                R"({"userId":1,"schnitzel":"good","hungry":false})",
                 []([[maybe_unused]] const std::shared_ptr<Request>& req, const std::shared_ptr<Response>& res) {
                     VLOG(1) << "-- OnResponse";
                     VLOG(1) << "     Status:";

src/core/DynamicLoader.cpp

@@ -193,7 +193,7 @@ namespace core {
         return ret;
     }
 
-    int DynamicLoader::dlClose(Library& library) {
+    int DynamicLoader::dlClose(const Library& library) {
         int ret = 0;
 
         ret = realExecDlClose(library);

src/core/DynamicLoader.h

@@ -77,7 +77,7 @@ namespace core {
 
     private:
         static std::string canonicalizePath(const std::string& libFile);
-        static int dlClose(Library& library);
+        static int dlClose(const Library& library);
 
         static int realExecDlClose(const Library& library);
         static void execDlCloseDeleyed();

src/core/EventLoop.cpp

@@ -133,7 +133,7 @@ namespace core {
         return eventLoopState == State::INITIALIZED;
     }
 
-    TickStatus EventLoop::_tick(const utils::Timeval& tickTimeOut) {
+    TickStatus EventLoop::_tick(const utils::Timeval& timeOut) {
         TickStatus tickStatus = TickStatus::SUCCESS;
 
         tickCounter++;
@@ -148,7 +148,7 @@ namespace core {
         sigprocmask(SIG_BLOCK, &newSet, &oldSet);
 
         if (eventLoopState == State::RUNNING || eventLoopState == State::STOPPING) {
-            tickStatus = eventMultiplexer.tick(tickTimeOut, oldSet);
+            tickStatus = eventMultiplexer.tick(timeOut, oldSet);
         }
 
         sigprocmask(SIG_SETMASK, &oldSet, nullptr);

src/core/TimerEventPublisher.cpp

@@ -95,7 +95,7 @@ namespace core {
         timerList.insert(timer);
     }
 
-    bool TimerEventPublisher::empty() {
+    bool TimerEventPublisher::empty() const {
         return timerList.empty();
     }
 

src/core/TimerEventPublisher.h

@@ -71,7 +71,7 @@ namespace core {
         void erase(TimerEventReceiver* timer);
         void insert(TimerEventReceiver* timer);
 
-        bool empty();
+        bool empty() const;
 
         void stop();
 

src/core/multiplexer/poll/DescriptorEventPublisher.cpp

@@ -87,7 +87,7 @@ namespace core::multiplexer::poll {
     }
 
     void DescriptorEventPublisher::spanActiveEvents() {
-        pollfd* pollfds = pollFds.getEvents();
+        const pollfd* pollfds = pollFds.getEvents();
 
         const PollFdsManager::pollfdindex_map& pollFdsIndices = pollFds.getPollFdIndices();
 

src/core/pipe/Sink.cpp

@@ -56,13 +56,14 @@ namespace core::pipe {
     }
 
     void Sink::pipe(Source* source) {
-        if (source->isOpen())
+        if (source->isOpen()) {
             this->source = source;
+        }
 
         onSourceConnect(source);
     }
 
-    bool Sink::isStreaming() {
+    bool Sink::isStreaming() const {
         return source != nullptr;
     }
 

src/core/pipe/Sink.h

@@ -72,7 +72,7 @@ namespace core::pipe {
         void pipe(Source* source);
 
     protected:
-        bool isStreaming();
+        bool isStreaming() const;
         void stop();
 
     private: