fix: 코드리뷰 반영

Author: jisooooooooooo

src/common/hook/useOverlayModal.tsx

@@ -7,37 +7,59 @@ import Modal from '@/common/component/Modal/Modal';
 type Closeable = { onClose: () => void };
 type OpenOptions = { withWrapper?: boolean };
 
+const hasOnCloseProp = (props: unknown): props is { onClose: unknown } => {
+  return (
+    typeof props === 'object' && props !== null && 'onClose' in (props as Record<string, unknown>)
+  );
+};
+
+const isCloseable = (element: ReactNode): element is ReactElement<Closeable> => {
+  return (
+    React.isValidElement(element) &&
+    hasOnCloseProp(element.props) &&
+    typeof element.props.onClose === 'function'
+  );
+};
+
 export const useOverlayModal = () => {
-  const idsRef = useRef<string[]>([]);
+  const lastIdRef = useRef<string | null>(null);
 
   const openModal = (node: ReactNode, options: OpenOptions = {}) => {
     const { withWrapper = true } = options;
 
     const id = overlay.open(({ unmount }) => {
-      const handleClose = () => unmount();
-      const content = React.isValidElement(node)
-        ? React.cloneElement(node as ReactElement<Partial<Closeable>>, { onClose: handleClose })
-        : node;
+      const handleClose = () => {
+        unmount();
+        if (lastIdRef.current === id) {
+          lastIdRef.current = null;
+        }
+      };
+      const content = isCloseable(node) ? React.cloneElement(node, { onClose: handleClose }) : node;
       return withWrapper ? <Modal onClose={handleClose}>{content}</Modal> : <>{content}</>;
     });
 
-    idsRef.current.push(id);
-    return { id, close: () => overlay.unmount(id) };
+    lastIdRef.current = id;
+    return {
+      id,
+      close: () => {
+        overlay.unmount(id);
+        if (lastIdRef.current === id) {
+          lastIdRef.current = null;
+        }
+      },
+    };
   };
 
   const closeModal = () => {
-    const id = idsRef.current.pop();
-    if (id) {
-      overlay.unmount(id);
+    const id = lastIdRef.current;
+    if (!id) {
+      return;
     }
-  };
-
-  const closeAll = () => {
-    while (idsRef.current.length) {
-      const id = idsRef.current.pop()!;
-      overlay.unmount(id);
+    overlay.unmount(id);
+    if (lastIdRef.current === id) {
+      lastIdRef.current = null;
     }
   };
 
-  return { openModal, closeModal, closeAll };
+  return { openModal, closeModal };
 };