Skip to content

Commit 02fb0d2

Browse files
SQLAdrianclaude
andcommitted
fix(installer): guard SourceDir/OutputDir with #ifndef so CI can override
The .iss unconditionally redefined SourceDir and OutputDir, clobbering iscc's /D command-line overrides from the release workflow. CI publishes to 'publish/' (not 'publish/win-x64'), so the hardcoded path made iscc look in the wrong place and abort with 'Source file ... does not exist'. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent e9c6f4e commit 02fb0d2

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

installer/SQLTriage.iss

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,15 @@
1414
#define AppPublisher "Adrian Sullivan"
1515
#define AppURL "https://sqladrian.github.io/SQLTriage/"
1616
#define AppExeName "SQLTriage.exe"
17-
#define SourceDir "..\publish\win-x64"
18-
#define OutputDir "..\release"
17+
; SourceDir / OutputDir can be overridden from the command line (CI):
18+
; iscc.exe /DSourceDir=... /DOutputDir=... installer\SQLTriage.iss
19+
; Local default mirrors the publish path used by `dotnet publish ... -o publish\win-x64`.
20+
#ifndef SourceDir
21+
#define SourceDir "..\publish\win-x64"
22+
#endif
23+
#ifndef OutputDir
24+
#define OutputDir "..\release"
25+
#endif
1926

2027
; version.iss is auto-generated by the csproj BuildInstaller target before iscc runs.
2128
; It defines AppVersion and BuildNumber.

0 commit comments

Comments
 (0)