chore(biome): apply autofixes and clear lint warnings

Author: miccy

packages/common/src/Resources.ts

@@ -65,9 +65,8 @@ export interface Resources<
 }
 
 /** Error when trying to remove a consumer from a resource that doesn't exist. */
-export interface ResourceNotFoundError<
-  TResourceKey extends string = string,
-> extends Typed<"ResourceNotFoundError"> {
+export interface ResourceNotFoundError<TResourceKey extends string = string>
+  extends Typed<"ResourceNotFoundError"> {
   readonly resourceKey: TResourceKey;
 }
 

packages/common/src/Sqlite.ts

@@ -12,16 +12,16 @@ import { createRecord } from "./Object.js";
 import type { Result } from "./Result.js";
 import { ok } from "./Result.js";
 import type { Run, Task } from "./Task.js";
-import { testCreateRun, type TestDeps, testName } from "./Test.js";
+import { type TestDeps, testCreateRun, testName } from "./Test.js";
 import type { InferType, Name, Typed } from "./Type.js";
 import {
   array,
   Null,
   Number,
   object,
   record,
-  set,
   String,
+  set,
   Uint8Array,
   union,
 } from "./Type.js";
@@ -223,7 +223,7 @@ export const createSqlite =
         return result as SqliteExecResult<R>;
       },
 
-      transaction: ((callback: () => Result<unknown, unknown> | void) => {
+      transaction: ((callback: () => Result<unknown, unknown> | undefined) => {
         console.debug("begin");
         driver.exec(sql`begin;`);
 

packages/common/src/local-first/Db.ts

@@ -18,7 +18,6 @@ import type {
   RandomBytesDep,
 } from "../Crypto.js";
 import { getProperty, objectToEntries } from "../Object.js";
-import type { LeaderLockDep } from "../Task.js";
 import type { RandomDep } from "../Random.js";
 import { getOk, ok, type Result } from "../Result.js";
 import { spaced } from "../Schedule.js";
@@ -34,6 +33,7 @@ import {
   type SqliteValue,
   sql,
 } from "../Sqlite.js";
+import type { LeaderLockDep } from "../Task.js";
 import { type AsyncDisposableStack, repeat, type Task } from "../Task.js";
 import { type Millis, millisToDateIso, type TimeDep } from "../Time.js";
 import type { Name } from "../Type.js";

packages/common/src/local-first/Evolu.ts

@@ -20,7 +20,7 @@ import { isNonEmptySet } from "../Set.js";
 import { SqliteBoolean, sqliteBooleanToBoolean } from "../Sqlite.js";
 import type { ReadonlyStore } from "../Store.js";
 import { createStore } from "../Store.js";
-import { type createRun, type Task } from "../Task.js";
+import type { createRun, Task } from "../Task.js";
 import type { Id, TypeError } from "../Type.js";
 import {
   brand,

packages/common/src/local-first/Schema.ts

@@ -11,20 +11,20 @@ import {
   eqSqliteIndex,
   getSqliteSchema,
   type SafeSql,
-  sql,
   SqliteBoolean,
   type SqliteDep,
   type SqliteIndex,
   type SqliteQuery,
   type SqliteQueryOptions,
   type SqliteSchema,
-  SqliteValue,
+  type SqliteValue,
+  sql,
 } from "../Sqlite.js";
 import type { InferType } from "../Type.js";
 import {
   DateIso,
   type Id,
-  IdBytes,
+  type IdBytes,
   nullOr,
   object,
   type StandardSchemaV1,
@@ -35,7 +35,7 @@ import { OwnerId } from "./Owner.js";
 import type { Query, Row } from "./Query.js";
 import { serializeQuery } from "./Query.js";
 import type { CrdtMessage, DbChange } from "./Storage.js";
-import { TimestampBytes } from "./Timestamp.js";
+import type { TimestampBytes } from "./Timestamp.js";
 
 /** Any {@link StandardSchemaV1}. */
 export type AnyStandardSchemaV1 = StandardSchemaV1<any, any>;

packages/common/src/local-first/Storage.ts

@@ -15,7 +15,7 @@ import type { RandomDep } from "../Random.js";
 import type { Result } from "../Result.js";
 import { err, ok } from "../Result.js";
 import type { SqliteDep } from "../Sqlite.js";
-import { sql, SqliteValue } from "../Sqlite.js";
+import { SqliteValue, sql } from "../Sqlite.js";
 import type { Task } from "../Task.js";
 import { Millis } from "../Time.js";
 import type { InferType, Int64String, Typed, TypeError } from "../Type.js";
@@ -31,14 +31,19 @@ import {
   String,
 } from "../Type.js";
 import type { Awaitable } from "../Types.js";
-import type { Owner, OwnerError, OwnerIdBytes } from "./Owner.js";
-import { OwnerId, OwnerWriteKey } from "./Owner.js";
+import type {
+  Owner,
+  OwnerError,
+  OwnerId,
+  OwnerIdBytes,
+  OwnerWriteKey,
+} from "./Owner.js";
 import { systemColumnsWithId } from "./Schema.js";
 import {
   createTimestamp,
   orderTimestampBytes,
-  Timestamp,
-  TimestampBytes,
+  type Timestamp,
+  type TimestampBytes,
 } from "./Timestamp.js";
 
 export interface StorageConfig {
@@ -1490,14 +1495,19 @@ const fingerprintRanges =
     `);
 
     const fingerprintRanges = result.rows.map(
-      (row, i, arr): FingerprintRange => ({
-        type: RangeType.Fingerprint,
-        upperBound: i === arr.length - 1 ? upperBound : row.b!,
-        fingerprint: sqliteFingerprintToFingerprint([
-          row.h1,
-          row.h2,
-        ] as SqliteFingerprint),
-      }),
+      (row, i, arr): FingerprintRange => {
+        const nextUpperBound = i === arr.length - 1 ? upperBound : row.b;
+        assert(nextUpperBound, "Expected fingerprint upper bound.");
+
+        return {
+          type: RangeType.Fingerprint,
+          upperBound: nextUpperBound,
+          fingerprint: sqliteFingerprintToFingerprint([
+            row.h1,
+            row.h2,
+          ] as SqliteFingerprint),
+        };
+      },
     );
 
     return fingerprintRanges;

packages/common/test/Resources.test.ts

@@ -2,7 +2,7 @@ import { expect, test } from "vitest";
 import type { Brand } from "../src/Brand.js";
 import { createResources } from "../src/Resources.js";
 import { err } from "../src/Result.js";
-import { testCreateTime, type Duration } from "../src/Time.js";
+import { type Duration, testCreateTime } from "../src/Time.js";
 
 interface Resource extends Disposable {
   readonly id: ResourceKey;

packages/common/test/Sqlite.test.ts

@@ -3,21 +3,21 @@ import { lazyVoid } from "../src/Function.js";
 import { err, ok } from "../src/Result.js";
 import {
   booleanToSqliteBoolean,
+  type CreateSqliteDriver,
   createPreparedStatementsCache,
   createSqlite,
   eqSqliteIndex,
   eqSqliteValue,
   getSqliteSchema,
   getSqliteSnapshot,
+  type SafeSql,
+  type SqliteDriver,
+  type SqliteValue,
   sql,
   sqliteBooleanToBoolean,
   sqliteFalse,
   sqliteTrue,
   testCreateRunWithSqlite,
-  type CreateSqliteDriver,
-  type SafeSql,
-  type SqliteDriver,
-  type SqliteValue,
 } from "../src/Sqlite.js";
 import { sleep } from "../src/Task.js";
 import { testCreateRun } from "../src/Test.js";
@@ -374,7 +374,7 @@ describe("logExplainQueryPlan", () => {
     );
     expect(planEntry).toBeDefined();
     // Nested rows produce leading spaces
-    const planOutput = planEntry!.args.find(
+    const planOutput = planEntry?.args.find(
       (arg) => typeof arg === "string" && arg.includes("SCAN"),
     ) as string;
     expect(planOutput).toMatch(/^ {2}/m);

packages/common/test/_deps.ts

@@ -42,7 +42,8 @@ const sqliteDeps = {
   createSqliteDriver: testCreateSqliteDriver,
 } satisfies CreateSqliteDriverDep;
 
-type TestCreateSqliteDeps = CreateSqliteDriverDep & (() => CreateSqliteDriverDep);
+type TestCreateSqliteDeps = CreateSqliteDriverDep &
+  (() => CreateSqliteDriverDep);
 
 // Keep backward compatibility for both call styles:
 // - testCreateSqliteDeps()

packages/common/test/local-first/Evolu.test.ts

@@ -22,10 +22,10 @@ import {
 import { testQuery, testQuery2 } from "../../src/local-first/Query.js";
 import { createQueryBuilder } from "../../src/local-first/Schema.js";
 import {
-  initSharedWorker,
   type EvoluInput,
   type EvoluOutput,
   type EvoluTabOutput,
+  initSharedWorker,
   type SharedWorker,
   type SharedWorkerInput,
 } from "../../src/local-first/Shared.js";
@@ -50,17 +50,16 @@ import {
   createMessagePort,
   createSharedWorker,
   createWorker,
-  testWaitForWorkerMessage,
   testCreateMessageChannel,
   testCreateMessagePort,
   testCreateSharedWorker,
   testCreateWorker,
+  testWaitForWorkerMessage,
 } from "../../src/Worker.js";
 import { testCreateSqliteDeps } from "../_deps.js";
 import { testAppOwner } from "./_fixtures.js";
 
 const TodoId = id("Todo");
-type TodoId = typeof TodoId.Type;
 
 const Schema = {
   todo: {