Merge pull request #50 from SQLoot/sync/common-v8-2026-02-25

Sync PR: upstream/common-v8 & fixes 25-02-2026

Author: miccy

.ai/knowledge/06-todo-skip-audit-2026-02-25.md

@@ -0,0 +1,64 @@
+# TODO and Skipped Tests Audit (2026-02-25)
+
+## Current totals
+
+- `TODO` in `packages/*`: `43` (down from `56`)
+- `FIXME` in `packages/*`: `0`
+- skipped tests (`test.skip`, `it.skip`, `describe.skip`, `test.todo`, `it.todo`): `5` (down from `9`)
+
+## What changed in this pass
+
+- Unskipped and stabilized:
+  - `packages/common/test/Crypto.test.ts`
+  - `packages/common/test/Identicon.test.ts`
+- Cleaned low-risk TODO stubs:
+  - `packages/react-native/src/exports/bare-op-sqlite.ts`
+  - `packages/web/src/WebWorker.ts` (commented skeleton)
+- Removed storedBytes placeholders and added cumulative accounting:
+  - `packages/common/src/local-first/Sync.ts`
+  - `packages/common/src/local-first/Db.ts`
+  - shared helper: `packages/common/src/local-first/Storage.ts`
+- Added client-side quota checks in Sync receive path:
+  - `packages/common/src/local-first/Sync.ts`
+- Replaced global Sync mutex with per-owner mutexes:
+  - `packages/common/src/local-first/Sync.ts`
+- Removed stale heartbeat TODOs already covered by implemented failover logic:
+  - `packages/common/src/local-first/Db.ts`
+  - `packages/common/src/local-first/Shared.ts`
+- Removed unused `Db` client-storage stub (including obsolete collaborative quota TODO):
+  - `packages/common/src/local-first/Db.ts`
+- Removed stale Sync TODO stubs/comments and added baseline Sync tests:
+  - `packages/common/src/local-first/Sync.ts`
+  - `packages/common/test/local-first/Sync.test.ts`
+- Replaced transport `todo()` stub with task bridge and added transport lifecycle tests:
+  - `packages/common/src/local-first/Sync.ts`
+  - `packages/common/test/local-first/Sync.test.ts`
+- Removed stale/invalid TODO text from `Evolu` API docs:
+  - `packages/common/src/local-first/Evolu.ts`
+
+## Remaining skipped tests (intentional)
+
+1. `packages/common/test/Result.test.ts:321`
+2. `packages/common/test/Result.test.ts:1210`
+   - Performance-only comparisons, not correctness tests.
+
+3. `packages/common/test/local-first/Storage.test.ts:425`
+4. `packages/common/test/local-first/Storage.test.ts:456`
+   - Long-running stress tests (`1_000_000` scale / large collision experiment).
+
+5. `packages/common/test/Sqlite.test.ts:615`
+   - Performance benchmark (commented out), not correctness regression.
+
+## High-value TODO clusters for issue extraction
+
+### A) Sync transport inbound protocol handling
+
+- `packages/common/src/local-first/Sync.ts:282`
+  - `onMessage` currently logs and returns; protocol message application is still disabled.
+  - Transport lifecycle is now wired, but inbound relay sync processing is not yet active in this path.
+
+Recommended scope: **M** _(Medium — roughly 1–3 days of focused implementation work)_
+
+## Suggested execution order
+
+1. Sync transport inbound protocol handling (A).

.github/workflows/ci.yaml

@@ -2,7 +2,7 @@ name: CI
 
 on:
   pull_request:
-    branches: ["**"]
+    types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches: ["main"]
   merge_group:

.github/workflows/tree-shaking-compat.yaml

@@ -0,0 +1,46 @@
+name: Tree-Shaking Compat
+
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: "20 3 * * *"
+  push:
+    branches: ["main"]
+    paths:
+      - "packages/common/test/TreeShaking.test.ts"
+      - "packages/common/src/**"
+      - "package.json"
+      - "bun.lock"
+      - ".github/workflows/tree-shaking-compat.yaml"
+
+permissions:
+  contents: read
+
+concurrency:
+  group: tree-shaking-compat-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  tree-shaking-compat:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+
+      - name: Setup Node.js
+        uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
+        with:
+          node-version: 24
+
+      - name: Setup Bun
+        uses: oven-sh/setup-bun@4bc047ad259df6fc24a6c9b0f9a0cb08cf17fbe5 # v2.0.1
+        with:
+          bun-version: "1.3.9"
+
+      - name: Install dependencies
+        run: bun install
+
+      - name: Build @evolu/common
+        run: bunx turbo --filter @evolu/common build
+
+      - name: Run tree-shaking compatibility lane
+        run: bun run test:tree-shaking:compat

apps/relay/package.json

@@ -4,7 +4,7 @@
   "private": true,
   "type": "module",
   "scripts": {
-    "dev": "bun src/index.ts",
+    "dev": "bun --watch src/index.ts",
     "build": "rimraf dist && tsc",
     "start": "node dist/src/index.js",
     "clean": "rimraf .turbo node_modules dist data/evolu-relay.db"

apps/relay/src/index.ts

@@ -1,6 +1,7 @@
 import { mkdirSync } from "node:fs";
 import { createConsole, createConsoleFormatter } from "@evolu/common";
 import { createRelayDeps, createRunner, startRelay } from "@evolu/nodejs";
+import { startBunRelay } from "./startBunRelay.js";
 
 // Ensure the database is created in a predictable location for Docker.
 mkdirSync("data", { recursive: true });
@@ -18,8 +19,11 @@ const deps = { ...createRelayDeps(), console };
 await using run = createRunner(deps);
 await using stack = run.stack();
 
+const isBunRuntime = (globalThis as { readonly Bun?: unknown }).Bun != null;
+const startRelayTask = isBunRuntime ? startBunRelay : startRelay;
+
 await stack.use(
-  startRelay({
+  startRelayTask({
     port: 4000,
 
     // Note: Relay requires URL in format ws://host:port/<ownerId>