Align the implementation with what is done in Media3

Author: MGaetan89

pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/PillarboxCastPlayer.kt

@@ -202,7 +202,7 @@ class PillarboxCastPlayer internal constructor(
             TrackSelectionParameters.DEFAULT
         }
         val deviceVolume = castSession?.let {
-            (it.volume * MAX_VOLUME).roundToInt().coerceIn(VOLUME_RANGE)
+            (it.volume * MAX_VOLUME).roundToInt().coerceIn(RANGE_DEVICE_VOLUME)
         }
 
         return State.Builder()
@@ -317,14 +317,14 @@ class PillarboxCastPlayer internal constructor(
     }
 
     override fun handleSetVolume(volume: Float) = withRemoteClient {
-        setStreamVolume(volume.toDouble())
+        setStreamVolume(volume.coerceIn(RANGE_VOLUME).toDouble())
     }
 
     override fun handleSetDeviceVolume(
         @IntRange(from = 0) deviceVolume: Int,
         flags: @C.VolumeFlags Int,
     ) = withCastSession("handleSetDeviceVolume") {
-        volume = deviceVolume.coerceIn(VOLUME_RANGE) / MAX_VOLUME.toDouble()
+        volume = deviceVolume.coerceIn(RANGE_DEVICE_VOLUME) / MAX_VOLUME.toDouble()
     }
 
     override fun handleIncreaseDeviceVolume(flags: @C.VolumeFlags Int): ListenableFuture<*> {
@@ -661,7 +661,8 @@ class PillarboxCastPlayer internal constructor(
             .setMaxVolume(MAX_VOLUME)
             .build()
 
-        private val VOLUME_RANGE = 0..MAX_VOLUME
+        private val RANGE_DEVICE_VOLUME = 0..MAX_VOLUME
+        private val RANGE_VOLUME = 0f..1f
 
         private fun createTrackSelectionParametersFromSelectedTracks(tracks: Tracks): TrackSelectionParameters {
             return TrackSelectionParameters.DEFAULT.buildUpon().apply {

pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/extension/RemoteMediaClient.kt

@@ -104,7 +104,7 @@ internal fun RemoteMediaClient.getRepeatMode(): @Player.RepeatMode Int {
 }
 
 internal fun RemoteMediaClient.getVolume(): Double {
-    return mediaStatus?.streamVolume ?: 0.0
+    return mediaStatus?.streamVolume ?: 1.0
 }
 
 internal fun RemoteMediaClient.getTracks(): Tracks {

pillarbox-cast/src/test/java/ch/srgssr/pillarbox/cast/extension/RemoteMediaClientTest.kt

@@ -158,7 +158,7 @@ class RemoteMediaClientTest {
     @Test
     fun `getVolume returns 0 when mediaStatus is null`() {
         every { remoteMediaClient.mediaStatus } returns null
-        assertEquals(0.0, remoteMediaClient.getVolume())
+        assertEquals(1.0, remoteMediaClient.getVolume())
     }
 
     @Test

pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/utils/StringUtil.kt

@@ -92,6 +92,7 @@ object StringUtil {
     fun playerCommandsString(value: Player.Commands): String {
         return buildList {
             repeat(value.size()) {
+                @Suppress("deprecation")
                 val commandName = when (val command = value.get(it)) {
                     Player.COMMAND_INVALID -> "COMMAND_INVALID"
                     Player.COMMAND_PLAY_PAUSE -> "COMMAND_PLAY_PAUSE"