Skip to content

Commit ac41d21

Browse files
committed
[Starts #173466929] Fixes some user profile data that couldn't be updated
1 parent 55eb1d5 commit ac41d21

File tree

9 files changed

+18
-7
lines changed

9 files changed

+18
-7
lines changed

server/controllers/authController.js

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import UserHelper from '../helpers/userHelper';
44
import TokenHelper from '../helpers/tokenHelper';
55
import passwordHelper from '../helpers/passwordHelper';
66

7-
87
/**
98
* This class contains all methods
109
* required to handle all

server/controllers/userController.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ class UserController {
132132
firstname,
133133
username,
134134
gender,
135+
profileImage,
135136
birthDate,
136137
preferredLanguage,
137138
preferredCurrency,
@@ -146,6 +147,7 @@ class UserController {
146147
firstname,
147148
username,
148149
gender,
150+
profileImage,
149151
birthDate,
150152
preferredLanguage,
151153
preferredCurrency,
@@ -197,5 +199,4 @@ class UserController {
197199
}
198200
}
199201

200-
201202
export default UserController;

server/helpers/authHelper.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ class AuthHelper {
139139
try {
140140
const {
141141
id,
142-
displayName: username,
143142
provider: authType,
144143
name: { givenName: firstname, familyName: lastname },
145144
_json: { email },
@@ -150,7 +149,7 @@ class AuthHelper {
150149
firstname,
151150
lastname,
152151
email,
153-
username: username || firstname,
152+
username: firstname,
154153
role: 'Requester',
155154
authType,
156155
lineManager: null,

server/index.js

-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ app.use(bodyParser.urlencoded({ extended: true }));
2121
const port = process.env.PORT || 3000;
2222
const basePath = '/api/v1';
2323

24-
2524
app.use(cors());
2625
app.use(passport.initialize());
2726
app.use(passport.session());

server/schemas/accommodationSchema.js

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import Joi from '@hapi/joi';
22

3-
43
const accommodationSchema = Joi.object().keys({
54
name: Joi.string().required().trim(),
65
description: Joi.string().required().trim(),

server/schemas/userSchema.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@ const userSchema = Joi.object().keys({
55
firstname: Joi.string().alphanum().min(3).max(30),
66
username: Joi.string().alphanum().min(3).max(15),
77
gender: Joi.string().alphanum().min(3).max(30),
8-
birthDate: Joi.date(),
8+
birthDate: Joi.string(),
99
preferredLanguage: Joi.string().alphanum().min(3).max(15),
1010
preferredCurrency: Joi.string().alphanum().min(3).max(30),
1111
location: Joi.string().min(3).max(30),
1212
department: Joi.string(),
13+
profileImage: Joi.string(),
1314
emailNotifications: Joi.boolean(),
1415
inAppNotifications: Joi.boolean()
1516
});

server/sequelize/migrations/20200325105904-create-user.js

+3
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ module.exports = {
2020
facebookId: {
2121
type: Sequelize.STRING,
2222
},
23+
profileImage: {
24+
type: Sequelize.STRING,
25+
},
2326
username: {
2427
allowNull: false,
2528
type: Sequelize.STRING

server/sequelize/models/user.js

+1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ export default (sequelize, DataTypes) => {
2121
inAppNotifications: DataTypes.BOOLEAN,
2222
googleId: DataTypes.STRING,
2323
facebookId: DataTypes.STRING,
24+
profileImage: DataTypes.STRING
2425
},
2526
);
2627
User.associate = (models) => {

server/sequelize/seeders/20200325133338-User.js

+9
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ const up = (queryInterface) => queryInterface.bulkInsert(
77
lastname: 'dontmodifieme',
88
googleId: '',
99
facebookId: '',
10+
profileImage: 'https://mcdn.wallpapersafari.com/medium/57/33/UW0jhS.jpg',
1011
1112
username: 'dummydata01',
1213
password: PasswordHelper.hashPassword('123456789'),
@@ -20,6 +21,7 @@ const up = (queryInterface) => queryInterface.bulkInsert(
2021
{
2122
googleId: '',
2223
facebookId: '',
24+
profileImage: 'https://mcdn.wallpapersafari.com/medium/57/33/UW0jhS.jpg',
2325
firstname: 'dummy',
2426
lastname: 'Data',
2527
@@ -35,6 +37,7 @@ const up = (queryInterface) => queryInterface.bulkInsert(
3537
{
3638
googleId: '',
3739
facebookId: '',
40+
profileImage: 'https://mcdn.wallpapersafari.com/medium/57/33/UW0jhS.jpg',
3841
firstname: 'dummy3',
3942
lastname: 'Data',
4043
@@ -50,6 +53,7 @@ const up = (queryInterface) => queryInterface.bulkInsert(
5053
{
5154
googleId: '',
5255
facebookId: '',
56+
profileImage: 'https://mcdn.wallpapersafari.com/medium/57/33/UW0jhS.jpg',
5357
firstname: 'dummy4',
5458
lastname: 'Data',
5559
@@ -65,6 +69,7 @@ const up = (queryInterface) => queryInterface.bulkInsert(
6569
{
6670
googleId: '',
6771
facebookId: '',
72+
profileImage: 'https://mcdn.wallpapersafari.com/medium/57/33/UW0jhS.jpg',
6873
firstname: 'Dumebi',
6974
lastname: 'Hiu',
7075
@@ -80,6 +85,7 @@ const up = (queryInterface) => queryInterface.bulkInsert(
8085
{
8186
googleId: '',
8287
facebookId: '',
88+
profileImage: 'https://mcdn.wallpapersafari.com/medium/57/33/UW0jhS.jpg',
8389
firstname: 'Dumebi',
8490
lastname: 'Hiu',
8591
@@ -95,6 +101,7 @@ const up = (queryInterface) => queryInterface.bulkInsert(
95101
{
96102
googleId: '',
97103
facebookId: '',
104+
profileImage: 'https://mcdn.wallpapersafari.com/medium/57/33/UW0jhS.jpg',
98105
firstname: 'ag',
99106
lastname: 'gy',
100107
@@ -110,6 +117,7 @@ const up = (queryInterface) => queryInterface.bulkInsert(
110117
{
111118
googleId: '',
112119
facebookId: '',
120+
profileImage: 'https://mcdn.wallpapersafari.com/medium/57/33/UW0jhS.jpg',
113121
firstname: 'chris',
114122
lastname: 'meme',
115123
@@ -125,6 +133,7 @@ const up = (queryInterface) => queryInterface.bulkInsert(
125133
{
126134
googleId: '',
127135
facebookId: '',
136+
profileImage: 'https://mcdn.wallpapersafari.com/medium/57/33/UW0jhS.jpg',
128137
firstname: 'Dumebi',
129138
lastname: 'Hiu',
130139

0 commit comments

Comments
 (0)