Merge pull request #933 from SUNET/ylle-ignore-subclassing

Suppress [misc] for untyped third-party base classes

Author: johanlundberg

Makefile

@@ -1,9 +1,7 @@
 TOPDIR:=	$(abspath .)
 SRCDIR=		$(TOPDIR)/src
 SOURCE=		$(SRCDIR)/eduid
-MYPY_ARGS=	--install-types --non-interactive --pretty --ignore-missing-imports \
-			--warn-unused-ignores \
-			# --disallow-untyped-decorators
+MYPY_ARGS=	--install-types --non-interactive --pretty
 MYPY_STRICT= --strict \
 			 --implicit-reexport \
 			 --allow-untyped-calls

mypy.ini

@@ -1,5 +1,9 @@
 [mypy]
 plugins = pydantic.mypy, marshmallow_dataclass.mypy
+disallow_subclassing_any = True
+disallow_untyped_decorators = True
+ignore_missing_imports = True
+warn_unused_ignores = True
 
 [mypy-ndnkdf.*]
 follow_untyped_imports = True

src/eduid/satosa/scimapi/accr.py

@@ -18,7 +18,7 @@
 type ProcessReturnType = InternalData | Response
 
 
-class request(RequestMicroService):
+class request(RequestMicroService):  # type: ignore[misc]
     """
     A class to handle and the ACCR request flowing through Satosa.
     ```yaml
@@ -105,7 +105,7 @@ def process(self, context: Context, data: InternalData) -> ProcessReturnType:
         return super().process(context, data)
 
 
-class response(ResponseMicroService):
+class response(ResponseMicroService):  # type: ignore[misc]
     """
     A class to handle and the ACCR response flowing through Satosa.
     ```yaml

src/eduid/satosa/scimapi/nameid.py

@@ -27,7 +27,7 @@
 logger = logging.getLogger(__name__)
 
 
-class request(RequestMicroService):
+class request(RequestMicroService):  # type: ignore[misc]
     def __init__(
         self,
         config: Mapping[str, Any],
@@ -56,7 +56,7 @@ def process(self, context: Context, data: InternalData) -> ProcessReturnType:
         return super().process(context, data)
 
 
-class response(ResponseMicroService):
+class response(ResponseMicroService):  # type: ignore[misc]
     def __init__(
         self,
         config: Mapping[str, Any],

src/eduid/satosa/scimapi/pairwiseid.py

@@ -18,7 +18,7 @@ class Config:
     pairwise_salt: str
 
 
-class GeneratePairwiseId(ResponseMicroService):
+class GeneratePairwiseId(ResponseMicroService):  # type: ignore[misc]
     """
     MicroService go generate pairwise-id based on subject-id
 

src/eduid/satosa/scimapi/scim_attributes.py

@@ -39,7 +39,7 @@ class UserGroups:
     manager: list[ScimApiGroup] = field(default_factory=list)
 
 
-class ScimAttributes(ResponseMicroService):
+class ScimAttributes(ResponseMicroService):  # type: ignore[misc]
     """
     Add attributes from the scim db to the responses.
     """

src/eduid/satosa/scimapi/serve_static.py

@@ -14,7 +14,7 @@
 logger = logging.getLogger("satosa")
 
 
-class ServeStatic(RequestMicroService):
+class ServeStatic(RequestMicroService):  # type: ignore[misc]
     """
     A class to serve static files from a given directory
 

src/eduid/satosa/scimapi/static_attributes.py

@@ -15,7 +15,7 @@
 StaticAppendedAttributesConfig = dict[str, list[dict[str, str]]]
 
 
-class AddStaticAttributesForVirtualIdp(ResponseMicroService):
+class AddStaticAttributesForVirtualIdp(ResponseMicroService):  # type: ignore[misc]
     """
     A class that add static attributes to a response set.
     The following example configuration illustrates most common features:

src/eduid/satosa/scimapi/statsd.py

@@ -13,7 +13,7 @@
 logger = logging.getLogger(__name__)
 
 
-class RequesterCounter(ResponseMicroService):
+class RequesterCounter(ResponseMicroService):  # type: ignore[misc]
     """
         A class to count the requesting SP.
 

src/eduid/satosa/scimapi/stepup.py

@@ -58,7 +58,7 @@
 STATE_KEY_MFA = "requester-authn-class-ref"
 
 
-class StepUpError(SATOSAError):
+class StepUpError(SATOSAError):  # type: ignore[misc]
     """Generic error for this plugin."""
 
 
@@ -104,7 +104,7 @@ class StepupParams(BaseModel):
 
 
 # Applied to response from IDP
-class StepUp(ResponseMicroService):
+class StepUp(ResponseMicroService):  # type: ignore[misc]
     """
     A micro-SP just to handle the communication towards the StepUp Service for SFO.
 
@@ -512,7 +512,7 @@ def register_endpoints(self) -> list[tuple[str, CallbackCallSignature]]:
 
 
 # applied to incoming request from SP
-class AuthnContext(RequestMicroService):
+class AuthnContext(RequestMicroService):  # type: ignore[misc]
     """
     A micro-service that runs when the authnRequest is first received from the SP.
 
@@ -634,7 +634,7 @@ def get_loa_settings_for_entity_id(
     return None
 
 
-class StepupSAMLBackend(SAMLBackend):
+class StepupSAMLBackend(SAMLBackend):  # type: ignore[misc]
     """
     A SAML backend to request custom authn context class references from IdP:s with certain entity attributes.
     """
@@ -665,7 +665,7 @@ def authn_request(self, context: satosa.context.Context, entity_id: str) -> SeeO
         return super().authn_request(context, entity_id)
 
 
-class RewriteAuthnContextClass(ResponseMicroService):
+class RewriteAuthnContextClass(ResponseMicroService):  # type: ignore[misc]
     """
     When we receive a response from an IdP, we check if we have configuration specifying
     'normalisation' of the authn context class reference in our MFA configuration.