From d60558b4a34900e3be178da0b7db5ece1dae00fa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dirk=20M=C3=BCller?= Date: Mon, 30 Sep 2024 10:17:39 +0200 Subject: [PATCH] remove ensure_future wrapping for coroutines These are awaitable natively, no need to wrap it in a task. --- src/bci_build/package/__init__.py | 30 +++++++++--------------------- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/src/bci_build/package/__init__.py b/src/bci_build/package/__init__.py index 46281b3bf..cb272e79a 100644 --- a/src/bci_build/package/__init__.py +++ b/src/bci_build/package/__init__.py @@ -1290,29 +1290,21 @@ async def write_file_to_dest(fname: str, contents: str | bytes) -> None: if dockerfile[-1] != "\n": dockerfile += "\n" - tasks.append(asyncio.ensure_future(write_file_to_dest(fname, dockerfile))) + tasks.append(write_file_to_dest(fname, dockerfile)) files.append(fname) elif self.build_recipe_type == BuildType.KIWI: fname = f"{self.package_name}.kiwi" tasks.append( - asyncio.ensure_future( - write_file_to_dest( - fname, - KIWI_TEMPLATE.render( - image=self, INFOHEADER=INFOHEADER_TEMPLATE - ), - ) + write_file_to_dest( + fname, + KIWI_TEMPLATE.render(image=self, INFOHEADER=INFOHEADER_TEMPLATE), ) ) files.append(fname) if self.config_sh: - tasks.append( - asyncio.ensure_future( - write_file_to_dest("config.sh", self.config_sh) - ) - ) + tasks.append(write_file_to_dest("config.sh", self.config_sh)) files.append("config.sh") else: @@ -1321,9 +1313,7 @@ async def write_file_to_dest(fname: str, contents: str | bytes) -> None: ), f"got an unexpected build_recipe_type: '{self.build_recipe_type}'" tasks.append( - asyncio.ensure_future( - write_file_to_dest("_service", SERVICE_TEMPLATE.render(image=self)) - ) + write_file_to_dest("_service", SERVICE_TEMPLATE.render(image=self)) ) changes_file_name = self.package_name + ".changes" @@ -1343,15 +1333,13 @@ async def write_file_to_dest(fname: str, contents: str | bytes) -> None: ): name_to_include += f" {ver}" tasks.append( - asyncio.ensure_future( - write_file_to_dest( - changes_file_name, - f"""------------------------------------------------------------------- + write_file_to_dest( + changes_file_name, + f"""------------------------------------------------------------------- {datetime.datetime.now(tz=datetime.timezone.utc).strftime("%a %b %d %X %Z %Y")} - SUSE Update Bot - First version of the {name_to_include} BCI """, - ) ) ) files.append(changes_file_name)