Skip to content

Commit 6d0a2c8

Browse files
committed
Fix failing ruby tests on Factory
The latest ruby container doesn't return on the connection tests unless the rails server is shutdown. This commit adds a timeout to the rails server to avoid this deadlock.
1 parent d1bd8a6 commit 6d0a2c8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/test_ruby.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,5 +123,5 @@ def test_rails_template(auto_container_per_test):
123123
pytest.xfail("timezone data are not in the container")
124124

125125
assert "Ruby on Rails" in auto_container_per_test.connection.check_output(
126-
"cd /hello/ && (rails server > /dev/null &) && curl -sf --retry 5 --retry-connrefused http://localhost:3000",
126+
"cd /hello/ && (timeout 30 rails server > /dev/null &) && curl -sf --retry 5 --retry-connrefused http://localhost:3000",
127127
)

0 commit comments

Comments
 (0)