Improve addon upgrade check

Author: mjura

internal/pkg/skuba/kubernetes/node_version.go

@@ -285,3 +285,14 @@ func AllNodesMatchClusterVersionWithVersioningInfo(allNodesVersioningInfo NodeVe
 	}
 	return true
 }
+
+// AllNodesTolerateVersionWithVersioningInfo returns if all nodes tolerate a specific kubernetes version
+// This can be used to determine e.g. if an upgrade is ongoing
+func AllNodesTolerateClusterVersionWithVersioningInfo(allNodesVersioningInfo NodeVersionInfoMap, clusterVersion *version.Version) bool {
+	for _, version := range allNodesVersioningInfo {
+		if !version.ToleratesClusterVersion(clusterVersion) {
+			return false
+		}
+	}
+	return true
+}

pkg/skuba/actions/addon/upgrade/apply.go

@@ -65,7 +65,7 @@ func Apply(client clientset.Interface) error {
 	if err != nil {
 		return err
 	}
-	allNodesMatchClusterVersion := kubernetes.AllNodesMatchClusterVersionWithVersioningInfo(allNodesVersioningInfo, currentClusterVersion)
+	allNodesMatchClusterVersion := kubernetes.AllNodesTolerateClusterVersionWithVersioningInfo(allNodesVersioningInfo, currentClusterVersion)
 	fmt.Printf("Current Kubernetes cluster version: %s\n", currentVersion)
 	fmt.Printf("Latest Kubernetes version: %s\n", latestVersion)
 	fmt.Println()

pkg/skuba/actions/addon/upgrade/plan.go

@@ -62,7 +62,7 @@ func Plan(client clientset.Interface) error {
 	if err != nil {
 		return err
 	}
-	allNodesMatchClusterVersion := kubernetes.AllNodesMatchClusterVersionWithVersioningInfo(allNodesVersioningInfo, currentClusterVersion)
+	allNodesMatchClusterVersion := kubernetes.AllNodesTolerateClusterVersionWithVersioningInfo(allNodesVersioningInfo, currentClusterVersion)
 	fmt.Printf("Current Kubernetes cluster version: %s\n", currentVersion)
 	fmt.Printf("Latest Kubernetes version: %s\n", latestVersion)
 	fmt.Println()