Fix: inverted logic in Modal sandbox termination (#278)

* Fix ModalDeployment.stop logic to verify sandbox is running

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: AlienKevin

src/swerex/deployment/modal.py

@@ -251,8 +251,12 @@ async def stop(self):
             await self._runtime.close()
             self._runtime = None
         if self._sandbox is not None:
+            # Check if the sandbox is still running
             exit_code = await self._sandbox.poll.aio()
-            if exit_code is not None:
+
+            # If exit_code is None, the process is still active -> Terminate it
+            if exit_code is None:
+                self.logger.info(f"Terminating sandbox {self._sandbox.object_id}...")
                 await self._sandbox.terminate.aio()
         self._sandbox = None
         self._app = None

src/swerex/runtime/local.py

@@ -55,12 +55,12 @@
 __all__ = ["LocalRuntime", "BashSession"]
 
 
-def _split_bash_command(inpt: str) -> list[str]:
+def _split_bash_command(input: str) -> list[str]:
     r"""Split a bash command with linebreaks, escaped newlines, and heredocs into a list of
     individual commands.
 
     Args:
-        inpt: The input string to split into commands.
+        input: The input string to split into commands.
     Returns:
         A list of commands as strings.
 
@@ -70,11 +70,11 @@ def _split_bash_command(inpt: str) -> list[str]:
     "cmd1\\\n asdf" is one command (because the linebreak is escaped)
     "cmd1<<EOF\na\nb\nEOF" is one command (because of the heredoc)
     """
-    inpt = inpt.strip()
-    if not inpt or all(l.strip().startswith("#") for l in inpt.splitlines()):
+    input = input.strip()
+    if not input or all(l.strip().startswith("#") for l in input.splitlines()):
         # bashlex can't deal with empty strings or the like :/
         return []
-    parsed = bashlex.parse(inpt)
+    parsed = bashlex.parse(input)
     cmd_strings = []
 
     def find_range(cmd: bashlex.ast.node) -> tuple[int, int]:
@@ -88,7 +88,7 @@ def find_range(cmd: bashlex.ast.node) -> tuple[int, int]:
 
     for cmd in parsed:
         start, end = find_range(cmd)
-        cmd_strings.append(inpt[start:end])
+        cmd_strings.append(input[start:end])
     return cmd_strings