Skip to content

Commit 4d727d4

Browse files
authored
Merge pull request #20 from SWIFTSIM/update_deps
Update dependencies
2 parents 2e90113 + 4386368 commit 4d727d4

File tree

5 files changed

+5
-14
lines changed

5 files changed

+5
-14
lines changed

README.rst

-5
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,10 @@ SWIFTGalaxy
1414
1515
SWIFTGalaxy is a module that extends SWIFTSimIO_ tailored to analyses of particles belonging to individual simulated galaxies. It inherits from and extends the functionality of the ``SWIFTDataset``. It understands the content of halo catalogues (supported: `Velociraptor`_, `Caesar`_, `SOAP`_) and therefore which particles belong to a galaxy or other group of particles, and its integrated properties. The particles occupy a coordinate frame that is enforced to be consistent, such that particles loaded on-the-fly will match e.g. rotations and translations of particles already in memory. Intuitive masking of particle datasets is also enabled. Finally, some utilities to make working in cylindrical and spherical coordinate systems more convenient are also provided.
1616

17-
.. warning::
18-
19-
In order to support use of SOAP halo catalogues this version (1.1.0) of SWIFTGalaxy depends on the `load_fof_catalogues`_ branch of SWIFTSimIO. This dependency will be automatically handled by ``pip``, but to use SOAP catalogues in SWIFTGalaxy you **must** install from github. One way to do this is ``pip install git+https://github.com/SWIFTSIM/swiftgalaxy.git``. PyPI_ does not allow depending on github repositories so SWIFTGalaxy v1.1.0 will not be released on PyPI (and therefore cannot be installed with ``pip install swiftgalaxy``) until the load_fof_catalogues branch is merged into SWIFTSimIO and itself released on PyPI. You can use the PyPI versions of both SWIFTGalaxy and SWIFTSimIO (these are compatible) but in this case SOAP halo catalogues are not supported.
20-
2117
.. _SWIFTSimIO: http://swiftsimio.readthedocs.org
2218
.. _Velociraptor: https://ui.adsabs.harvard.edu/abs/2019PASA...36...21E/abstract
2319
.. _Caesar: https://caesar.readthedocs.io/en/latest/
2420
.. _SOAP: https://github.com/SWIFTSIM/SOAP
25-
.. _load_fof_catalogues: https://github.com/SWIFTSIM/swiftsimio/tree/load_fof_catalogues
2621
.. _PyPI: https://pypi.org
2722

2823
.. INTRO_END_LABEL

docs/source/halo_catalogues/index.rst

-5
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@ The `SOAP`_ catalogue format is the preferred catalogue format of the `SWIFT com
1616

1717
.. _SWIFT community: https://github.com/SWIFTSIM
1818
.. _SOAP: https://github.com/SWIFTSIM/SOAP
19-
.. _load_fof_catalogues: https://github.com/SWIFTSIM/swiftsimio/tree/load_fof_catalogues
20-
21-
.. warning ::
22-
23-
At the time of writing :mod:`swiftsimio` support for reading SOAP catalogues is functional but still under active development. The ``master`` branch of the :mod:`swiftsimio` repository does not yet allow reading SOAP catalogues. To use :mod:`swiftgalaxy` with SOAP catalogues currently requires installing the `load_fof_catalogues`_ branch of :mod:`swiftsimio`. One way to do this is ``pip install git+https://github.com/SWIFTSIM/swiftsimio.git@load_fof_catalogues``.
2419

2520
Setting up an instance of the helper class is straightforward. We'll assume a SOAP catalogue called :file:`halo_properties_0123.hdf5`, and suppose that we're interested in the first object in the catalogue (row ``0``):
2621

examples/SWIFTGalaxy_Colibre_QuickStart.ipynb

+3-2
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,8 @@
264264
"source": [
265265
"for ptype in \"gas\", \"dark_matter\", \"stars\":\n",
266266
" getattr(sg, ptype).smoothing_length = generate_smoothing_lengths(\n",
267-
" (getattr(sg, ptype).coordinates + sg.centre) % sg.metadata.boxsize, # modified to wrap the box\n",
267+
" (getattr(sg, ptype).coordinates + sg.centre)\n",
268+
" % sg.metadata.boxsize, # modified to wrap the box\n",
268269
" sg.metadata.boxsize,\n",
269270
" kernel_gamma=1.8,\n",
270271
" neighbours=57,\n",
@@ -623,7 +624,7 @@
623624
" # no particles of this type\n",
624625
" print(f\"no {ptype}\")\n",
625626
" myvis(sg, fignum=figcounter)\n",
626-
" figcounter += 1\n"
627+
" figcounter += 1"
627628
]
628629
}
629630
],

optional_requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
pytest
22
black[jupyter]
33
wily
4-
git+https://github.com/kyleaoman/velociraptor-python.git@load_fof_catalogues
4+
velociraptor
55
git+https://github.com/dnarayanan/caesar.git

requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ numpy
22
scipy
33
h5py
44
unyt
5-
git+https://github.com/SWIFTSIM/swiftsimio.git
5+
swiftsimio
66
astropy

0 commit comments

Comments
 (0)