Try/catch inside of conditional

mnadareski · mnadareski · commit cabd0f856183 · 2026-02-28T09:54:03.000-05:00
diff --git a/SabreTools.RedumpLib/Web/RedumpClient.cs b/SabreTools.RedumpLib/Web/RedumpClient.cs
@@ -691,17 +691,17 @@ public async Task<bool> DownloadSingleSiteID(int id, string? outDir, bool rename
                 }
                 else if (discPage.Contains($"Disc with ID \"{id}\" doesn't exist"))
                 {
-                    try
+                    if (rename)
                     {
-                        if (rename)
+                        try
                         {
                             if (Directory.Exists(paddedIdDir) && rename)
                                 Directory.Move(paddedIdDir, paddedIdDir + "-deleted");
                             else
                                 Directory.CreateDirectory(paddedIdDir + "-deleted");
                         }
+                        catch { }
                     }
-                    catch { }
 
                     Console.Error.WriteLine($"ID {paddedId} could not be found!");
                     return false;
@@ -863,17 +863,17 @@ public async Task<bool> DownloadSingleWIPID(int id, string? outDir, bool rename)
                 }
                 else if (discPage.Contains($"WIP disc with ID \"{id}\" doesn't exist"))
                 {
-                    try
+                    if (rename)
                     {
-                        if (rename)
+                        try
                         {
                             if (Directory.Exists(paddedIdDir) && rename)
                                 Directory.Move(paddedIdDir, paddedIdDir + "-deleted");
                             else
                                 Directory.CreateDirectory(paddedIdDir + "-deleted");
                         }
+                        catch { }
                     }
-                    catch { }
 
                     Console.Error.WriteLine($"ID {paddedId} could not be found!");
                     return false;

Original file line number	Diff line number	Diff line change
`@@ -691,17 +691,17 @@ public async Task<bool> DownloadSingleSiteID(int id, string? outDir, bool rename`
`691`	`691`	`}`
`692`	`692`	`else if (discPage.Contains($"Disc with ID \"{id}\" doesn't exist"))`
`693`	`693`	`{`
`694`		`- try`
	`694`	`+ if (rename)`
`695`	`695`	`{`
`696`		`- if (rename)`
	`696`	`+ try`
`697`	`697`	`{`
`698`	`698`	`if (Directory.Exists(paddedIdDir) && rename)`
`699`	`699`	`Directory.Move(paddedIdDir, paddedIdDir + "-deleted");`
`700`	`700`	`else`
`701`	`701`	`Directory.CreateDirectory(paddedIdDir + "-deleted");`
`702`	`702`	`}`
	`703`	`+ catch { }`
`703`	`704`	`}`
`704`		`- catch { }`
`705`	`705`
`706`	`706`	`Console.Error.WriteLine($"ID {paddedId} could not be found!");`
`707`	`707`	`return false;`
`@@ -863,17 +863,17 @@ public async Task<bool> DownloadSingleWIPID(int id, string? outDir, bool rename)`
`863`	`863`	`}`
`864`	`864`	`else if (discPage.Contains($"WIP disc with ID \"{id}\" doesn't exist"))`
`865`	`865`	`{`
`866`		`- try`
	`866`	`+ if (rename)`
`867`	`867`	`{`
`868`		`- if (rename)`
	`868`	`+ try`
`869`	`869`	`{`
`870`	`870`	`if (Directory.Exists(paddedIdDir) && rename)`
`871`	`871`	`Directory.Move(paddedIdDir, paddedIdDir + "-deleted");`
`872`	`872`	`else`
`873`	`873`	`Directory.CreateDirectory(paddedIdDir + "-deleted");`
`874`	`874`	`}`
	`875`	`+ catch { }`
`875`	`876`	`}`
`876`		`- catch { }`
`877`	`877`
`878`	`878`	`Console.Error.WriteLine($"ID {paddedId} could not be found!");`
`879`	`879`	`return false;`