Skip to content

Commit eeac28e

Browse files
committed
Start filling in URL builder tests
1 parent f3fb982 commit eeac28e

2 files changed

Lines changed: 37 additions & 10 deletions

File tree

SabreTools.RedumpLib.Test/Web/UrlBuilderTests.cs

Lines changed: 35 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
using System;
2-
using System.Collections.Generic;
3-
using System.Data;
4-
using System.Linq;
51
using SabreTools.RedumpLib.Web;
62
using Xunit;
73

@@ -11,6 +7,15 @@ public class UrlBuilderTests
117
{
128
#region BuildDiscUrl
139

10+
[Theory]
11+
[InlineData(1, 1)]
12+
[InlineData(-1, 1)]
13+
public void BuildDiscUrl_AlwaysPositive(int id, int expected)
14+
{
15+
string actual = UrlBuilder.BuildDiscUrl(id);
16+
Assert.Equal($"http://redump.org/disc/{expected}/", actual);
17+
}
18+
1419
// TODO: Implement
1520

1621
#endregion
@@ -23,13 +28,23 @@ public class UrlBuilderTests
2328

2429
#region BuildDiscsWipUrl
2530

26-
// TODO: Implement
31+
[Fact]
32+
public void BuildDiscsWipUrl_Constant()
33+
{
34+
string actual = UrlBuilder.BuildDiscsWipUrl();
35+
Assert.Equal("http://redump.org/discs-wip/", actual);
36+
}
2737

2838
#endregion
2939

3040
#region BuildDownloadsUrl
3141

32-
// TODO: Implement
42+
[Fact]
43+
public void BuildDownloadsUrl_Constant()
44+
{
45+
string actual = UrlBuilder.BuildDownloadsUrl();
46+
Assert.Equal("http://redump.org/downloads/", actual);
47+
}
3348

3449
#endregion
3550

@@ -41,13 +56,25 @@ public class UrlBuilderTests
4156

4257
#region BuildMemberPromotionUrl
4358

44-
// TODO: Implement
59+
[Fact]
60+
public void BuildMemberPromotionUrl_Constant()
61+
{
62+
string actual = UrlBuilder.BuildMemberPromotionUrl();
63+
Assert.Equal("http://redump.org/member2dumper/", actual);
64+
}
4565

4666
#endregion
4767

4868
#region BuildNewDiscUrl
4969

50-
// TODO: Implement
70+
[Theory]
71+
[InlineData(1, 1)]
72+
[InlineData(-1, 1)]
73+
public void BuildNewDiscUrl_AlwaysPositive(int id, int expected)
74+
{
75+
string actual = UrlBuilder.BuildNewDiscUrl(id);
76+
Assert.Equal($"http://redump.org/newdisc/{expected}/", actual);
77+
}
5178

5279
#endregion
5380

SabreTools.RedumpLib/Web/UrlBuilder.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ public static string BuildDiscUrl(int id,
181181
var sb = new StringBuilder();
182182

183183
sb.Append(SiteBaseUrl);
184-
sb.AppendFormat(DiscPath, +id);
184+
sb.AppendFormat(DiscPath, Math.Abs(id));
185185

186186
if (changes)
187187
sb.Append(DiscPathChangesSubpath);
@@ -498,7 +498,7 @@ public static string BuildNewDiscUrl(int id)
498498
var sb = new StringBuilder();
499499

500500
sb.Append(SiteBaseUrl);
501-
sb.AppendFormat(NewDiscPath, +id);
501+
sb.AppendFormat(NewDiscPath, Math.Abs(id));
502502

503503
return sb.ToString();
504504
}

0 commit comments

Comments
 (0)