Merge pull request #111 from pranitaurlam/optimize-roadmap-seo

Optimizing Roadmap SEO and Indexing logic

Author: Sachinchaurasiya360

client/src/components/SEO.tsx

@@ -39,25 +39,32 @@ export function SEO({
       <title>{fullTitle}</title>
       <meta name="description" content={description} />
 
-      {/* Open Graph */}
+      {/* Primary Meta Tags */}
+      <meta name="title" content={fullTitle} />
+
+      {/* Open Graph / Facebook */}
+      <meta property="og:type" content={ogType} />
+      <meta property="og:url" content={effectiveCanonical} />
       <meta property="og:title" content={fullTitle} />
       <meta property="og:description" content={description} />
-      <meta property="og:type" content={ogType} />
       <meta property="og:image" content={absoluteOgImage} />
       <meta property="og:site_name" content={SITE_NAME} />
-      <meta property="og:url" content={effectiveCanonical} />
 
-      {/* Twitter Card */}
+      {/* Twitter */}
       <meta name="twitter:card" content="summary_large_image" />
+      <meta name="twitter:url" content={effectiveCanonical} />
       <meta name="twitter:title" content={fullTitle} />
       <meta name="twitter:description" content={description} />
       <meta name="twitter:image" content={absoluteOgImage} />
 
-      {/* Canonical, always present */}
+      {/* Canonical URL */}
       <link rel="canonical" href={effectiveCanonical} />
 
       {/* Robots */}
-      {noIndex && <meta name="robots" content="noindex,nofollow" />}
+      <meta
+        name="robots"
+        content={noIndex ? "noindex,nofollow" : "index,follow,max-image-preview:large,max-snippet:-1,max-video-preview:-1"}
+      />
 
       {/* Structured Data (JSON-LD) */}
       {structuredData &&

client/src/module/student/roadmap/RoadmapDetailPage.tsx

@@ -139,6 +139,9 @@ export default function RoadmapDetailPage() {
         title={`${roadmap.title} (Free)`}
         description={roadmap.shortDescription}
         canonicalUrl={canonicalUrl(`/roadmaps/${roadmap.slug}`)}
+        ogImage={roadmap.ogImage || roadmap.coverImage || undefined}
+        ogType="article"
+        noIndex={!roadmap.isPublished}
         structuredData={faqSchema ? [courseSchema, faqSchema] : courseSchema}
       />
 

client/src/module/student/roadmap/RoadmapTopicPage.tsx

@@ -19,7 +19,12 @@ import type {
 interface TopicResponse {
   topic: RoadmapTopic & {
     resources: RoadmapResource[];
-    section: { slug: string; title: string; orderIndex: number; roadmap: { slug: string; title: string } };
+    section: { 
+      slug: string; 
+      title: string; 
+      orderIndex: number; 
+      roadmap: { slug: string; title: string; isPublished: boolean }; 
+    };
   };
 }
 
@@ -117,6 +122,8 @@ export default function RoadmapTopicPage() {
         title={`${topic.title} - ${topic.section.roadmap.title}`}
         description={topic.summary}
         canonicalUrl={canonicalUrl(`/roadmaps/${slug}/topics/${topic.slug}`)}
+        ogType="article"
+        noIndex={!topic.section.roadmap.isPublished}
         structuredData={learningResourceSchema ?? undefined}
       />
 

server/src/module/roadmap/roadmap.controller.ts

@@ -63,6 +63,15 @@ export async function getRoadmap(req: Request, res: Response, next: NextFunction
       res.status(404).json({ message: "Roadmap not found" });
       return;
     }
+
+    if (!roadmap.isPublished) {
+      const user = req.user;
+      if (!user || (user.role !== "ADMIN" && user.id !== roadmap.ownerUserId)) {
+        res.status(404).json({ message: "Roadmap not found" });
+        return;
+      }
+    }
+
     res.json({ roadmap });
   } catch (err) {
     next(err);
@@ -81,12 +90,22 @@ export async function getTopic(req: Request, res: Response, next: NextFunction)
       res.status(404).json({ message: "Topic not found" });
       return;
     }
+
+    if (!topic.section.roadmap.isPublished) {
+      const user = req.user;
+      if (!user || (user.role !== "ADMIN" && user.id !== topic.section.roadmap.ownerUserId)) {
+        res.status(404).json({ message: "Topic not found" });
+        return;
+      }
+    }
+
     res.json({ topic });
   } catch (err) {
     next(err);
   }
 }
 
+
 // ─── Auth ──────────────────────────────────────────────────────────────────
 export async function enroll(req: Request, res: Response, next: NextFunction) {
   try {

server/src/module/roadmap/roadmap.routes.ts

@@ -1,4 +1,5 @@
 import { Router } from "express";
+import { authMiddleware, optionalAuthMiddleware } from "../../middleware/auth.middleware.js";
 import { authMiddleware } from "../../middleware/auth.middleware.js";
 import { aiRoadmapLimiter } from "../../middleware/rate-limit.middleware.js";
 import {
@@ -36,8 +37,9 @@ roadmapRouter.post(
 
 // ── Public ────────────────────────────────────────────────────────────────
 roadmapRouter.get("/", getRoadmaps);
-roadmapRouter.get("/:slug", getRoadmap);
-roadmapRouter.get("/:slug/topics/:topicSlug", getTopic);
+roadmapRouter.get("/:slug", optionalAuthMiddleware, getRoadmap);
+roadmapRouter.get("/:slug/topics/:topicSlug", optionalAuthMiddleware, getTopic);
+
 
 // ── Auth: enrollment ──────────────────────────────────────────────────────
 roadmapRouter.post("/:slug/enroll", authMiddleware, enroll);

server/src/module/roadmap/roadmap.service.ts

@@ -149,8 +149,8 @@ export async function listPublishedRoadmaps(opts: {
 }
 
 export async function getRoadmapBySlug(slug: string) {
-  return prisma.roadmap.findFirst({
-    where: { slug, isPublished: true },
+  return prisma.roadmap.findUnique({
+    where: { slug },
     include: {
       sections: {
         orderBy: { orderIndex: "asc" },
@@ -169,7 +169,7 @@ export async function getTopicBySlug(roadmapSlug: string, topicSlug: string) {
   return prisma.roadmapTopic.findFirst({
     where: {
       slug: topicSlug,
-      section: { roadmap: { slug: roadmapSlug, isPublished: true } },
+      section: { roadmap: { slug: roadmapSlug } },
     },
     include: {
       resources: { orderBy: { orderIndex: "asc" } },
@@ -178,7 +178,7 @@ export async function getTopicBySlug(roadmapSlug: string, topicSlug: string) {
           slug: true,
           title: true,
           orderIndex: true,
-          roadmap: { select: { slug: true, title: true } },
+          roadmap: { select: { slug: true, title: true, isPublished: true, ownerUserId: true } },
         },
       },
     },