Skip to content

Commit 00d6316

Browse files
author
Nadim Ritter
committed
fix privilege problem for application search feature
1 parent f4735d4 commit 00d6316

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/main/java/ch/ethz/seb/sps/server/weblayer/AdminProctorController.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -958,7 +958,6 @@ public DistinctMetadataWindowForExam getDistinctMetadataWindowForExam(
958958
@RequestParam(name = API.SCREENSHOT_META_DATA_APPLICATION, required = true) final String metadataApplication,
959959
@RequestParam(name = API.PARAM_GROUP_IDS, required = true) final String groupIds){
960960

961-
// TODO Apply user rights
962961
return this.proctoringService.getDistinctMetadataWindowForExam(metadataApplication, getIdListFromParameter(groupIds));
963962
}
964963

@@ -988,7 +987,6 @@ public List<UserListForApplicationSearch> getUserListForApplicationSearch(
988987
@RequestParam(name = API.SCREENSHOT_META_DATA_ACTIVE_WINDOW_TITLE, required = true) final String metadataWindowTitle,
989988
@RequestParam(name = API.PARAM_GROUP_IDS, required = true) final String groupIds){
990989

991-
// TODO Apply user rights?
992990
return this.screenshotDataDAO
993991
.getUserListForApplicationSearch(metadataApplication, metadataWindowTitle, getIdListFromParameter(groupIds))
994992
.getOrThrow();
@@ -1079,7 +1077,7 @@ private List<Long> getIdListFromParameter(final String ids){
10791077
for (String s : idsString) {
10801078
try {
10811079
Long id = Long.parseLong(s);
1082-
if (readPrivilegedPredication.contains(id)) {
1080+
if (readPrivilegedPredication.contains(id) || readPrivilegedPredication.isEmpty()) {
10831081
idsList.add(id);
10841082
}
10851083
} catch (Exception e) {

0 commit comments

Comments
 (0)