ci(reviewer-bot): add marker-based test jobs

Author: PLeVasseur

.github/workflows/reviewer-bot-tests.yml

@@ -32,7 +32,52 @@ jobs:
       - name: Install dependencies
         run: uv sync --dev
 
-      - name: Run reviewer bot unit and integration tests with targeted coverage
+      - name: Run reviewer bot unit tests
+        run: uv run pytest tests/unit/reviewer_bot
+
+  reviewer-bot-integration:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@v6
+
+      - name: Install dependencies
+        run: uv sync --dev
+
+      - name: Run reviewer bot integration tests
+        run: uv run pytest tests/integration/reviewer_bot -m integration
+
+  reviewer-bot-contract:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@v6
+
+      - name: Install dependencies
+        run: uv sync --dev
+
+      - name: Run reviewer bot contract tests
+        run: uv run pytest tests/contract/reviewer_bot -m contract
+
+  reviewer-bot-coverage:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@v6
+
+      - name: Install dependencies
+        run: uv sync --dev
+
+      - name: Run reviewer bot coverage suite
         run: >-
           mkdir -p artifacts/coverage &&
           COVERAGE_FILE=artifacts/coverage/.coverage
@@ -66,18 +111,3 @@ jobs:
                   f"reviewer-bot branch coverage below floor: {branches:.2f}% < 48%"
               )
           PY
-
-  reviewer-bot-contract:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
-      - name: Install uv
-        uses: astral-sh/setup-uv@v6
-
-      - name: Install dependencies
-        run: uv sync --dev
-
-      - name: Run reviewer bot contract tests
-        run: uv run pytest tests/contract/reviewer_bot

tests/contract/reviewer_bot/test_adapter_contract.py

@@ -1,4 +1,7 @@
 from typing import get_type_hints
+import pytest
+
+pytestmark = pytest.mark.contract
 
 from scripts import reviewer_bot
 from scripts.reviewer_bot_lib.context import (
@@ -9,48 +12,40 @@
 )
 from scripts.reviewer_bot_lib.runtime import ReviewerBotRuntime
 
-
 def test_reviewer_bot_exports_runtime_modules():
     assert reviewer_bot.requests is not None
     assert reviewer_bot.sys is not None
     assert reviewer_bot.datetime is not None
     assert reviewer_bot.timezone is not None
 
-
 def test_reviewer_bot_satisfies_runtime_context_protocol():
     assert isinstance(reviewer_bot, ReviewerBotContext)
 
-
 def test_reviewer_bot_satisfies_narrower_lock_and_state_protocols():
     assert isinstance(reviewer_bot, GitHubTransportContext)
     assert isinstance(reviewer_bot, StateStoreContext)
     assert isinstance(reviewer_bot, LeaseLockContext)
 
-
 def test_render_lock_commit_message_uses_direct_json_import():
     rendered = reviewer_bot.render_lock_commit_message({"lock_state": "unlocked"})
     assert reviewer_bot.LOCK_COMMIT_MARKER in rendered
 
-
 def test_maybe_record_head_observation_repair_wrapper_exports_structured_result_type():
     hints = get_type_hints(reviewer_bot.maybe_record_head_observation_repair)
 
     assert hints["return"] is reviewer_bot.lifecycle_module.HeadObservationRepairResult
 
-
 def test_runtime_context_protocol_exposes_structured_head_repair_contract():
     hints = get_type_hints(ReviewerBotContext.maybe_record_head_observation_repair)
 
     assert hints["return"] is reviewer_bot.lifecycle_module.HeadObservationRepairResult
 
-
 def test_runtime_bot_returns_concrete_runtime_object():
     runtime = reviewer_bot._runtime_bot()
 
     assert isinstance(runtime, ReviewerBotRuntime)
     assert runtime.EVENT_INTENT_MUTATING == reviewer_bot.EVENT_INTENT_MUTATING
 
-
 def test_build_event_context_returns_structured_context(monkeypatch):
     monkeypatch.setenv("EVENT_NAME", "workflow_run")
     monkeypatch.setenv("EVENT_ACTION", "completed")
@@ -64,7 +59,6 @@ def test_build_event_context_returns_structured_context(monkeypatch):
     assert context.workflow_run_event == "pull_request_review"
     assert context.issue_labels == ("coding guideline",)
 
-
 def test_execute_run_returns_execution_result(monkeypatch):
     monkeypatch.setenv("EVENT_NAME", "pull_request_review")
     monkeypatch.setenv("EVENT_ACTION", "submitted")

tests/contract/reviewer_bot/test_privileged_commands_workflow.py

@@ -1,5 +1,7 @@
 from pathlib import Path
+import pytest
 
+pytestmark = pytest.mark.contract
 
 def test_privileged_commands_workflow_executes_source_entrypoint():
     workflow_text = Path(".github/workflows/reviewer-bot-privileged-commands.yml").read_text(

tests/contract/reviewer_bot/test_reviewer_board_workflow_contracts.py

@@ -1,7 +1,9 @@
 from pathlib import Path
+import pytest
 
-import yaml
+pytestmark = pytest.mark.contract
 
+import yaml
 
 def test_sweeper_repair_workflow_exposes_reviewer_board_preview_dispatch():
     data = yaml.safe_load(Path(".github/workflows/reviewer-bot-sweeper-repair.yml").read_text(encoding="utf-8"))
@@ -13,7 +15,6 @@ def test_sweeper_repair_workflow_exposes_reviewer_board_preview_dispatch():
     assert issue_number_input["required"] is False
     assert issue_number_input["type"] == "string"
 
-
 def test_sweeper_repair_workflow_scopes_reviewer_board_env_to_preview_only():
     workflow_text = Path(".github/workflows/reviewer-bot-sweeper-repair.yml").read_text(encoding="utf-8")
     assert "ISSUE_NUMBER: ${{ github.event.inputs.issue_number }}" in workflow_text

tests/contract/reviewer_bot/test_workflow_artifact_contracts.py

@@ -1,9 +1,9 @@
 from pathlib import Path
-
 import pytest
 
-from scripts import reviewer_bot
+pytestmark = pytest.mark.contract
 
+from scripts import reviewer_bot
 
 @pytest.mark.parametrize(
     ("workflow_path", "artifact_name", "payload_name"),
@@ -38,7 +38,6 @@ def test_observer_workflow_files_match_expected_artifact_contract(
     assert artifact_name in workflow_text
     assert payload_name in workflow_text
 
-
 @pytest.mark.parametrize(
     ("payload", "workflow_name", "workflow_file", "artifact_name", "payload_name"),
     [
@@ -106,7 +105,6 @@ def test_deferred_workflow_identity_helpers_match_expected_contract(
     assert reviewer_bot.reconcile_module._artifact_expected_name(payload) == artifact_name
     assert reviewer_bot.reconcile_module._artifact_expected_payload_name(payload) == payload_name
 
-
 def test_validate_workflow_run_artifact_identity_rejects_triggering_name_mismatch(monkeypatch):
     monkeypatch.setenv("WORKFLOW_RUN_TRIGGERING_NAME", "Wrong Workflow")
     monkeypatch.setenv("WORKFLOW_RUN_TRIGGERING_CONCLUSION", "success")
@@ -122,7 +120,6 @@ def test_validate_workflow_run_artifact_identity_rejects_triggering_name_mismatc
     with pytest.raises(RuntimeError, match="Triggering workflow name mismatch"):
         reviewer_bot.reconcile_module._validate_workflow_run_artifact_identity(payload)
 
-
 def test_validate_workflow_run_artifact_identity_rejects_run_attempt_mismatch(monkeypatch):
     monkeypatch.setenv("WORKFLOW_RUN_TRIGGERING_NAME", "Reviewer Bot PR Comment Observer")
     monkeypatch.setenv("WORKFLOW_RUN_TRIGGERING_ATTEMPT", "2")
@@ -139,7 +136,6 @@ def test_validate_workflow_run_artifact_identity_rejects_run_attempt_mismatch(mo
     with pytest.raises(RuntimeError, match="run_attempt mismatch"):
         reviewer_bot.reconcile_module._validate_workflow_run_artifact_identity(payload)
 
-
 def test_validate_workflow_run_artifact_identity_requires_successful_conclusion(monkeypatch):
     monkeypatch.setenv("WORKFLOW_RUN_TRIGGERING_NAME", "Reviewer Bot PR Comment Observer")
     monkeypatch.setenv("WORKFLOW_RUN_TRIGGERING_CONCLUSION", "failure")

tests/contract/reviewer_bot/test_workflow_files.py

@@ -1,22 +1,22 @@
 from pathlib import Path
+import pytest
 
-import yaml
+pytestmark = pytest.mark.contract
 
+import yaml
 
 def test_issue_comment_direct_workflow_exports_issue_state():
     workflow_text = Path(".github/workflows/reviewer-bot-issue-comment-direct.yml").read_text(
         encoding="utf-8"
     )
     assert "ISSUE_STATE: ${{ github.event.issue.state }}" in workflow_text
 
-
 def test_pr_comment_observer_workflow_builds_payload_inline_without_bot_src_root():
     workflow = Path(".github/workflows/reviewer-bot-pr-comment-observer.yml").read_text(encoding="utf-8")
     assert "BOT_SRC_ROOT" not in workflow
     assert "build_pr_comment_observer_payload" not in workflow
     assert "Fetch trusted bot source tarball" not in workflow
 
-
 def test_trusted_pr_comment_workflow_preflights_same_repo_before_mutation():
     data = yaml.safe_load(Path(".github/workflows/reviewer-bot-pr-comment-trusted.yml").read_text(encoding="utf-8"))
     job = data["jobs"]["reviewer-bot-pr-comment-trusted"]
@@ -31,7 +31,6 @@ def test_trusted_pr_comment_workflow_preflights_same_repo_before_mutation():
     assert "https://api.github.com/repos/{repo}/pulls/{pr_number}" in workflow_text
     assert "RUN_TRUSTED_PR_COMMENT" in workflow_text
 
-
 def test_pr_comment_observer_workflow_uses_inline_payload_builder():
     data = yaml.safe_load(Path(".github/workflows/reviewer-bot-pr-comment-observer.yml").read_text(encoding="utf-8"))
     job = data["jobs"]["observer"]
@@ -42,7 +41,6 @@ def test_pr_comment_observer_workflow_uses_inline_payload_builder():
     assert "build_pr_comment_observer_payload" not in workflow_text
     assert 'uv run --project "$BOT_SRC_ROOT"' not in workflow_text
 
-
 def test_review_comment_observer_workflow_exists_and_is_read_only():
     data = yaml.safe_load(
         Path(".github/workflows/reviewer-bot-pr-review-comment-observer.yml").read_text(encoding="utf-8")
@@ -60,7 +58,6 @@ def test_review_comment_observer_workflow_exists_and_is_read_only():
     assert "checkout" not in workflow_text
     assert "pull_request_review_comment" in workflow_text
 
-
 def test_mutating_reviewer_bot_workflows_do_not_share_global_github_concurrency():
     workflow_paths = [
         ".github/workflows/reviewer-bot-issues.yml",
@@ -76,7 +73,6 @@ def test_mutating_reviewer_bot_workflows_do_not_share_global_github_concurrency(
         for job in data.get("jobs", {}).values():
             assert "concurrency" not in job
 
-
 def test_workflow_policy_split_and_lock_only_boundaries():
     workflows_dir = Path(".github/workflows")
     required = {
@@ -111,14 +107,12 @@ def test_workflow_policy_split_and_lock_only_boundaries():
                 if value:
                     assert "@" in value and len(value.split("@", 1)[1]) == 40
 
-
 def test_workflow_summaries_and_runbook_references_exist():
     runbook = Path("docs/reviewer-bot-review-freshness-operator-runbook.md")
     assert runbook.exists()
     reconcile = Path(".github/workflows/reviewer-bot-reconcile.yml").read_text(encoding="utf-8")
     assert "docs/reviewer-bot-review-freshness-operator-runbook.md" in reconcile
 
-
 def test_build_pr_comment_observer_payload_marks_trusted_direct_same_repo_as_observer_noop(monkeypatch):
     from scripts import reviewer_bot
 

tests/integration/reviewer_bot/test_accept_no_fls_changes.py

@@ -1,12 +1,12 @@
 import json
 import subprocess
-
 import pytest
 
+pytestmark = pytest.mark.integration
+
 from builder import build_cli
 from scripts import reviewer_bot
 
-
 def test_list_changed_files_ignores_untracked_bootstrap_noise(monkeypatch, tmp_path):
     commands_seen = []
 
@@ -23,7 +23,6 @@ def fake_run_command(command, cwd, check=True):
     assert reviewer_bot.automation_module.list_changed_files(tmp_path) == []
     assert commands_seen == [["git", "diff", "--name-only"], ["git", "diff", "--cached", "--name-only"]]
 
-
 def test_list_changed_files_reports_tracked_changes_only(monkeypatch, tmp_path):
     def fake_run_command(command, cwd, check=True):
         if command == ["git", "diff", "--name-only"]:
@@ -36,7 +35,6 @@ def fake_run_command(command, cwd, check=True):
 
     assert reviewer_bot.automation_module.list_changed_files(tmp_path) == ["README.md", "src/spec.lock"]
 
-
 def test_accept_no_fls_changes_honors_explicit_target_repo_root(monkeypatch, tmp_path):
     monkeypatch.setenv("REVIEWER_BOT_TARGET_REPO_ROOT", str(tmp_path))
     monkeypatch.setenv("IS_PULL_REQUEST", "false")
@@ -55,7 +53,6 @@ def fake_list_changed_files(repo_root):
     assert (message, success) == ("❌ Working tree is not clean; refusing to update spec.lock.", False)
     assert observed["cwd"] == tmp_path
 
-
 def test_accept_no_fls_changes_uses_locked_nested_uv_commands(monkeypatch, tmp_path):
     monkeypatch.setenv("REVIEWER_BOT_TARGET_REPO_ROOT", str(tmp_path))
     monkeypatch.setenv("IS_PULL_REQUEST", "false")
@@ -86,7 +83,6 @@ def fake_run_command(command, cwd, check=False):
         (["uv", "run", "--locked", "python", "./make.py", "--update-spec-lock-file"], tmp_path, False),
     ]
 
-
 def test_accept_no_fls_changes_surfaces_locked_uv_failure_details(monkeypatch, tmp_path):
     monkeypatch.setenv("REVIEWER_BOT_TARGET_REPO_ROOT", str(tmp_path))
     monkeypatch.setenv("IS_PULL_REQUEST", "false")
@@ -110,7 +106,6 @@ def fake_run_command(command, cwd, check=False):
     assert "Audit command failed." in message
     assert "--locked was provided" in message
 
-
 def test_update_spec_lock_file_mode_exits_before_build_docs(monkeypatch, tmp_path):
     monkeypatch.setattr(
         build_cli.argparse.ArgumentParser,

tests/integration/reviewer_bot/test_app_closed_issue_cleanup.py

@@ -1,6 +1,8 @@
 from scripts import reviewer_bot
 from tests.fixtures.reviewer_bot import make_state
+import pytest
 
+pytestmark = pytest.mark.integration
 
 def test_execute_run_closed_issue_comment_cleanup_persists_removed_review_entry(monkeypatch):
     monkeypatch.setenv("EVENT_NAME", "issue_comment")
@@ -54,7 +56,6 @@ def fake_load_state(*, fail_on_unavailable=False):
     assert sync_calls[0][0] is reloaded_state
     assert sync_calls[0][1] == [42]
 
-
 def test_execute_run_closed_issue_comment_without_entry_skips_save(monkeypatch):
     monkeypatch.setenv("EVENT_NAME", "issue_comment")
     monkeypatch.setenv("EVENT_ACTION", "created")

tests/integration/reviewer_bot/test_app_execution.py

@@ -1,6 +1,8 @@
 from scripts import reviewer_bot
 from tests.fixtures.reviewer_bot import make_state
+import pytest
 
+pytestmark = pytest.mark.integration
 
 def test_execute_run_reloads_state_before_syncing_status_labels(monkeypatch):
     monkeypatch.setenv("EVENT_NAME", "issue_comment")
@@ -58,7 +60,6 @@ def fake_sync_status_labels_for_items(state, issue_numbers):
         "sync",
     ]
 
-
 def test_execute_run_returns_failure_when_save_state_fails(monkeypatch):
     monkeypatch.setenv("EVENT_NAME", "issue_comment")
     monkeypatch.setenv("EVENT_ACTION", "created")
@@ -75,7 +76,6 @@ def test_execute_run_returns_failure_when_save_state_fails(monkeypatch):
     assert result.exit_code == 1
     assert result.state_changed is True
 
-
 def test_execute_run_returns_failure_for_invalid_workflow_run_context(monkeypatch):
     monkeypatch.setenv("EVENT_NAME", "workflow_run")
     monkeypatch.setenv("EVENT_ACTION", "completed")