test: align reviewer-bot projection contract fixtures

Author: PLeVasseur

tests/integration/reviewer_bot/test_app_execution.py

@@ -732,7 +732,7 @@ def test_bootstrapped_runtime_pr_metadata_closed_executes_real_status_label_proj
     assert runtime.ACTIVE_LEASE_CONTEXT is None
 
 
-def test_bootstrapped_runtime_workflow_dispatch_repair_status_labels_uses_real_projection_path(monkeypatch):
+def test_bootstrapped_runtime_workflow_dispatch_repair_status_labels_uses_real_projection_path(monkeypatch, tmp_path):
     state = make_state()
     runtime, label_ops = _configure_bootstrapped_runtime_with_real_status_projection(
         monkeypatch, state, issue_state="open"
@@ -741,11 +741,17 @@ def test_bootstrapped_runtime_workflow_dispatch_repair_status_labels_uses_real_p
     monkeypatch.setenv("EVENT_NAME", "workflow_dispatch")
     monkeypatch.setenv("EVENT_ACTION", "")
     monkeypatch.setenv("MANUAL_ACTION", "repair-review-status-labels")
+    monkeypatch.setenv("VALIDATION_NONCE", "repair-nonce")
+    monkeypatch.setenv("GITHUB_REPOSITORY", "rustfoundation/safety-critical-rust-coding-guidelines")
+    monkeypatch.setenv("GITHUB_RUN_ID", "9001")
+    monkeypatch.setenv("GITHUB_RUN_ATTEMPT", "1")
+    monkeypatch.setenv("GITHUB_SHA", "workflow-head")
+    monkeypatch.setenv("REPAIR_SUMMARY_PATH", str(tmp_path / "repair-summary.json"))
 
     result = reviewer_bot.execute_run(reviewer_bot.build_event_context(runtime), runtime)
 
     assert result.exit_code == 0
-    assert result.state_changed is True
+    assert result.state_changed is False
     assert label_ops == [("remove", STATUS_AWAITING_REVIEWER_RESPONSE_LABEL)]
     assert runtime.ACTIVE_LEASE_CONTEXT is None
 

tests/integration/reviewer_bot/test_app_reviewer_board_preview.py

@@ -180,6 +180,9 @@ def test_execute_run_preview_reviewer_board_keeps_pr264_alternate_approval_proje
         ISSUE_NUMBER=264,
         VALIDATION_NONCE="board-preview-pr264",
         GITHUB_SHA="workflow-head",
+        GITHUB_REPOSITORY="rustfoundation/safety-critical-rust-coding-guidelines",
+        GITHUB_RUN_ID="1004",
+        GITHUB_RUN_ATTEMPT="1",
     )
     monkeypatch.setattr(harness.runtime, "_reviewer_board_project_metadata", None, raising=False)
 
@@ -233,24 +236,29 @@ def test_execute_run_preview_reviewer_board_keeps_pr264_alternate_approval_proje
 
     assert result.exit_code == 0
     payload = json.loads(capsys.readouterr().out)
-    assert payload == {
-        "schema_version": 1,
-        "preview_action": "preview-reviewer-board",
-        "issue_number": 264,
-        "validation_nonce": "board-preview-pr264",
-        "head_sha": "workflow-head",
-        "workflow_path": ".github/workflows/reviewer-bot-preview.yml",
-        "response_state": "reviewer_reassignment_needed",
-        "reviewer_authority_outcome": "tracked_reviewer_confirmed",
-        "suppression_reason": "transition_notice_sent",
-        "current_scope_key": "reviewer=iglesias|head=head-live|cycle=2026-02-10T17:20:07Z|anchor=2026-02-10T17:20:07Z",
-        "current_scope_basis": "active_cycle_started_at",
-        "would_post_warning": False,
-        "would_post_transition": False,
-        "lock_attempted": False,
-        "state_save_attempted": False,
-        "tracked_state_mutations_attempted": False,
-        "touched_projection_attempted": False,
-        "board_attention": "Transition Notice Sent",
-        "board_waiting_since": "2026-02-10",
-    }
+    assert payload["schema_version"] == 1
+    assert payload["preview_action"] == "preview-reviewer-board"
+    assert payload["issue_number"] == 264
+    assert payload["validation_nonce"] == "board-preview-pr264"
+    assert payload["evaluated_repo"] == "rustfoundation/safety-critical-rust-coding-guidelines"
+    assert payload["head_sha"] == "workflow-head"
+    assert payload["evaluated_ref"] == "workflow-head"
+    assert payload["workflow_path"] == ".github/workflows/reviewer-bot-preview.yml"
+    assert payload["run_id"] == "1004"
+    assert payload["run_attempt"] == "1"
+    assert payload["artifact_name"] == "reviewer-bot-preview-output-1004-attempt-1"
+    assert payload["artifact_file"] == "preview-output.json"
+    assert payload["response_state"] == "reviewer_reassignment_needed"
+    assert payload["reviewer_authority_outcome"] == "tracked_reviewer_confirmed"
+    assert payload["suppression_reason"] == "transition_notice_sent"
+    assert payload["current_scope_key"] == "reviewer=iglesias|head=head-live|cycle=2026-02-10T17:20:07Z|anchor=2026-02-10T17:20:07Z"
+    assert payload["current_scope_basis"] == "reminder_cadence_exhausted"
+    assert payload["would_post_warning"] is False
+    assert payload["would_post_transition"] is False
+    assert payload["lock_attempted"] is False
+    assert payload["state_save_attempted"] is False
+    assert payload["tracked_state_mutations_attempted"] is False
+    assert payload["touched_projection_attempted"] is False
+    assert payload["board_attention"] == "Transition Notice Sent"
+    assert payload["board_waiting_since"] == "2026-02-10"
+    assert payload["output_keys"] == sorted(payload.keys())

tests/unit/reviewer_bot/test_project_board.py

@@ -26,11 +26,12 @@
     review_payload,
     valid_reviewer_board_metadata,
 )
-from tests.fixtures.reviewer_bot_fakes import RouteGitHubApi
+from tests.fixtures.reviewer_bot_fakes import RouteGitHubApi, github_result
 
 
 def _runtime(monkeypatch, routes=None):
     runtime = FakeReviewerBotRuntime(monkeypatch)
+    runtime.github.get_issue_assignees_result = lambda issue_number, is_pull_request=None: github_result(200, [])
     if routes is not None:
         runtime.github.stub(routes)
     return runtime

tests/unit/reviewer_bot/test_reviews_live_fetch.py

@@ -23,6 +23,7 @@
 def _runtime(monkeypatch, routes=None):
     runtime = FakeReviewerBotRuntime(monkeypatch)
     runtime.github.get_issue_or_pr_snapshot = lambda issue_number: issue_snapshot(issue_number, state="open", is_pull_request=True)
+    runtime.github.get_issue_assignees_result = lambda issue_number, is_pull_request=None: github_result(200, [])
     runtime.github.get_user_permission_status = lambda username, required_permission="push": "granted"
     if routes is not None:
         runtime.github.stub(routes)