Skip to content

Fix reviewer-bot observer no-op reconcile handling#447

Merged
PLeVasseur merged 1 commit intoSafety-Critical-Rust-Consortium:mainfrom
PLeVasseur:fix/reviewer-bot-observer-noop-reconcile
Mar 17, 2026
Merged

Fix reviewer-bot observer no-op reconcile handling#447
PLeVasseur merged 1 commit intoSafety-Critical-Rust-Consortium:mainfrom
PLeVasseur:fix/reviewer-bot-observer-noop-reconcile

Conversation

@PLeVasseur
Copy link
Copy Markdown
Collaborator

Summary

  • make ignored PR comment observer runs emit an explicit no-op marker artifact
  • teach trusted reconcile to accept that no-op marker and exit cleanly without mutating state
  • prevent intentionally ignored observer events from showing up as red reconcile failures

What Changed

  • update the PR comment observer workflow so ignored automation/self-comment cases produce an explicit JSON no-op marker artifact instead of succeeding with no payload
  • update reconcile handling to validate and accept that no-op marker contract
  • add regression coverage for the no-op payload path

Validation

  • uv run python -m pytest .github/reviewer-bot-tests/test_reviewer_bot.py .github/reviewer-bot-tests/test_main.py
  • uv run ruff check --fix scripts .github/reviewer-bot-tests/test_reviewer_bot.py .github/reviewer-bot-tests/test_main.py

Notes

  • this fix preserves fail-closed behavior for malformed or ambiguous payloads
  • it only changes the contract for successful observer no-op cases so they stop producing false-positive reconcile failures

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 17, 2026

Deploy Preview for scrc-coding-guidelines ready!

Name Link
🔨 Latest commit be3a35d
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/69b9b9543d47180008f6807a
😎 Deploy Preview https://deploy-preview-447--scrc-coding-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PLeVasseur PLeVasseur merged commit 56c32fe into Safety-Critical-Rust-Consortium:main Mar 17, 2026
16 checks passed
@PLeVasseur PLeVasseur deleted the fix/reviewer-bot-observer-noop-reconcile branch March 17, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant