Skip to content

fix(reviewer-bot): align overdue reminders with reviewer state#542

Merged
PLeVasseur merged 1 commit into
Safety-Critical-Rust-Consortium:mainfrom
PLeVasseur:fix/reviewer-bot-align-overdue-and-label-repair
Mar 26, 2026
Merged

fix(reviewer-bot): align overdue reminders with reviewer state#542
PLeVasseur merged 1 commit into
Safety-Critical-Rust-Consortium:mainfrom
PLeVasseur:fix/reviewer-bot-align-overdue-and-label-repair

Conversation

@PLeVasseur

Copy link
Copy Markdown
Collaborator

Summary

  • collect touched PRs when scheduled reviewer-review repair mutates state so repaired items get status-label reprojection in the same maintenance run
  • add a shared reviewer-turn model so label projection and overdue reminder logic agree about whether reviewer or contributor currently owes action
  • stop reviewer reminders for PRs like [Coding Guideline]: Do Not Depend on Function Pointer Identity #256 where the current reviewer already reviewed the current head, while preserving stale-head and contributor-newer behavior

Testing

  • uv run pytest .github/reviewer-bot-tests/test_reviewer_bot.py .github/reviewer-bot-tests/test_main.py
  • uv run ruff check --fix

@netlify

netlify Bot commented Mar 26, 2026

Copy link
Copy Markdown

Deploy Preview for scrc-coding-guidelines ready!

Name Link
🔨 Latest commit 5f77cc3
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/69c58d78dc5b0b0008620598
😎 Deploy Preview https://deploy-preview-542--scrc-coding-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PLeVasseur
PLeVasseur merged commit 2f3b7c4 into Safety-Critical-Rust-Consortium:main Mar 26, 2026
16 checks passed
@PLeVasseur
PLeVasseur deleted the fix/reviewer-bot-align-overdue-and-label-repair branch March 26, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant