diff --git a/run_docker.py b/run_docker.py index d03d080..485b143 100644 --- a/run_docker.py +++ b/run_docker.py @@ -97,7 +97,26 @@ def untar(directory, tar_filename): tar_filename: tar file path """ with tarfile.open(tar_filename, "r") as tar_o: - tar_o.extractall(path=directory) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar_o, path=directory) def main(syn, args):